Improve render sample using wxGCDC in wxMSW dark mode (PR #26788)

[PB]

Before (notice missing control labels on the left)
Image: render-sample-before (view on web)

After
Image: render-sample-after (view on web)

It may be unexpected that wxGCDC created from wxPaintDC does not "inherit" the default attributes such as the text color, but I guess there is a reason why it was done like this.

The render sample exposes some issues in wxRendererNative on MSW (e.g. the DrawItemText() not working with wxGCDC as seen in the screenshots) but I will create a separate issue for that.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/26788

Commit Summary

• 26ea0a2 Improve render sample using wxGCDC in wxMSW dark mode

File Changes

(1 file)

• M samples/render/render.cpp (1)

Patch Links:

• https://github.com/wxWidgets/wxWidgets/pull/26788.patch
• https://github.com/wxWidgets/wxWidgets/pull/26788.diff

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26788@github.com>

[VZ]

vadz left a comment (wxWidgets/wxWidgets#26788)

Thanks, I'll apply this but...

It may be unexpected that wxGCDC created from wxGraphicsContext created from wxPaintDC does not "inherit" the default attributes such as the text color, but I guess there is a reason why it was done like this.

... I'm not really sure there is a reason for this. IMO it would make sense to inherit the attributes (i.e. colours and font) in this case too and this probably needs to be fixed (and then this PR could be reverted).

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26788/c5208726981@github.com>

[VZ]

Closed #26788 via 17e670d.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26788/issue_event/29085661256@github.com>