Make it possible to choose during run-time between using GLX and EGL (PR #26023)
VZ
We've discussed this several times in the past and I've finally implemented the necessary refactoring to allow selecting between GLX and EGL at run-time, e.g. to allow users having problems with EGL to try using GLX (which is only possible when also using X11, of course, so this is probably much less useful now that Wayland is much more widespread than when we started talking about doing this, but better late than never, isn't it).
I'd like to clean up a couple of things here but I think this can already be tested and any such testing before I merge this would be really appreciated!
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26023
Commit Summary
File Changes
(34 files)
- M Makefile.in (29)
- M build/bakefiles/files.bkl (7)
- M build/cmake/files.cmake (7)
- M build/cmake/init.cmake (1)
- M build/cmake/setup.h.in (5)
- M build/files (7)
- M configure (53)
- M configure.ac (2)
- M docs/changes.txt (4)
- M docs/doxygen/mainpages/const_cpp.h (4)
- M include/wx/android/setup.h (8)
- M include/wx/glcanvas.h (41)
- M include/wx/gtk/app.h (2)
- M include/wx/gtk/glcanvas.h (15)
- M include/wx/gtk/setup.h (8)
- M include/wx/msw/setup.h (8)
- M include/wx/osx/setup.h (8)
- M include/wx/setup_inc.h (8)
- M include/wx/univ/setup.h (8)
- R include/wx/unix/glcanvas.h (89)
- D include/wx/unix/glegl.h (206)
- A include/wx/unix/private/glcanvas.h (162)
- A include/wx/unix/private/glegl.h (188)
- A include/wx/unix/private/glx11.h (131)
- M include/wx/x11/glcanvas.h (6)
- M interface/wx/glcanvas.h (34)
- M samples/opengl/cube/cube.cpp (36)
- M samples/opengl/cube/cube.h (1)
- M setup.h.in (5)
- M setup.h_vms (2)
- M src/gtk/glcanvas.cpp (22)
- A src/unix/glcanvas.cpp (356)
- M src/unix/glegl.cpp (367)
- M src/unix/glx11.cpp (392)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26023.patch
- https://github.com/wxWidgets/wxWidgets/pull/26023.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 6 commits.
- 0b574c2 Add make_unique fallback implementation
- d9df7db Allow choosing between GLX and EGL during run-time
- 4817bb5 Remove redundant eglBindAPI() call
- e9647b5 Document wxGLCanvas::GetGLXVersion()
- 3ab85db Add wxGLCanvas::GetEGLVersion() to wxGTK and wxX11
- edb824a Make wxGLContextX11 ctor code a bit shorter and more clear
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 2 commits.
- 946ae2e Add wxGLCanvas::GetEGLVersion() to wxGTK and wxX11
- 242dacd Make wxGLContextX11 ctor code a bit shorter and more clear
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26023)This should be good to merge now, AFAICS. Please let me know if anybody sees any problems with it!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Scott Talbert
swt2c left a comment (wxWidgets/wxWidgets#26023)Thanks a lot for doing this! Will try to take a deeper look later today.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.