Fix crash on static page of widgets sample (PR #24660)

12 views
Skip to first unread message

PB

unread,
Jun 30, 2024, 5:18:48 PM (5 days ago) Jun 30
to wx-...@googlegroups.com, Subscribed

Attempting to change the style or alignment of the static text in the widgets sample made the sample crash. The bug cause was the same as in 7c125d3 (Fix crash on spin page of widgets sample, 2024-04-18), i.e., a8b4753 (Reconnect events to the widget after recreating it in the sample, 2024-02-19).

Fix the issue by calling NotifyWidgetRecreation() for each control only after they were all recreated.

Closes #24656.


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/24660

Commit Summary

  • 5754219 Fix crash on static page of widgets sample

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/24660@github.com>

VZ

unread,
Jul 3, 2024, 7:29:31 PM (2 days ago) Jul 3
to wx-...@googlegroups.com, Subscribed

Thanks for fixing this, I didn't have time to think about better solution (or even why is this one not the best), but I'll merge this already to fix a crash for now.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/24660/c2207498674@github.com>

VZ

unread,
Jul 3, 2024, 7:35:00 PM (2 days ago) Jul 3
to wx-...@googlegroups.com, Subscribed

Closed #24660 via 19ec50b.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/24660/issue_event/13387415490@github.com>

Reply all
Reply to author
Forward
0 new messages