Re-re-enable using pkg-config when targeting Linux systems (PR #23176)

8 views
Skip to first unread message

VZ

unread,
Jan 24, 2023, 7:17:59 PM1/24/23
to wx-...@googlegroups.com, Subscribed

The change of 7899850 (Do use host-specific pkg-config when cross-compiling, 2022-12-15) should have been done in addition to the previous logic instead of replacing it, as it has resulted in not using pkg-config any more when targeting Linux systems, which wasn't the intention.

So re-apply the changes of d6ddfe8 (Disable build system pkg-config when cross-compiling to non-Linux, 2022-11-30) to handle cross-compiling to Linux specially.

This makes the logic even uglier than before, but it still seems like the most pragmatic solution and the original intention was always to do this and not the wrongly simplified version that was actually applied.

See #22886, #23037, #23171.


I've somehow managed to do something rather different from what I wanted to do in the last change here, as I've realized while looking at #23171, so here is the hopefully final version.


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/23176

Commit Summary

  • b0056f8 Re-re-enable using pkg-config when targeting Linux systems

File Changes

(2 files)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23176@github.com>

VZ

unread,
Jan 25, 2023, 8:28:10 AM1/25/23
to wx-...@googlegroups.com, Subscribed

Merged #23176 into master.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23176/issue_event/8354767316@github.com>

Reply all
Reply to author
Forward
0 new messages