HTML: Honor TABLE ALIGN as table placement (PR #26672)

Richard Thomson

unread,

Jul 8, 2026, 5:19:14 PM (yesterday) Jul 8

to wx-...@googlegroups.com, Subscribed

Apply TABLE ALIGN to the wrapper that positions the table instead of using it as the default alignment for TD/TH content. Leave cell text alignment controlled by row/cell alignment, with the existing TH default.

Add a parser layout regression test and sample markup for the centered table case.

Fixes #21853

You can view, comment on, or merge this pull request online at:

https://github.com/wxWidgets/wxWidgets/pull/26672

Commit Summary

a1ebe14 HTML: Honor TABLE ALIGN as table placement

File Changes

(3 files)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.

Richard Thomson

unread,

11:31 AM (9 hours ago) 11:31 AM

to wx-...@googlegroups.com, Subscribed

LegalizeAdulthood left a comment (wxWidgets/wxWidgets#26672)

the CI failure is a test_gui.exe hang/timeout in the AppVeyor VS2019 Debug x64 job, not an assertion failure and not a compiler error.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Richard Thomson

unread,

12:33 PM (8 hours ago) 12:33 PM

to wx-...@googlegroups.com, Subscribed

LegalizeAdulthood left a comment (wxWidgets/wxWidgets#26672)

I don't think this AppVeyor test_gui hang is caused by this PR.

The PR changes only wxHTML table parsing/layout plus the new wxHtmlParser::TableAlign regression test. Locally on issue-21853:

test_gui.exe "wxHtmlParser::TableAlign" passes.
test_gui.exe "[html][parser]" passes.
test_gui.exe "[html]" passes.

The AppVeyor failure is the VS2019 Debug x64 job. Non-GUI tests pass, then the log stops immediately after the test_gui banner and the job times out.

Locally, the suspicious part is reproducible with the WebView tests, not the HTML tests:

test_gui.exe "WebView*" shows WebView load failures, then crashes with SIGSEGV.
Windows also reports msedgewebview2.exe hitting a breakpoint, followed by test_gui.exe reading from 0xffffffffffffffff.

So the likely cause is Edge WebView2 / tests/controls/webtest.cpp / runner state, not the table alignment change. A rerun, or a run excluding [wxWebView], should confirm this.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward