CMake: Fix wxBUILD_INSTALL_*_DIRs being converted to absolute paths (PR #25756)

12 views
Skip to first unread message

Chris Mayo

unread,
Sep 2, 2025, 2:27:57 PM (5 days ago) Sep 2
to wx-...@googlegroups.com, Subscribed

When the user specifies a relative directory CMake is prepending the build directory to the variable because it is of type PATH.

They should be relative to CMAKE_INSTALL_PREFIX.


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/25756

Commit Summary

  • 4597fca CMake: Fix wxBUILD_INSTALL_*_DIRs being converted to absolute paths

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25756@github.com>

VZ

unread,
Sep 2, 2025, 5:30:37 PM (5 days ago) Sep 2
to wx-...@googlegroups.com, Subscribed
vadz left a comment (wxWidgets/wxWidgets#25756)

Thanks, the explanation makes sense to me.

@MaartenBent OK to apply this one?

On an unrelated note, any idea why do your PRs (and AFAICS only yours) result in this Circle CI error?


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25756/c3246846929@github.com>

Maarten

unread,
Sep 2, 2025, 5:33:01 PM (5 days ago) Sep 2
to wx-...@googlegroups.com, Subscribed

@MaartenBent approved this pull request.

Yes, looks good to me!


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25756/review/3178195863@github.com>

VZ

unread,
Sep 6, 2025, 3:21:32 PM (19 hours ago) Sep 6
to wx-...@googlegroups.com, Subscribed

Closed #25756 via 1098d27.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25756/issue_event/19546809988@github.com>

Reply all
Reply to author
Forward
0 new messages