Fix for a check of the combobox enable state, when control is recreating (PR #23132)

14 views
Skip to first unread message

Oleksandra Yushchenko

unread,
Jan 12, 2023, 5:16:40 AM1/12/23
to wx-...@googlegroups.com, Subscribed

For check of the ComboBox enable state is better to use IsThisEnable() instead of IsEnable(), IsEnabled() == IsThisEnabled() && parent.IsEnabled(). As a result it is possible, that when TopLevelWindow is disabled at the moment of a control recreation, then ComboBox is recreated with disable state.


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/23132

Commit Summary

  • 36f9c55 Fix for a check of the combobox enable state, when control is recreating

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23132@github.com>

VZ

unread,
Jan 12, 2023, 6:09:21 AM1/12/23
to wx-...@googlegroups.com, Subscribed

Thanks for the fix! I agree that this is the right thing to do and will merge it soon (and also backport to 3.2).


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23132/c1380167774@github.com>

VZ

unread,
Jan 12, 2023, 11:36:03 AM1/12/23
to wx-...@googlegroups.com, Subscribed

Closed #23132 via 8e60492.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23132/issue_event/8213242827@github.com>

Reply all
Reply to author
Forward
0 new messages