Fix broken MSVS 2015 build (PR #26144)
PB
The ancient MSVS 2015 is used to build the official binaries.
I suppose no CI service used supports it anymore...
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26144
Commit Summary
- a7c5f37 Fix broken MSVS 2015 build
File Changes
(1 file)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26144.patch
- https://github.com/wxWidgets/wxWidgets/pull/26144.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26144)Thanks, I'll commit this but we do have a MSVS 2015 CI job on AppVeyor, so this must be due to not using a recent enough SDK version.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
PB
PBfordev left a comment (wxWidgets/wxWidgets#26144)Thanks, I'll commit this but we do have a MSVS 2015 CI job on AppVeyor, so this must be due to not using a recent enough SDK version.
I freshly installed MSVS Express 2015 for Windows Desktop (v14.0.25431.01 Update 3). I don't think this version can update SDKs on its own...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26144)Is it not possible to install standalone SDK package? Anyhow, AppVeyor somehow manages to use newer SDK, apparently...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
PB
PBfordev left a comment (wxWidgets/wxWidgets#26144)I see. Since I have no idea how to fix the mixed EOL issue; and more importantly, if there are people still actually using MSVS 2015 they probably do not use the very outdated SDK with it, so I guess it would be for the best to close the Issue. Sorry for the noise.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
PB
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26144)I've already fixed the EOLs (you must have edited the file which was in Unix format under Windows?) and applied this locally and will push it, it does no harm, and if it can help some poor soul still stuck on MSVS 2015, why not.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.