Don't let a page header or footer paint over the page body (PR #26915)
Gunter Königsman
When porting wxWidgets to GTK4 Claude reckons to have found 6 bugs in wxWidgets that hinder samples, example applications or tests from working. To me as a casual outsider the patches look like actually resolving existing bugs. I currently push them as separate pull requests so they can be individually reviewed.
wxHtmlPrintout::RenderPage() renders the body first and then the header and footer through m_RendererHdr, calling
m_RendererHdr.Render(x, y);
which leaves wxHtmlDCRenderer::Render()'s "to" parameter at its INT_MAX default. The header is therefore free to draw the full height of its HTML, not just the header area -- and an HTML background colour drawn by the header covers the body that was rendered underneath it.
Pass the header and footer heights, which RenderPage() already knows, as the bound.
The test renders a page with a body background colour and a header into a wxMemoryDC and checks that a pixel well inside the body still has the body's colour.
(cherry picked from commit 7775a75)
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26915
Commit Summary
- 4f947fe Don't let a page header or footer paint over the page body
File Changes
(2 files)
- M src/html/htmprint.cpp (8)
- M tests/html/htmprint.cpp (34)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26915.patch
- https://github.com/wxWidgets/wxWidgets/pull/26915.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26915)This looks good to me too, so I'll merge it soon, thanks.
Please don't use "cherry picked from private commit", this is not useful.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.