Modernize and clean up XRC code (PR #23180)
13 views
Skip to first unread message
VZ
Jan 26, 2023, 8:49:38 PM1/26/23
to wx-...@googlegroups.com, Subscribed
No real changes here, this is just cleanup in preparation for other things.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/23180
Commit Summary
- 0804529 Use std::unordered_set<> instead of WX_DECLARE_HASH_SET_PTR
- 1fa95ec Replace wxVector<wxIdRange*> with std::vector<wxIdRange>
- ef98315 Replace another wxVector with std::vector
- 8beb2fd Remove "xrc" tag from XRC test disabled by default
- 7dede29 Use vector of unique_ptr<> instead of raw pointers
- 395f745 Make wxXmlResourceDataRecord::Doc a smart pointer
- 77a545d Make wxXmlResource::ms_subclassFactories vector of smart pointers
- 2556b11 Use vector of wxXmlResourceDataRecord objects, not pointers
- c16eb74 Hide all vectors inside wxXmlResourceInternal
File Changes
(3 files)
- M include/wx/xrc/xmlres.h (14)
- M src/xrc/xmlres.cpp (275)
- M tests/xml/xrctest.cpp (2)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/23180.patch
- https://github.com/wxWidgets/wxWidgets/pull/23180.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Jan 26, 2023, 8:50:34 PM1/26/23
to wx-...@googlegroups.com, Subscribed
@vadz commented on this pull request.
> + if (isok && c->GetAttribute("", &s))
+ {
+ }
+
Oops, this is a leftover, will remove.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Jan 26, 2023, 9:15:48 PM1/26/23
to wx-...@googlegroups.com, Push
@vadz pushed 9 commits.
- 101efe5 Use std::unordered_set<> instead of WX_DECLARE_HASH_SET_PTR
- 11659cb Replace wxVector<wxIdRange*> with std::vector<wxIdRange>
- af9260a Replace another wxVector with std::vector
- 7b542ed Remove "xrc" tag from XRC test disabled by default
- a8e5553 Use vector of unique_ptr<> instead of raw pointers
- f457f99 Make wxXmlResourceDataRecord::Doc a smart pointer
- 2c49a6c Make wxXmlResource::ms_subclassFactories vector of smart pointers
- 2f70ace Use vector of wxXmlResourceDataRecord objects, not pointers
- 8780422 Hide all vectors inside wxXmlResourceInternal
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Jan 28, 2023, 7:45:49 PM1/28/23
to wx-...@googlegroups.com, Subscribed
Merged #23180 into master.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Reply all
Reply to author
Forward
0 new messages