Re: #14132: wxComboBox needs wxTE_PROCESS_ENTER and wxEVT_COMMAND_TEXT_ENTER from wx/textctrl.h but does not include it

[wxTrac]

#14132: wxComboBox needs wxTE_PROCESS_ENTER and wxEVT_COMMAND_TEXT_ENTER from
wx/textctrl.h but does not include it
--------------------------+----------------------------------------------
Reporter: cherzig | Owner:
Type: build error | Status: closed
Priority: normal | Milestone:
Component: wxMSW | Version: 2.9.3
Resolution: fixed | Keywords: regression wxComboBox wxTextCtrl
Blocked By: | Blocking:
Patch: 0 |
--------------------------+----------------------------------------------

Comment (by Vadim Zeitlin <vadim@…>):

In [changeset:"d3eafa4d185d8c98d4178a4f4937d3b800d8128d/git-wxWidgets"
d3eafa4d1/git-wxWidgets]:
{{{
#!CommitTicketReference repository="git-wxWidgets"
revision="d3eafa4d185d8c98d4178a4f4937d3b800d8128d"
Fix compilation of wxFormBuilder-generated code using wxTE_XXX

Move definitions of wxTE_XXX flags that can be used with the controls
other than wxTextCtrl to wx/defs.h, as wxFormBuilder generates code
using them without including wx/textctrl.h, so that this code doesn't
compile.

This was already addressed in 2970f22a89 (Include <wx/textctrl.h> from
<wx/combobox.h> for compatibility., 2012-03-25) for wxComboBox, but it
also happened for wxSpinCtrl, so fix it once and for all by always
defining these styles.

This partially reverts the changes done in c57e33394c ([...] moved
wxTextCtrl-specific stuff from defs.h/event.h to textctrl.h, 2001-07-29)
as it turns out, 20 years later, that this wasn't such a great idea.

See #14132.

Closes #19225.
}}}

--
Ticket URL: <https://trac.wxwidgets.org/ticket/14132#comment:6>

[wxTrac]

#14132: wxComboBox needs wxTE_PROCESS_ENTER and wxEVT_COMMAND_TEXT_ENTER from
wx/textctrl.h but does not include it
--------------------------+----------------------------------------------
Reporter: cherzig | Owner:
Type: build error | Status: closed
Priority: normal | Milestone:
Component: wxMSW | Version: 2.9.3
Resolution: fixed | Keywords: regression wxComboBox wxTextCtrl
Blocked By: | Blocking:
Patch: 0 |
--------------------------+----------------------------------------------

Comment (by Vadim Zeitlin <vadim@…>):

In [changeset:"bd423096df59631b8423214ec76efe6f86af2308/git-wxWidgets"
bd423096d/git-wxWidgets]:
{{{
#!CommitTicketReference repository="git-wxWidgets"
revision="bd423096df59631b8423214ec76efe6f86af2308"
Restore recently removed #include wx/textctrl.h in wx/combobox.h

Some existing code relies on wxEVT_TEXT being defined after including
just wx/combobox.h too, so just keep this formally unnecessary but by
now impossible to remove #include removed in d3eafa4d18 (Fix compilation
of wxFormBuilder-generated code using wxTE_XXX, 2021-07-14).

See #14132.

Closes #19264.
}}}

--
Ticket URL: <https://trac.wxwidgets.org/ticket/14132#comment:7>