Insertion of a missing semicolon (PR #26764)
Yannick Duchêne
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26764
Commit Summary
- eec418e Inserted a missing semicolon. Fixes https://github.com/wxWidgets/wxWidgets/issues/26754
- 1abea72 Merge branch 'wxWidgets:master' into Hibou57-patch-4
File Changes
(1 file)
- M interface/wx/grid.h (2)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26764.patch
- https://github.com/wxWidgets/wxWidgets/pull/26764.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Yannick Duchêne
@Hibou57 pushed 2 commits.
- d8be4ef Inserted a missing semicolon (bis)
- e521d5e Merge branch 'Hibou57-patch-4' of https://github.com/Hibou57/wxWidgets into Hibou57-patch-4
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26764)Thanks, I'll apply this soon.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Yannick Duchêne
@Hibou57 pushed 1 commit.
- 5fcea5d Correct syntax for two conversion operators
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Yannick Duchêne
@Hibou57 pushed 1 commit.
- a0f7c64 Correct syntax for two conversion operators (bis)
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26764)Wait, if you keep adding commits, I'm not going to apply it — please let me know when you're done.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Yannick Duchêne
Hibou57 left a comment (wxWidgets/wxWidgets#26764)Wait, if you keep adding commits, I'm not going to apply it — please let me know when you're done.
My fault, I erroneously understood “soon” as within a few days. It’s all OK now, there is no other errors of the like anywhere, except for one thing. I would like to propose another commit, but since I’m sure this other one will be accepted, I prefer to defer it to another pull-request.
Have a pleasant day :)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Yannick Duchêne
Hibou57 left a comment (wxWidgets/wxWidgets#26764)Something was not OK?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26764)Sorry, what do you mean? I've applied your changes to master, see the commit referenced above.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Yannick Duchêne
Hibou57 left a comment (wxWidgets/wxWidgets#26764)Indeed, the commit was merged. At first sight I saw the PR colored in red and saying “unmerged commit”. I’m not entirely at ease with GitHub, may be I missed something.
May propose another commit later, but I’m unsure with this one.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26764)Please open new PRs for any further fixes. Also, avoid merging master into the branch from which you make the PR, if really necessary you can always rebase it on master. But normally once you have created a PR you shouldn't modify it without being invited to do it as it is confusing for the reviewer(s). You may mark the PR as draft if you really want to be able to add more changes to it later but it's better to just postpone creating it until you have all the changes you want to submit.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.