3.2 backports 202606 (PR #26555)
VZ
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26555
Commit Summary
- 4069a67 Fix out-of-bounds read on truncated UTF-8 in wxUString
- d256b9f Fix rowspan/colspan integer overflow in wxHtmlTableCell::AddCell()
File Changes
(3 files)
- M docs/changes.txt (2)
- M src/common/ustring.cpp (9)
- M src/html/m_tables.cpp (9)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26555.patch
- https://github.com/wxWidgets/wxWidgets/pull/26555.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 1 commit.
- 6313a71 Update GitHub Actions to be Node v24 compatible
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Scott Talbert
swt2c left a comment (wxWidgets/wxWidgets#26555)@vadz a few more tweaks to the commit for 3.2:
diff --git a/.github/workflows/abi_check.yml b/.github/workflows/abi_check.yml
index c43bf0baa1..1cafdbf9a6 100644
--- a/.github/workflows/abi_check.yml
+++ b/.github/workflows/abi_check.yml
@@ -55,12 +55,12 @@ jobs:
steps:
- name: Checkout
- uses: actions/checkout@v3
+ uses: actions/checkout@v6
with:
submodules: 'recursive'
- name: Install CCache
- uses: hendrikmuhs/ccache...@v1.2.3
+ uses: hendrikmuhs/ccache...@v1.2.23
with:
key: ubuntu-22.04-default
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 9c606447c3..075cae0819 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -338,6 +338,7 @@ jobs:
uses: actions/setup-go@v6
with:
go-version: '1'
+ cache: false
- name: Testing
working-directory: tests
diff --git a/.github/workflows/ci_cmake.yml b/.github/workflows/ci_cmake.yml
index 2df4a8ef28..210974817e 100644
--- a/.github/workflows/ci_cmake.yml
+++ b/.github/workflows/ci_cmake.yml
@@ -150,6 +150,7 @@ jobs:
uses: actions/setup-go@v6
with:
go-version: '1'
+ cache: false
- name: Testing
if: matrix.cmake_tests != 'OFF'
diff --git a/.github/workflows/ci_mac.yml b/.github/workflows/ci_mac.yml
index 6f1210aeb7..2e7d6d502f 100644
--- a/.github/workflows/ci_mac.yml
+++ b/.github/workflows/ci_mac.yml
@@ -212,6 +212,7 @@ jobs:
uses: actions/setup-go@v6
with:
go-version: '1'
+ cache: false
- name: Testing
if: matrix.skip_testing != true
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 1 commit.
- b153cc9 Update GitHub Actions to be Node v24 compatible
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26555)Thanks, applied and force pushed as I amended the same commit to include these changes too.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Scott Talbert
swt2c left a comment (wxWidgets/wxWidgets#26555)Thanks, applied and force pushed as I amended the same commit to include these changes too.
Not terribly important, but it looks like you missed the cache: false hunk for ci_cmake.yml.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 3 commits.
- b65c452 Update GitHub Actions to be Node v24 compatible
- 5f5813c Fix out-of-bounds read on trailing % in wxDateTime::Format()
- bc9a722 Fix off-by-one in hostent/servent pointer list terminator
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26555)Argh, thanks for noticing, hopefully did it right now.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 6 commits.
- 1d30d96 wxOSX: perform cleanup when applicationWillTerminate: is called
- c205faa Validate background colour index in wxGIFDecoder::LoadGIF()
- 591e1a1 Avoid uninitialised palette read in wxXPMDecoder::ReadData()
- a2bbc84 Fix drawing of very large bitmaps with GTK3
- 5dafc37 Update version to 3.2.11
- 80a009d Add wxGrid::GetFrozenRowLabelWindow() and GetFrozenColLabelWindow()
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 5 commits.
- bb8d1de Validate background colour index in wxGIFDecoder::LoadGIF()
- 9c0a547 Avoid uninitialised palette read in wxXPMDecoder::ReadData()
- 7406731 Fix drawing of very large bitmaps with GTK3
- e2e1e14 Update version to 3.2.11
- 72795c9 Add wxGrid::GetFrozenRowLabelWindow() and GetFrozenColLabelWindow()
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 4 commits.
- 64576a0 Avoid uninitialised palette read in wxXPMDecoder::ReadData()
- ea419d1 Fix drawing of very large bitmaps with GTK3
- 03e45c4 Update version to 3.2.11
- 17b5315 Add wxGrid::GetFrozenRowLabelWindow() and GetFrozenColLabelWindow()
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#26555)I started backporting some CMake stuff. When building the library I get the following error:
src\common\socket.cpp(1160,10): error C2039: 'vector': is not a member of 'std'
This should be wxVector. Can you add this fix to this PR? Thanks.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26555)Will do, thanks, but I don't understand how this didn't get detected by the C++98 CI job.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 1 commit.
- e496bf4 Use wxVector<> instead of vector<> in wxSocket code
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#26555)I think because wxUSE_STD_DEFAULT value is 1 in all setup.h files, except in CMake were it was not defined.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#26555)Oh, set(wxUSE_STD_DEFAULT ON) was removed when I updated init.cmake with the wx3.3 version. That's why this build error suddenly appeared.
So this error would've only happened if users use a custom setup.h (cmake/configure do not have a build option to disable it).
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.