Re: MSW: Print preview requires wxUSE_ENH_METAFILE (#11199)

6 views
Skip to first unread message

Richard Thomson

unread,
2:23 AM (15 hours ago) 2:23 AM
to wx-...@googlegroups.com, wxtrac, Author
LegalizeAdulthood left a comment (wxWidgets/wxWidgets#11199)

I checked this against the current tree and couldn't reproduce the old link failure.

Tested with MSVC/CMake using:

cmake -S C:\code\wxWidgets\wxWidgets -B C:\tmp\wx-11199-no-emf ^
-G "Visual Studio 18 2026" ^
-DwxUSE_PRINTING_ARCHITECTURE=ON ^
-DwxUSE_ENH_METAFILE=OFF ^
-DwxBUILD_SAMPLES=OFF ^
-DwxBUILD_TESTS=OFF

cmake --build C:\tmp\wx-11199-no-emf --target wxcore --config Debug

wxcore built successfully.

The current code also wraps the enhanced-metafile-specific wxWindowsPrintPreview::RenderPageIntoBitmap() override in #if wxUSE_ENH_METAFILE, so when enhanced metafiles are disabled the build no longer references wxEnhMetaFile or wxEnhMetaFileDC from that code path.

So this appears to be obsolete in the current tree, at least for the CMake/MSVC build.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you authored the thread.Message ID: <wxWidgets/wxWidgets/issues/11199/4932590631@github.com>

Reply all
Reply to author
Forward
0 new messages