Add wxRibbonMSWFlatArtProvider, a (Fluent UI) flat ribbon art provider (PR #26253)
Blake-Madden
Also, add pointer and underflow checks and proper wxDCClipper usage in other art providers, add descriptions for all of them to the help.
Old MSW provider:
image.png (view on web)New one:
image.png (view on web)You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26253
Commit Summary
- 77eb098 Add wxRibbonMSWFlatArtProvider, a (Fluent UI like) flat ribbon art provider
- fa41715 Remove implementation leakage
File Changes
(17 files)
- M Makefile.in (16)
- M build/bakefiles/files.bkl (1)
- M build/cmake/files.cmake (1)
- M build/files (1)
- M build/msw/makefile.gcc (16)
- M build/msw/makefile.vc (16)
- M build/msw/wx_ribbon.vcxproj (1)
- M build/msw/wx_ribbon.vcxproj.filters (3)
- M build/osx/wxcocoa.xcodeproj/project.pbxproj (8)
- M build/osx/wxiphone.xcodeproj/project.pbxproj (4)
- M include/wx/ribbon/art.h (102)
- M interface/wx/ribbon/art.h (47)
- M samples/ribbon/ribbondemo.cpp (10)
- M src/ribbon/art_aui.cpp (6)
- M src/ribbon/art_msw.cpp (7)
- A src/ribbon/art_msw_flat.cpp (1178)
- M src/ribbon/descrip.mms (5)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26253.patch
- https://github.com/wxWidgets/wxWidgets/pull/26253.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden pushed 1 commit.
- fa41715 Remove implementation leakage
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
Blake-Madden left a comment (wxWidgets/wxWidgets#26253)I'm not wild about the hard coded numbers throughout all three art providers, but that will be a separate battle for another day...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz approved this pull request.
Thanks, I don't use ribbon myself but I guess it's a nice possibility for those who do, so I'll merge this soon.
> @@ -1948,7 +1951,7 @@ void wxRibbonMSWArtProvider::DrawPanelBackground(
{
// Room for some characters and ...
// Display as many characters as possible and append ...
- for(size_t len = label.Len() - 1; len >= 3; --len)
+ for( int len = static_cast<int>(label.Len()) - 1; len >= 3; --len )
Not sure why this had to be changed, but as long as it did, I'll at least use wxSsize() here instead of the cast.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.