Ensure windows are destroyed before wxApp::OnExit() is called (PR #26189)

13 views
Skip to first unread message

VZ

unread,
Feb 13, 2026, 5:20:16 PMFeb 13
to wx-...@googlegroups.com, Subscribed

In some circumstances we could call wxApp::OnExit() before destroying the application windows, which violated the documented (and reasonably expected) behaviour.

Fix this by adding a wrapper CallOnExit() function which destroys all windows before calling OnExit() and, for good measure, then does it again in case the user-overridden version of this function created more windows when it was called.

This also has a nice side effect of freeing the user code from the need to call the base OnExit(), as it is now trivial and doesn't do anything any more.

Closes #26172.


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/26189

Commit Summary

  • d4c171a Ensure windows are destroyed before wxApp::OnExit() is called

File Changes

(6 files)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26189@github.com>

VZ

unread,
Feb 13, 2026, 5:32:20 PMFeb 13
to wx-...@googlegroups.com, Push

@vadz pushed 1 commit.

  • b659543 Ensure windows are destroyed before wxApp::OnExit() is called


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26189/before/d4c171a70f709b6ad8f1cfe42ab348e2cd908d0b/after/b65954382e511ab19619b7a77c1f9bbda69e731d@github.com>

VZ

unread,
Feb 13, 2026, 6:01:58 PMFeb 13
to wx-...@googlegroups.com, Push

@vadz pushed 1 commit.

  • ef6aa98 Ensure windows are destroyed before wxApp::OnExit() is called


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26189/before/b65954382e511ab19619b7a77c1f9bbda69e731d/after/ef6aa98596bcd713b273ddd57849a16e06b48f1b@github.com>

VZ

unread,
Feb 14, 2026, 5:51:33 PMFeb 14
to wx-...@googlegroups.com, Subscribed

Closed #26189.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26189/issue_event/22796281537@github.com>

VZ

unread,
Feb 14, 2026, 5:51:33 PMFeb 14
to wx-...@googlegroups.com, Subscribed
vadz left a comment (wxWidgets/wxWidgets#26189)

Cherry picked in the commit referenced above.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26189/c3902731697@github.com>

Reply all
Reply to author
Forward
0 new messages