Make `wxGetLinuxDistributionInfo()` available on all Unices (PR #26227)
Lauri Nurmi
Now that wxGetLinuxDistributionInfo() primarily obtains its data from /etc/os-release, there is nothing fundamentally Linux-specific about the implementation.
FreeBSD comes with /etc/os-release since FreeBSD 13.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26227
Commit Summary
- 9718622 Make wxGetLinuxDistributionInfo() available on all Unices
File Changes
(5 files)
- M include/wx/utils.h (2)
- M interface/wx/platinfo.h (3)
- M interface/wx/utils.h (7)
- M src/common/platinfo.cpp (2)
- M src/unix/utilsunx.cpp (4)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26227.patch
- https://github.com/wxWidgets/wxWidgets/pull/26227.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz requested changes on this pull request.
Sorry, I don't understand how can you say that there is nothing Linux-specific about this function when it has "Linux" in its name (and also in the name of the struct returned by it).
If it makes sense to extend this to other Unix systems, we need to rename both the function and the struct (keeping the old names for compatibility, of course), otherwise this would be very confusing.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26227)Is this replaced by #26231?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Lauri Nurmi
lanurmi left a comment (wxWidgets/wxWidgets#26227)Is this replaced by #26231?
No, these two are unrelated.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.