Change wxSVGFileDC to create unique clip/gradient IDs across multiple outputs (PR #26366)
Blake-Madden
Instead of resetting IDs to zero with every wxSVGFileDC construction, have it remember the IDs that were already used.
This is useful if you need to combine multiple output SVGs. In my situation, I am ouputting many SVGs from different graph renderings, extracting the body from them, and then combining them into a larger SVG report. (Perhaps this is a use case for others as well.) With the current behaviour, the IDs for my clip rects are not always unique, which then causes rendering failures. This PR fixes this.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26366
Commit Summary
- 7953d42 Change wxSVGFileDC to create unique clip/gradient IDs across multiple outputs
File Changes
(2 files)
- M include/wx/dcsvg.h (4)
- M src/common/dcsvg.cpp (6)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26366.patch
- https://github.com/wxWidgets/wxWidgets/pull/26366.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26366)Thanks, will push soon.
BTW, one small thing: could you please use the blank line between the subject and the body in your commit messages, as it should be done (see the classic guidelines)? Otherwise I always have to edit them before pushing. TIA!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.