Add & fix SVG Graphics Context unit tests (PR #26504)
Blake-Madden
Basically, a total overhaul of the wxSVGFileDC unit tests. I was getting failing tests with test_drawing and the image test case would only work on Windows. I did a rewrite from CppUnit to Catch2 and removed the external file dependencies. I also removed the "plugin" test interface in here. It seems to have never been used and is orphaned in numerous places. I removed it from here; let me know if you want me to remove the remaining traces of this.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26504
Commit Summary
- 9eff7ff Overhaul SVG unit tests
- 14e502d Fix missing shape-rendering attribute in SVG graphics groups
File Changes
(5 files)
- M src/common/dcsvg.cpp (4)
- M tests/drawing/basictest.cpp (17)
- M tests/drawing/drawing.cpp (523)
- M tests/drawing/drawing.h (174)
- M tests/drawing/fonttest.cpp (31)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26504.patch
- https://github.com/wxWidgets/wxWidgets/pull/26504.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden pushed 1 commit.
- a41df2c Fix CppUnit shim
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26504)Just checking: was this closed intentionally?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Blake-Madden
Blake-Madden left a comment (wxWidgets/wxWidgets#26504)Yes, I was getting a bunch of warnings as errors from CppUnit in other files in some of the build configurations here. No idea why though, was coming from files I hadn't touched. Catch2'ifying the test_drawing target broke something somehow, so I'll either have to rethink this (or finish removing CppUnit from everyone else first).
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26504)Looking at the first failing build, the errors are due to wxBrush being incomplete, almost certainly due to the fact that wx/brush.h was indirectly included before but needs to be explicitly included now.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Blake-Madden
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden pushed 2 commits.
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden pushed 1 commit.
- e5f5a40 Add another missing include
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden pushed 1 commit.
- 45b5420 Delete orphaned plugin unit testing feature
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26504)I'm not sure about the "plugin" tests but I'd definitely prefer to remove it one independent commit before making the SVG-related changes. Could you do it like this please?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Blake-Madden
Blake-Madden left a comment (wxWidgets/wxWidgets#26504)I'm not sure about the "plugin" tests but I'd definitely prefer to remove it one independent commit before making the SVG-related changes. Could you do it like this please?
See #26568
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.