Improve expander in wxPropertyGrid (PR #25579)
Maarten
- Make wxPropertyGrid a wxSystemThemedControl so it uses the default expander
- Don't use hard-coded expander sizes in wxPropertyGrid so the expander gets the correct size, fixes #25571
- Improve margin of sub-groups in wxPropertyGrid so the expander does not overlap with the margin
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/25579
Commit Summary
- d0ed9ee Make wxPropertyGrid a wxSystemThemedControl
- 7c667d4 Don't use hard-coded expander sizes in wxPropertyGrid
- 3281b72 Improve margin of sub-groups in wxPropertyGrid
File Changes
(2 files)
- M include/wx/propgrid/propgrid.h (3)
- M src/propgrid/propgrid.cpp (50)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/25579.patch
- https://github.com/wxWidgets/wxWidgets/pull/25579.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
@MaartenBent pushed 1 commit.
- 5bdd02a fixup
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#25579)I haven't tested if this looks correctly on linux/macOS.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25579)Unfortunately this doesn't look great under Linux (wxGTK, 200% DPI): this is how it looks in master:
and this is how it looks with this PR:
The arrows are clearly scaled, but now they also have too big margins around them. Can this be easily fixed (I didn't look at the code at all to be honest)?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#25579)The arrows are clearly scaled, but now they also have too big margins around them. Can this be easily fixed (I didn't look at the code at all to be honest)?
It now uses the image width (16dip px I guess), and left and right of the image a 'gutter' of max(3, imagewidth/3). Previously it was a fix image with of 9 px.
Maybe the gutter size can be reduced. I'll try some things.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25579)Sorry, this is not urgent at all but I wanted to ask if you still plan to try something here or should I find some way to reduce the margins myself?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
@MaartenBent pushed 4 commits.
- 1e4b962 Make wxPropertyGrid a wxSystemThemedControl
- 942fcf8 Don't use hard-coded expander sizes in wxPropertyGrid
- bbcd97d Improve margin of sub-groups in wxPropertyGrid
- 9b6b49e Reduce wxPropertyGrid gutter width
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#25579)I committed a fix. Seems the gutter is mostly useless now after using the real size of the expander icons.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25579)Great, thanks a lot! Will merge soon.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Merged #25579 into master.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.