[wxWidgets/wxWidgets] df2298: Reject short reads in wxIPCSocketStreams::ReadData()
0 views
Skip to first unread message
VZ
Jun 27, 2026, 1:58:45 PM (2 days ago) Jun 27
to wx-co...@googlegroups.com
Branch: refs/heads/master
Home: https://github.com/wxWidgets/wxWidgets
Commit: df22982e6e0969ff0a623fd9f12da1e1ac8d4950
https://github.com/wxWidgets/wxWidgets/commit/df22982e6e0969ff0a623fd9f12da1e1ac8d4950
Author: dxbjavid <dxbj...@gmail.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/common/sckipc.cpp
Log Message:
-----------
Reject short reads in wxIPCSocketStreams::ReadData()
wxIPCSocketStreams::ReadData() reads a length prefix from the connection
and then reads that many bytes into the buffer returned by
GetBufferAtLeast, but it never checks how many bytes actually arrived.
That buffer is either freshly allocated and so uninitialised or, more
commonly, the connection's own buffer reused from an earlier and
possibly larger message, so a peer that announces more data than it
sends and then drops the link leaves the unread tail untouched and it
gets handed to OnExecute/OnPoke/OnAdvise with the full announced size,
quietly leaking stale process memory across the connection. The socket
reads are done in WAITALL mode so a short read only happens when the
peer is broken or hostile, and every caller already treats a null return
from ReadData as an error, so the safe thing is to return nullptr when
fewer bytes than announced were read instead of using the partially
filled buffer.
Closes #26628.
Commit: 2209580741473cff07b3dccab30d67b46170a933
https://github.com/wxWidgets/wxWidgets/commit/2209580741473cff07b3dccab30d67b46170a933
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/common/sckipc.cpp
Log Message:
-----------
Refuse to read 0-sized data packets in wxIPCSocketStream
This doesn't make sense and must also indicate a problem with either the
connection or the peer.
See #26628.
Commit: 3d8aea230c0d06ab1dab23ba85280b3b296b0ee1
https://github.com/wxWidgets/wxWidgets/commit/3d8aea230c0d06ab1dab23ba85280b3b296b0ee1
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/common/sckipc.cpp
Log Message:
-----------
Add debug logging for unexpected input in wxIPCSocketStream
It could be useful to get more information in case of a problem, so log
unexpected situations.
Commit: b7f4cb4f743bc2ef7f2759fb6902df93f29c8752
https://github.com/wxWidgets/wxWidgets/commit/b7f4cb4f743bc2ef7f2759fb6902df93f29c8752
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M include/wx/ribbon/art.h
M include/wx/ribbon/bar.h
M src/ribbon/bar.cpp
Log Message:
-----------
Initialize wxRibbonBar members in their declarations
This ensures that they are always initialized, even when the default
ctor is used, which wasn't the case before for m_help_button_hovered
which was never set in this case, resulting in UBSAN errors when running
the ribbon sample.
Commit: 2071271018994b8181b907cb266570c0a43d1a90
https://github.com/wxWidgets/wxWidgets/commit/2071271018994b8181b907cb266570c0a43d1a90
Author: Blake-Madden <66873089+B...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/ribbon/art_msw.cpp
Log Message:
-----------
Fix appearance of wxRibbon in dark mode ribbon under Linux/KDE
Under KDE, the ribbon takes a blue hue because its system gray has a
blue tint in it that gets amplified here. This balances this to look
more like how dark mode is under macOS and MSW.
Closes #26627.
Commit: d6f5fdcf95e0fae19d9c65bdc7cdd7673dc1ca46
https://github.com/wxWidgets/wxWidgets/commit/d6f5fdcf95e0fae19d9c65bdc7cdd7673dc1ca46
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/msw/control.cpp
M src/msw/textctrl.cpp
M src/msw/window.cpp
Log Message:
-----------
Fix switching plain read-only multiline wxTextCtrl to dark mode
For dark mode switching, update the background colour for non-rich
read-only multiline wxTextCtrl controls. The foreground colour is
already updated.
The background colour is controlled by assigning m_backgroundColour
rather than calling SetBackgroundColour(). This leaves the m_hasBgCol
member untouched so that it distinguishes custom colours set by the user
which should not be overwritten, from colours set internally which can
be overwritten.
Some checks of hasBgCol are changed to m_backgroundColour.IsOK(). When
m_backgroundColour.IsOK() is true, there is either a custom colour or an
internally set colour that we need to use.
Closes #26629.
Commit: d2c579305c24451e95180ca6d6dec2945762fcc1
https://github.com/wxWidgets/wxWidgets/commit/d2c579305c24451e95180ca6d6dec2945762fcc1
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/generic/fontdlgg.cpp
Log Message:
-----------
Fix wxFontPreviewer appearance in dark mode
Add dark mode support to wxFontPreviewer:
- Replace manually drawn black-on-white border with window border
wxBORDER_SIMPLE.
- Set text colour to wxSYS_COLOUR_WINDOWTEXT.
Closes #26632.
Commit: f26f2536945d008f726d6537cd0fdd7d8e7a0636
https://github.com/wxWidgets/wxWidgets/commit/f26f2536945d008f726d6537cd0fdd7d8e7a0636
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M include/wx/generic/infobar.h
M src/generic/infobar.cpp
Log Message:
-----------
Handle system colour change in wxInfoBarGeneric
Move colour settings from Create() into a new function UpdateColours(),
which gets called from Create() and also upon system colour change.
Closes #26633.
Commit: ffeeb612cde55a89ef799277df676696405fe03a
https://github.com/wxWidgets/wxWidgets/commit/ffeeb612cde55a89ef799277df676696405fe03a
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/msw/darkmode.cpp
Log Message:
-----------
Remove not needed code for dark mode support under Windows 1809
Remove GetDwmSetWindowAttribute() call intended for Windows version
which we no longer support with dark mode.
Closes #26634.
Commit: a83d0b0af68bf2deed53eb7b8373a885f4a7c0f7
https://github.com/wxWidgets/wxWidgets/commit/a83d0b0af68bf2deed53eb7b8373a885f4a7c0f7
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/generic/vlbox.cpp
Log Message:
-----------
Fix system colour change for wxVListBox
Remove the background colour setting from wxVListBox::Create() so that
the control uses the up-to-date background colour in the paint event
handler. This way the control responds to system colour changes.
The comment about transparent drawing is wrong since 0975a8a (Applied
patch [ 1405821 ] wxVListBox double-buffering + fix to a scrolling issue
By Jaakko Salli, 2006-01-17).
Closes #26636.
Commit: 70e467e9ae7dbaa9605594f8107fc378aa5d807a
https://github.com/wxWidgets/wxWidgets/commit/70e467e9ae7dbaa9605594f8107fc378aa5d807a
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/propgrid/propgrid.cpp
Log Message:
-----------
Fix wxPropertyGrid dark mode switching
Add event.Skip() to wxPropertyGrid::OnSysColourChanged() so that upon
switching to or from dark mode, the scroll bar switches modes.
Closes #26637.
Commit: fc2755524f765293bc1ecffc2e857dfaf0857dd9
https://github.com/wxWidgets/wxWidgets/commit/fc2755524f765293bc1ecffc2e857dfaf0857dd9
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M include/wx/generic/sashwin.h
M src/generic/sashwin.cpp
Log Message:
-----------
Add system colour change handler to wxSashWindow
Closes #26638.
Commit: 5e4034bc30102c0734a70e52ef45224cd5133458
https://github.com/wxWidgets/wxWidgets/commit/5e4034bc30102c0734a70e52ef45224cd5133458
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/stc/stc.cpp
M src/stc/stc.cpp.in
Log Message:
-----------
Fix wxStyledTextCtrl dark mode switching
Add event.Skip() to wxStyledTextCtrl::OnSysColourChanged() so that upon
switching to or from dark mode, the scroll bar switches modes.
Closes #26639.
Commit: 7b2bc588e37ff42b5f973e3d86ac5e900802ac70
https://github.com/wxWidgets/wxWidgets/commit/7b2bc588e37ff42b5f973e3d86ac5e900802ac70
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M include/wx/stc/stc.h
M src/stc/gen_docs.py
M src/stc/stc.cpp
Log Message:
-----------
Really fix wxStyledTextCtrl::GetMarginCount() documentation
This was done manually in 9864777203 (Upgrade to Doxygen 1.15.0,
2026-05-05) but the changes were lost after regeneration, so add an
override for this function documentation to the generating script itself
to ensure that they're preserved.
This also has the nice side effect of generating a better comment in the
header.
See #26431.
Compare: https://github.com/wxWidgets/wxWidgets/compare/8262667a714d...7b2bc588e37f
To unsubscribe from these emails, change your notification settings at https://github.com/wxWidgets/wxWidgets/settings/notifications
Home: https://github.com/wxWidgets/wxWidgets
Commit: df22982e6e0969ff0a623fd9f12da1e1ac8d4950
https://github.com/wxWidgets/wxWidgets/commit/df22982e6e0969ff0a623fd9f12da1e1ac8d4950
Author: dxbjavid <dxbj...@gmail.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/common/sckipc.cpp
Log Message:
-----------
Reject short reads in wxIPCSocketStreams::ReadData()
wxIPCSocketStreams::ReadData() reads a length prefix from the connection
and then reads that many bytes into the buffer returned by
GetBufferAtLeast, but it never checks how many bytes actually arrived.
That buffer is either freshly allocated and so uninitialised or, more
commonly, the connection's own buffer reused from an earlier and
possibly larger message, so a peer that announces more data than it
sends and then drops the link leaves the unread tail untouched and it
gets handed to OnExecute/OnPoke/OnAdvise with the full announced size,
quietly leaking stale process memory across the connection. The socket
reads are done in WAITALL mode so a short read only happens when the
peer is broken or hostile, and every caller already treats a null return
from ReadData as an error, so the safe thing is to return nullptr when
fewer bytes than announced were read instead of using the partially
filled buffer.
Closes #26628.
Commit: 2209580741473cff07b3dccab30d67b46170a933
https://github.com/wxWidgets/wxWidgets/commit/2209580741473cff07b3dccab30d67b46170a933
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/common/sckipc.cpp
Log Message:
-----------
Refuse to read 0-sized data packets in wxIPCSocketStream
This doesn't make sense and must also indicate a problem with either the
connection or the peer.
See #26628.
Commit: 3d8aea230c0d06ab1dab23ba85280b3b296b0ee1
https://github.com/wxWidgets/wxWidgets/commit/3d8aea230c0d06ab1dab23ba85280b3b296b0ee1
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/common/sckipc.cpp
Log Message:
-----------
Add debug logging for unexpected input in wxIPCSocketStream
It could be useful to get more information in case of a problem, so log
unexpected situations.
Commit: b7f4cb4f743bc2ef7f2759fb6902df93f29c8752
https://github.com/wxWidgets/wxWidgets/commit/b7f4cb4f743bc2ef7f2759fb6902df93f29c8752
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M include/wx/ribbon/art.h
M include/wx/ribbon/bar.h
M src/ribbon/bar.cpp
Log Message:
-----------
Initialize wxRibbonBar members in their declarations
This ensures that they are always initialized, even when the default
ctor is used, which wasn't the case before for m_help_button_hovered
which was never set in this case, resulting in UBSAN errors when running
the ribbon sample.
Commit: 2071271018994b8181b907cb266570c0a43d1a90
https://github.com/wxWidgets/wxWidgets/commit/2071271018994b8181b907cb266570c0a43d1a90
Author: Blake-Madden <66873089+B...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/ribbon/art_msw.cpp
Log Message:
-----------
Fix appearance of wxRibbon in dark mode ribbon under Linux/KDE
Under KDE, the ribbon takes a blue hue because its system gray has a
blue tint in it that gets amplified here. This balances this to look
more like how dark mode is under macOS and MSW.
Closes #26627.
Commit: d6f5fdcf95e0fae19d9c65bdc7cdd7673dc1ca46
https://github.com/wxWidgets/wxWidgets/commit/d6f5fdcf95e0fae19d9c65bdc7cdd7673dc1ca46
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/msw/control.cpp
M src/msw/textctrl.cpp
M src/msw/window.cpp
Log Message:
-----------
Fix switching plain read-only multiline wxTextCtrl to dark mode
For dark mode switching, update the background colour for non-rich
read-only multiline wxTextCtrl controls. The foreground colour is
already updated.
The background colour is controlled by assigning m_backgroundColour
rather than calling SetBackgroundColour(). This leaves the m_hasBgCol
member untouched so that it distinguishes custom colours set by the user
which should not be overwritten, from colours set internally which can
be overwritten.
Some checks of hasBgCol are changed to m_backgroundColour.IsOK(). When
m_backgroundColour.IsOK() is true, there is either a custom colour or an
internally set colour that we need to use.
Closes #26629.
Commit: d2c579305c24451e95180ca6d6dec2945762fcc1
https://github.com/wxWidgets/wxWidgets/commit/d2c579305c24451e95180ca6d6dec2945762fcc1
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/generic/fontdlgg.cpp
Log Message:
-----------
Fix wxFontPreviewer appearance in dark mode
Add dark mode support to wxFontPreviewer:
- Replace manually drawn black-on-white border with window border
wxBORDER_SIMPLE.
- Set text colour to wxSYS_COLOUR_WINDOWTEXT.
Closes #26632.
Commit: f26f2536945d008f726d6537cd0fdd7d8e7a0636
https://github.com/wxWidgets/wxWidgets/commit/f26f2536945d008f726d6537cd0fdd7d8e7a0636
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M include/wx/generic/infobar.h
M src/generic/infobar.cpp
Log Message:
-----------
Handle system colour change in wxInfoBarGeneric
Move colour settings from Create() into a new function UpdateColours(),
which gets called from Create() and also upon system colour change.
Closes #26633.
Commit: ffeeb612cde55a89ef799277df676696405fe03a
https://github.com/wxWidgets/wxWidgets/commit/ffeeb612cde55a89ef799277df676696405fe03a
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/msw/darkmode.cpp
Log Message:
-----------
Remove not needed code for dark mode support under Windows 1809
Remove GetDwmSetWindowAttribute() call intended for Windows version
which we no longer support with dark mode.
Closes #26634.
Commit: a83d0b0af68bf2deed53eb7b8373a885f4a7c0f7
https://github.com/wxWidgets/wxWidgets/commit/a83d0b0af68bf2deed53eb7b8373a885f4a7c0f7
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/generic/vlbox.cpp
Log Message:
-----------
Fix system colour change for wxVListBox
Remove the background colour setting from wxVListBox::Create() so that
the control uses the up-to-date background colour in the paint event
handler. This way the control responds to system colour changes.
The comment about transparent drawing is wrong since 0975a8a (Applied
patch [ 1405821 ] wxVListBox double-buffering + fix to a scrolling issue
By Jaakko Salli, 2006-01-17).
Closes #26636.
Commit: 70e467e9ae7dbaa9605594f8107fc378aa5d807a
https://github.com/wxWidgets/wxWidgets/commit/70e467e9ae7dbaa9605594f8107fc378aa5d807a
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/propgrid/propgrid.cpp
Log Message:
-----------
Fix wxPropertyGrid dark mode switching
Add event.Skip() to wxPropertyGrid::OnSysColourChanged() so that upon
switching to or from dark mode, the scroll bar switches modes.
Closes #26637.
Commit: fc2755524f765293bc1ecffc2e857dfaf0857dd9
https://github.com/wxWidgets/wxWidgets/commit/fc2755524f765293bc1ecffc2e857dfaf0857dd9
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M include/wx/generic/sashwin.h
M src/generic/sashwin.cpp
Log Message:
-----------
Add system colour change handler to wxSashWindow
Closes #26638.
Commit: 5e4034bc30102c0734a70e52ef45224cd5133458
https://github.com/wxWidgets/wxWidgets/commit/5e4034bc30102c0734a70e52ef45224cd5133458
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M src/stc/stc.cpp
M src/stc/stc.cpp.in
Log Message:
-----------
Fix wxStyledTextCtrl dark mode switching
Add event.Skip() to wxStyledTextCtrl::OnSysColourChanged() so that upon
switching to or from dark mode, the scroll bar switches modes.
Closes #26639.
Commit: 7b2bc588e37ff42b5f973e3d86ac5e900802ac70
https://github.com/wxWidgets/wxWidgets/commit/7b2bc588e37ff42b5f973e3d86ac5e900802ac70
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-27 (Sat, 27 Jun 2026)
Changed paths:
M include/wx/stc/stc.h
M src/stc/gen_docs.py
M src/stc/stc.cpp
Log Message:
-----------
Really fix wxStyledTextCtrl::GetMarginCount() documentation
This was done manually in 9864777203 (Upgrade to Doxygen 1.15.0,
2026-05-05) but the changes were lost after regeneration, so add an
override for this function documentation to the generating script itself
to ensure that they're preserved.
This also has the nice side effect of generating a better comment in the
header.
See #26431.
Compare: https://github.com/wxWidgets/wxWidgets/compare/8262667a714d...7b2bc588e37f
To unsubscribe from these emails, change your notification settings at https://github.com/wxWidgets/wxWidgets/settings/notifications
Reply all
Reply to author
Forward
0 new messages