[wxWidgets/wxWidgets] 4d0e15: Fix marking wrong item as being deleted in wxOSX w...

0 views
Skip to first unread message

VZ

unread,
Feb 5, 2026, 8:58:08 PMFeb 5
to wx-co...@googlegroups.com
Branch: refs/heads/3.2
Home: https://github.com/wxWidgets/wxWidgets
Commit: 4d0e15d8d2db014315eb1057472178ee38517a5b
https://github.com/wxWidgets/wxWidgets/commit/4d0e15d8d2db014315eb1057472178ee38517a5b
Author: Hartwig Wiesmann <hartwig....@skywind.eu>
Date: 2026-02-04 (Wed, 04 Feb 2026)

Changed paths:
M docs/changes.txt
M src/osx/dataview_osx.cpp

Log Message:
-----------
Fix marking wrong item as being deleted in wxOSX wxDataViewCtrl

The comment in wxDataViewCtrl::IsClearing() said that the item being
deleted should be invalid only when the entire model is being cleared,
but this wasn't the case in ItemDeleted() as its "parent" argument could
be invalid (e.g. when using a flat list model) even if "item" itself is
valid.

Use "item", not "parent", to set the item being deleted to the correct
value to fix this.

See #26138, #26139.

(cherry picked from commit 6950c3218e4d6212f9584b124973139502cdd05b)


Commit: cf16a891381887c4241f0e917252d807e61c90c6
https://github.com/wxWidgets/wxWidgets/commit/cf16a891381887c4241f0e917252d807e61c90c6
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-04 (Wed, 04 Feb 2026)

Changed paths:
M src/osx/dataview_osx.cpp

Log Message:
-----------
Rename wxOSXDVCDeleting::m_parent to m_item

No real changes, just don't use "parent" for the name of the item being
deleted, this is confusing as it's really the item itself and not its
parent.

See #26139.

(cherry picked from commit 4bb297d962b1d23345e3b45de8006d7a015e34ea)


Commit: 81ebf59adb006327e6ccb4ab01079af5127a16d7
https://github.com/wxWidgets/wxWidgets/commit/81ebf59adb006327e6ccb4ab01079af5127a16d7
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-04 (Wed, 04 Feb 2026)

Changed paths:
M interface/wx/stockitem.h

Log Message:
-----------
Document wxGetStockHelpString() function

It was added back in 345319d60c (fixes to menu stock items support
(patch 1547639), 2006-09-05) and even if it's not particularly useful,
it still should be documented, so add documentation for it.

See #8090.

(cherry picked from commit e80d78c2c96a4986c32a33f83d0118c2397836fb)


Commit: 14c2b46bb0388d0be551d2af9a9b716b6996b6eb
https://github.com/wxWidgets/wxWidgets/commit/14c2b46bb0388d0be551d2af9a9b716b6996b6eb
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-04 (Wed, 04 Feb 2026)

Changed paths:
M interface/wx/defs.h

Log Message:
-----------
Minor corrections to standard IDs documentation

Remove misleading Doxygen comments copied from the comments in C++
header which didn't make sense here.

Improve the documentation of menu ID ranges.

(cherry picked from commit 5a95c14a39e13cd3fe713a278efe957b5ab13ac5)


Commit: 0910d8fa341988747135444093c86dad576f4ad4
https://github.com/wxWidgets/wxWidgets/commit/0910d8fa341988747135444093c86dad576f4ad4
Author: Stefan Csomor <cso...@advancedconcepts.ch>
Date: 2026-02-06 (Fri, 06 Feb 2026)

Changed paths:
M docs/changes.txt
M src/osx/cocoa/dataview.mm

Log Message:
-----------
Fix crash on key press in wxDataViewCtrl in wxOSX

Don't access out of bounds NSString characters when processing key
events, as this results in an exception and crash under current macOS
versions.

See #26160, #26161.

(cherry picked from commit fe038044c4f1a05717a0bdc440359fb315b5f61f)


Commit: dd7a3da51d3a2c7a275c6d0462676a29cf92451b
https://github.com/wxWidgets/wxWidgets/commit/dd7a3da51d3a2c7a275c6d0462676a29cf92451b
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-06 (Fri, 06 Feb 2026)

Changed paths:
M docs/changes.txt
M src/osx/cocoa/filedlg.mm

Log Message:
-----------
Fix using invalid filter index in wxOSX wxFileDialog

Ensure we use the valid index in m_filterExtensions when
m_firstFileTypeFilter was set to -1.

This is the equivalent of 17dbee8a46 (Fix using invalid filter index in
wxOSX wxFileDialog, 2026-02-04) from master, but applied to both copies
of the code present in this branch.

See #26148.


Compare: https://github.com/wxWidgets/wxWidgets/compare/c5dddf5ee283...dd7a3da51d3a

To unsubscribe from these emails, change your notification settings at https://github.com/wxWidgets/wxWidgets/settings/notifications
Reply all
Reply to author
Forward
0 new messages