[wxWidgets/wxWidgets] 92254c: Factor out wxIsSystemColourChange() helper function
0 views
Skip to first unread message
Javid Khan
Jun 13, 2026, 2:46:47 PM (2 days ago) Jun 13
to wx-co...@googlegroups.com
Branch: refs/heads/master
Home: https://github.com/wxWidgets/wxWidgets
Commit: 92254ce2db8facb284c2e898599b97f64ecfa8e9
https://github.com/wxWidgets/wxWidgets/commit/92254ce2db8facb284c2e898599b97f64ecfa8e9
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M include/wx/msw/private.h
M src/msw/window.cpp
Log Message:
-----------
Factor out wxIsSystemColourChange() helper function
Check whether the LPARAM of WM_SETTINGCHANGE is "ImmersiveColorSet".
No real changes yet, just make it possible to reuse this in the upcoming
commits.
Commit: 8e2ac384626ffbc7521b965d6afc4aaadddc8ea0
https://github.com/wxWidgets/wxWidgets/commit/8e2ac384626ffbc7521b965d6afc4aaadddc8ea0
Author: Mohmed abdel-fattah <memo...@gmail.com>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M Makefile.in
M build/bakefiles/files.bkl
M build/cmake/files.cmake
M build/files
M build/msw/makefile.gcc
M build/msw/makefile.vc
M build/msw/wx_core.vcxproj
M build/msw/wx_core.vcxproj.filters
A include/wx/msw/private/taskdlg.h
M src/msw/msgdlg.cpp
M src/msw/progdlg.cpp
A src/msw/taskdlg.cpp
Log Message:
-----------
Add dark mode support for task dialog-based dialogs
Show wxMessageDialog and wxProgressDialog using appropriate colours when
dark mode is active.
Closes #26240.
Closes #26311.
Commit: 2ebde404ab0acc1f2c079c9c09b7d0795eb705c9
https://github.com/wxWidgets/wxWidgets/commit/2ebde404ab0acc1f2c079c9c09b7d0795eb705c9
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/msgdlg.cpp
M src/msw/progdlg.cpp
Log Message:
-----------
Remove WM_SETTINGCHANGE handling from task dialog proc
Task dialog callback never gets this message, so this code is useless.
Commit: 091ba7a895687298cebdc1b5e6b2ca74b3d41c45
https://github.com/wxWidgets/wxWidgets/commit/091ba7a895687298cebdc1b5e6b2ca74b3d41c45
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Remove unnecessary member initialization in TDPageState ctor
Members are already initialized in their declarations.
Commit: 0dce46f5a1005c32aa7517f28b5c7259b452d0cd
https://github.com/wxWidgets/wxWidgets/commit/0dce46f5a1005c32aa7517f28b5c7259b452d0cd
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Use AutoHBRUSH instead of manually allocating/deleting HBRUSHes
This allows to remove DestroyBrushes() and Destroy() itself as it was
only called before destroying TDPageState object and the brushes are now
deleted by the dtor.
Also allocate the brushes immediately when creating this object, they
will be always used and so it doesn't seem worth it to postpone doing
this.
Commit: 12eed00ef7a4d811e032279e270917ba14444fbf
https://github.com/wxWidgets/wxWidgets/commit/12eed00ef7a4d811e032279e270917ba14444fbf
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Make IUIAutomation pointer a local variable
There is no need to make it a global.
Also reformat the code a bit.
Commit: 80485247015a90cee578275a74ae624de307e4a5
https://github.com/wxWidgets/wxWidgets/commit/80485247015a90cee578275a74ae624de307e4a5
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Return TRUE, not 1, when handling WM_ERASEBKGND
No real changes, just use the usual convention.
Commit: 3ed49f0187fea033ef0a8582cfd54bc9d3752f16
https://github.com/wxWidgets/wxWidgets/commit/3ed49f0187fea033ef0a8582cfd54bc9d3752f16
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Use safer wxIID_PPV_ARGS() instead of cast to "void**"
The macro ensures that the pointer is of the correct type.
Commit: 739cefeb276af872562ad2d655062c09e914bde6
https://github.com/wxWidgets/wxWidgets/commit/739cefeb276af872562ad2d655062c09e914bde6
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Localize GET_[BGR] macros
Ideal would be to replace them with wxColour functions but for now at
least make their scope as small as possible.
Commit: e1ca1dd77f232d7677310d23bcf481f364b5bad9
https://github.com/wxWidgets/wxWidgets/commit/e1ca1dd77f232d7677310d23bcf481f364b5bad9
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Use wxColour and wxUxThemeHandle instead of raw Windows API
Also don't try to get TDLG_SECONDARYPANEL and TDLG_FOOTNOTESEPARATOR
from the "TaskDialog" theme under Windows 10 as it doesn't define them.
No real changes.
Commit: 8b2b9069b31a1b5da1d1fc281bcde22050a6cd8d
https://github.com/wxWidgets/wxWidgets/commit/8b2b9069b31a1b5da1d1fc281bcde22050a6cd8d
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Don't define CLSID_CUIAutomation and IID_IUIAutomation ourselves
They should be already defined in the SDK headers.
Commit: fac69ca3f29f5a40c0a58898891b317de2f0d02d
https://github.com/wxWidgets/wxWidgets/commit/fac69ca3f29f5a40c0a58898891b317de2f0d02d
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M include/wx/msw/uxtheme.h
M src/msw/taskdlg.cpp
Log Message:
-----------
Add default ctor and move assignment to wxUxThemeHandle
Simplify the code in task dialog dark mode support by using the new
special member functions instead of ugly workarounds that were used
before.
Commit: 1c6d7e96dedef5c9afccb7fe8f5ddd0be527f487
https://github.com/wxWidgets/wxWidgets/commit/1c6d7e96dedef5c9afccb7fe8f5ddd0be527f487
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Don't use thread-local in task dialog dark mode support code
The global variables are only ever accessed from the GUI thread and
don't need to be thread-local.
Also add a wxModule to clean them up on exit.
Commit: a5979f400d0d553d5eac549d255b31fc145152ba
https://github.com/wxWidgets/wxWidgets/commit/a5979f400d0d553d5eac549d255b31fc145152ba
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Add helper GetHWNDFromElement(IUIAutomationElement) function
Hide ugly cast from UIA_HWND to HWND in a function and also add error
handling after IUIAutomationElement::get_CurrentNativeWindowHandle()
call.
Commit: db39a68c0832a30647497e1708e925039202c93a
https://github.com/wxWidgets/wxWidgets/commit/db39a68c0832a30647497e1708e925039202c93a
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Stop using wxBasicString unnecessarily
Just use wcscmp() to check BSTR contents directly.
Commit: e0a95d55e47df976c69cb3fa993ae8ea5eb5c58b
https://github.com/wxWidgets/wxWidgets/commit/e0a95d55e47df976c69cb3fa993ae8ea5eb5c58b
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Rename LPARAM parameter to standard "lParam" name
No real changes, just don't deviate from the usual convention
unnecessarily.
Commit: dede73a596d12f5e859830021fe15fd2afbd1f75
https://github.com/wxWidgets/wxWidgets/commit/dede73a596d12f5e859830021fe15fd2afbd1f75
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Don't store IUIAutomation in TDEnumData
This is unnecessary, as this pointer is stored in a global variable
already accessed directly from the other function, so just access it
from here as well.
Commit: bd03fbb6b873d79fe586ef67940c4c8f2c6897e9
https://github.com/wxWidgets/wxWidgets/commit/bd03fbb6b873d79fe586ef67940c4c8f2c6897e9
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Don't pass IUIAutomation as parameter to TDApplyToChildren()
Similar to the last comment, this IUIAutomation pointer is stored in a
global variable, so just access it directly for consistency.
Commit: 88b1cafa4b9f53a416df2bc0f11abe517d9aa23a
https://github.com/wxWidgets/wxWidgets/commit/88b1cafa4b9f53a416df2bc0f11abe517d9aa23a
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M include/wx/msw/private.h
M src/msw/taskdlg.cpp
M src/msw/window.cpp
Log Message:
-----------
Reuse GetWindowDPI() from task dialog dark mode code
Don't duplicate this function definition, make it internally public,
i.e. declare it, with "wx" prefix, in a private header and reuse it.
Commit: 026e93d23ad074f9fa6e85e72baaed235b738120
https://github.com/wxWidgets/wxWidgets/commit/026e93d23ad074f9fa6e85e72baaed235b738120
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M include/wx/msw/private/darkmode.h
M src/msw/darkmode.cpp
M src/msw/taskdlg.cpp
Log Message:
-----------
Check for error after calling ::SetWindowTheme()
Reuse the already existing code in darkmode.cpp by extracting it into
SetTheme() function and call it from task dialog dark mode code.
Also add a helper wxHasRealDarkTheme() function to make the code more
readable.
Commit: 6d45067a3c2de35a0decf8c723637120b6d4cb6c
https://github.com/wxWidgets/wxWidgets/commit/6d45067a3c2de35a0decf8c723637120b6d4cb6c
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Remove TDPageState::CloseThemes()
Calling this function to reset "themesOk" member variable was
inconsistent with resetting similar "elemsOk" directly, just remove the
function to make things simpler and more consistent.
Commit: 683d73528069008317dda0540e581df5b4769852
https://github.com/wxWidgets/wxWidgets/commit/683d73528069008317dda0540e581df5b4769852
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Remove TDPageState::hTDS which was same as hTD
The 2 themes handles were always identical, so remove one of them.
Commit: 39691558d34d99561f484d6d2d36fa74b4466385
https://github.com/wxWidgets/wxWidgets/commit/39691558d34d99561f484d6d2d36fa74b4466385
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Remove TDPageState::isDark
This wasn't used consistently, in many places TDHasNativeDarkTheme()
(which is used to initialize this member variable) was called directly,
so just stop storing its value in this variable and always call this
function, which is cheap as it caches the return value.
Commit: 23409e05b83962e55fa6df1d692f0a1401ba2f77
https://github.com/wxWidgets/wxWidgets/commit/23409e05b83962e55fa6df1d692f0a1401ba2f77
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Don't do anything in TDPaintGlyphs() when using native dark theme
This function effectively didn't do anything anyhow in this case, just
make it more clear and save some useless work by returning immediately.
Commit: 847561bdf67f50d9b4ff9ef8d41f6b4d43b19bb8
https://github.com/wxWidgets/wxWidgets/commit/847561bdf67f50d9b4ff9ef8d41f6b4d43b19bb8
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M include/wx/msw/uxtheme.h
M src/msw/taskdlg.cpp
M src/msw/uxtheme.cpp
Log Message:
-----------
Extend wxUxThemeHandle and use it more in dark task dialog code
Add HDC parameter to ::GetThemePartSize() wrappers and also add wrappers
for ::GetThemeMargins() and ::GetThemeFont().
The net effect is a small simplification of the task dialog code and
checking and logging of errors when calling these functions.
Commit: 3de0aec9a5005675ec38e9dd2c2f67f8d96f4bf2
https://github.com/wxWidgets/wxWidgets/commit/3de0aec9a5005675ec38e9dd2c2f67f8d96f4bf2
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M include/wx/msw/private.h
M src/msw/darkmode.cpp
M src/msw/datecontrols.cpp
M src/msw/joystick.cpp
M src/msw/renderer.cpp
M src/msw/taskdlg.cpp
M src/msw/toolbar.cpp
M src/msw/utils.cpp
Log Message:
-----------
Add WinStructWordSize<> helper and use it
This is similar to WinStruct<> but initializes dwSize and not cbSize
struct member.
In the future we should auto-detect the xxSize existence in WinStruct
using either SFINAE or, preferably, concepts, but for now keep things
simple.
Commit: 26bf503af88310c7c481f4e11085f90929c31e18
https://github.com/wxWidgets/wxWidgets/commit/26bf503af88310c7c481f4e11085f90929c31e18
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/statbox.cpp
Log Message:
-----------
Use recently added wxUxThemeHandle::GetFont()
No real changes, just simplify the code by using wx wrapper.
Commit: 5acd403f4fa2bec1ac2c6c0b2d87254c467a1d18
https://github.com/wxWidgets/wxWidgets/commit/5acd403f4fa2bec1ac2c6c0b2d87254c467a1d18
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Reformat task dialog dark mode support code
No real changes, a lot of formatting and indentation fixes and some
minor changes restructuring the code to be simpler and more readable.
This commit is best viewed ignoring whitespace-only changes.
Commit: 8ab0173ea3d86c9ebb0b565c00a623bfda1dd973
https://github.com/wxWidgets/wxWidgets/commit/8ab0173ea3d86c9ebb0b565c00a623bfda1dd973
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Add GetCurrentAutomationId() helper
Wrap calls to IUIAutomationElement::get_CurrentAutomationId().
Commit: b5baa3e60fd4ea36a6555e78633d1bd2dc82d6e3
https://github.com/wxWidgets/wxWidgets/commit/b5baa3e60fd4ea36a6555e78633d1bd2dc82d6e3
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Remove unnecessary "static" from functions in anonymous namespace
Use of "static" is unnecessary, these functions already have internal
linkage.
Commit: 361dbd9626d8b83ae0fb2823e7d9982fbe32d1ae
https://github.com/wxWidgets/wxWidgets/commit/361dbd9626d8b83ae0fb2823e7d9982fbe32d1ae
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Use wx-specific subclass IDs
Use the same prefix for all of our subclass IDs, this should hopefully
minimize the probability of a clash.
Commit: 272875a9c68751ff3deadc021074c9a46322f414
https://github.com/wxWidgets/wxWidgets/commit/272875a9c68751ff3deadc021074c9a46322f414
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Add wrappers around window subclassing functions
Simplify the code a bit more by avoiding calls to GetWindowSubclass()
and then SetWindowSubclass() or RemoveWindowSubclass() with redundant
parameters.
Commit: a2d7a75a1e447d20dc814f8512324e5681658ed2
https://github.com/wxWidgets/wxWidgets/commit/a2d7a75a1e447d20dc814f8512324e5681658ed2
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Fix HBRUSH leaks in task dialog dark mode code
For not totally clear reasons, the brushes allocated here were not
freed, resulting in the number of allocated brushes growing every time a
dialog was shown.
Use brushes from wxBrushList to prevent this from happening.
This doesn't fix all GDI leaks yet, there is still a USER handle and 3
GDI handlers leaked for every dialog shown, but they don't seem to be
brushes any more.
Commit: 1ec6163e9e8abbbc5a9ec0fd52bade08cd302ebc
https://github.com/wxWidgets/wxWidgets/commit/1ec6163e9e8abbbc5a9ec0fd52bade08cd302ebc
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Include wx/brush.h to fix the build when not using PCH
Commit: 37ff69e8d42968fe5185f651b9fc9c06e8e6b94c
https://github.com/wxWidgets/wxWidgets/commit/37ff69e8d42968fe5185f651b9fc9c06e8e6b94c
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Disable support for dark mode in task dialog for wxUniv
Native dialogs shouldn't be used anyhow when using wxUniv.
Commit: 97c1f3bbfb18fba8e534bc14a73e57653384a6da
https://github.com/wxWidgets/wxWidgets/commit/97c1f3bbfb18fba8e534bc14a73e57653384a6da
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Ignore unused parameters when dark mode support is disabled
Suppress harmless warnings.
Commit: 53d16f014433f2befbe789fb18d2c8f2e942bca6
https://github.com/wxWidgets/wxWidgets/commit/53d16f014433f2befbe789fb18d2c8f2e942bca6
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Fix HICON leak in task dialog dark mode support code
Destroy the icon returned by SHGetStockIconInfo().
Commit: af620105cf76f999a8086c53325d7d96364230c3
https://github.com/wxWidgets/wxWidgets/commit/af620105cf76f999a8086c53325d7d96364230c3
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M include/wx/msw/private/taskdlg.h
M src/msw/taskdlg.cpp
Log Message:
-----------
Add GitHub user name of Mohmed Abdel-Fattah to "Author" lines
See https://github.com/wxWidgets/wxWidgets/pull/26570#discussion_r3385217953
Commit: bbb3fc78bb1b79d20204fcebd61381831f06948b
https://github.com/wxWidgets/wxWidgets/commit/bbb3fc78bb1b79d20204fcebd61381831f06948b
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Keep a single real implementation of SetWindowSubclassIfNeeded()
Don't duplicate it for the special case of passing 0 as data, the
compiler should be able to optimize out the trivial lambda and doing it
like this reduces code duplication.
No real changes.
Commit: ec85de78d36d4cedd6d8f0b60fe9377aff64f416
https://github.com/wxWidgets/wxWidgets/commit/ec85de78d36d4cedd6d8f0b60fe9377aff64f416
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Fix problem with wrongly deleting the background brush
We shouldn't install HBRUSH owned by us as class background brush
because this brush is deleted by Windows itself, invalidating the HBRUSH
and resulting in visible problems when the background is painted using
this HBRUSH after showing a task dialog in dark mode.
Fix this by uninstalling the brush before deleting the window.
This also avoids the awkward code deleting the old class brush only if
it's not one of the standard brushes: now we don't need to do it any
longer, as we restore this brush before deleting the window.
Commit: 6132c1705977df7dc5ba43aba47cc1408e120285
https://github.com/wxWidgets/wxWidgets/commit/6132c1705977df7dc5ba43aba47cc1408e120285
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Add AutoBSTR helper to fix BSTR leaks in task dialog code
Also check that the returned BSTR is non-NULL before using it, as it can
be NULL even if the accessor returned S_OK.
Commit: aeef45946c5eb4f912b04ef0fae3bf54c7dc1919
https://github.com/wxWidgets/wxWidgets/commit/aeef45946c5eb4f912b04ef0fae3bf54c7dc1919
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Fix progress dialog background
Pass the dark brush to use in the dialog subclass proc and do not set
the class background brush to avoid it being freed.
Commit: afe8b984a5059c7da2d265c5506607173104786f
https://github.com/wxWidgets/wxWidgets/commit/afe8b984a5059c7da2d265c5506607173104786f
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Simplify check for null element class
Return early in this case to ensure that the pointer can be used without
any checks in the code below.
No real changes.
Commit: 357265c281166a0e1b5c56de255a64581fb73822
https://github.com/wxWidgets/wxWidgets/commit/357265c281166a0e1b5c56de255a64581fb73822
Author: Mohmed abdel-fattah <memo...@gmail.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Apply dark theme to the task dialog scrollbars
They may be shown after expanding the "Details" section if the contents
is big enough and didn't adapt to the dark theme without this change.
Commit: 458549bd18b5697e11939a04caebe81c4e1e1fc4
https://github.com/wxWidgets/wxWidgets/commit/458549bd18b5697e11939a04caebe81c4e1e1fc4
Author: Mohmed abdel-fattah <memo...@gmail.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Draw background of expanded footer area under Windows 11
Fix wrong background appearance under some (newest?) Windows 11 systems.
Commit: c3c3b70acad5a74e3a8537e3d39a3596cd12ab5e
https://github.com/wxWidgets/wxWidgets/commit/c3c3b70acad5a74e3a8537e3d39a3596cd12ab5e
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-12 (Fri, 12 Jun 2026)
Changed paths:
M interface/wx/app.h
Log Message:
-----------
Don't say that task dialogs don't support dark mode any more
This limitation is lifted by the changes in this branch.
Commit: 29e64673a6eaeaffbd2a722ceeaf9cc72d25d1aa
https://github.com/wxWidgets/wxWidgets/commit/29e64673a6eaeaffbd2a722ceeaf9cc72d25d1aa
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-12 (Fri, 12 Jun 2026)
Changed paths:
M src/msw/toolbar.cpp
Log Message:
-----------
Preserve wxToolBar custom background colour upon dark mode switch
Avoid overwriting wxToolBar custom colours upon switching into or out of
dark mode.
Closes #26581.
Commit: 5bedad68dd3f9855732c979ba050a53e209e2c44
https://github.com/wxWidgets/wxWidgets/commit/5bedad68dd3f9855732c979ba050a53e209e2c44
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-13 (Sat, 13 Jun 2026)
Changed paths:
M interface/wx/app.h
Log Message:
-----------
Remove note about wxToolBar::SetDropdownMenu() in dark mode
This remark is obsolete, the problem described by it was fixed by
c301af42f9 (Fix wxMSW toolbar drop down arrow appearance in dark mode,
2024-10-22).
Commit: 0e60afa604c590c77e971a9ef5101f1110544280
https://github.com/wxWidgets/wxWidgets/commit/0e60afa604c590c77e971a9ef5101f1110544280
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-13 (Sat, 13 Jun 2026)
Changed paths:
M include/wx/msw/listctrl.h
M src/msw/listctrl.cpp
Log Message:
-----------
Preserve wxListCtrl custom colours upon dark mode switch in wxMSW
Avoid overwriting custom colours upon switching into or out of dark
mode.
The text colour is now the same thing as the foreground colour, as with
wxGenericListCtrl.
Closes #26584.
Commit: fd35f189b6ab7af69400aec5db19acf51f3de24a
https://github.com/wxWidgets/wxWidgets/commit/fd35f189b6ab7af69400aec5db19acf51f3de24a
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-13 (Sat, 13 Jun 2026)
Changed paths:
M Makefile.in
M build/bakefiles/files.bkl
M build/cmake/files.cmake
M build/files
M build/msw/makefile.gcc
M build/msw/makefile.vc
M build/msw/wx_core.vcxproj
M build/msw/wx_core.vcxproj.filters
M include/wx/msw/private.h
M include/wx/msw/private/darkmode.h
A include/wx/msw/private/taskdlg.h
M include/wx/msw/uxtheme.h
M interface/wx/app.h
M src/msw/darkmode.cpp
M src/msw/datecontrols.cpp
M src/msw/joystick.cpp
M src/msw/msgdlg.cpp
M src/msw/progdlg.cpp
M src/msw/renderer.cpp
M src/msw/statbox.cpp
A src/msw/taskdlg.cpp
M src/msw/toolbar.cpp
M src/msw/utils.cpp
M src/msw/uxtheme.cpp
M src/msw/window.cpp
Log Message:
-----------
Merge branch 'msw-dark-taskdlg'
Add dark mode support to wxMSW task dialog-based dialogs.
See #26570.
Commit: 7ee01fa850fd674d46aa2a4e136a6dec5375c685
https://github.com/wxWidgets/wxWidgets/commit/7ee01fa850fd674d46aa2a4e136a6dec5375c685
Author: dxbjavid <dxbj...@gmail.com>
Date: 2026-06-13 (Sat, 13 Jun 2026)
Changed paths:
M src/common/gifdecod.cpp
M tests/image/image.cpp
Log Message:
-----------
Validate background colour index in wxGIFDecoder::LoadGIF()
Don't set background colour to uninitialized memory contents, just
ignore the invalid index.
Closes #26582.
Compare: https://github.com/wxWidgets/wxWidgets/compare/aef89c0e875d...7ee01fa850fd
To unsubscribe from these emails, change your notification settings at https://github.com/wxWidgets/wxWidgets/settings/notifications
Home: https://github.com/wxWidgets/wxWidgets
Commit: 92254ce2db8facb284c2e898599b97f64ecfa8e9
https://github.com/wxWidgets/wxWidgets/commit/92254ce2db8facb284c2e898599b97f64ecfa8e9
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M include/wx/msw/private.h
M src/msw/window.cpp
Log Message:
-----------
Factor out wxIsSystemColourChange() helper function
Check whether the LPARAM of WM_SETTINGCHANGE is "ImmersiveColorSet".
No real changes yet, just make it possible to reuse this in the upcoming
commits.
Commit: 8e2ac384626ffbc7521b965d6afc4aaadddc8ea0
https://github.com/wxWidgets/wxWidgets/commit/8e2ac384626ffbc7521b965d6afc4aaadddc8ea0
Author: Mohmed abdel-fattah <memo...@gmail.com>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M Makefile.in
M build/bakefiles/files.bkl
M build/cmake/files.cmake
M build/files
M build/msw/makefile.gcc
M build/msw/makefile.vc
M build/msw/wx_core.vcxproj
M build/msw/wx_core.vcxproj.filters
A include/wx/msw/private/taskdlg.h
M src/msw/msgdlg.cpp
M src/msw/progdlg.cpp
A src/msw/taskdlg.cpp
Log Message:
-----------
Add dark mode support for task dialog-based dialogs
Show wxMessageDialog and wxProgressDialog using appropriate colours when
dark mode is active.
Closes #26240.
Closes #26311.
Commit: 2ebde404ab0acc1f2c079c9c09b7d0795eb705c9
https://github.com/wxWidgets/wxWidgets/commit/2ebde404ab0acc1f2c079c9c09b7d0795eb705c9
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/msgdlg.cpp
M src/msw/progdlg.cpp
Log Message:
-----------
Remove WM_SETTINGCHANGE handling from task dialog proc
Task dialog callback never gets this message, so this code is useless.
Commit: 091ba7a895687298cebdc1b5e6b2ca74b3d41c45
https://github.com/wxWidgets/wxWidgets/commit/091ba7a895687298cebdc1b5e6b2ca74b3d41c45
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Remove unnecessary member initialization in TDPageState ctor
Members are already initialized in their declarations.
Commit: 0dce46f5a1005c32aa7517f28b5c7259b452d0cd
https://github.com/wxWidgets/wxWidgets/commit/0dce46f5a1005c32aa7517f28b5c7259b452d0cd
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Use AutoHBRUSH instead of manually allocating/deleting HBRUSHes
This allows to remove DestroyBrushes() and Destroy() itself as it was
only called before destroying TDPageState object and the brushes are now
deleted by the dtor.
Also allocate the brushes immediately when creating this object, they
will be always used and so it doesn't seem worth it to postpone doing
this.
Commit: 12eed00ef7a4d811e032279e270917ba14444fbf
https://github.com/wxWidgets/wxWidgets/commit/12eed00ef7a4d811e032279e270917ba14444fbf
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Make IUIAutomation pointer a local variable
There is no need to make it a global.
Also reformat the code a bit.
Commit: 80485247015a90cee578275a74ae624de307e4a5
https://github.com/wxWidgets/wxWidgets/commit/80485247015a90cee578275a74ae624de307e4a5
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Return TRUE, not 1, when handling WM_ERASEBKGND
No real changes, just use the usual convention.
Commit: 3ed49f0187fea033ef0a8582cfd54bc9d3752f16
https://github.com/wxWidgets/wxWidgets/commit/3ed49f0187fea033ef0a8582cfd54bc9d3752f16
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Use safer wxIID_PPV_ARGS() instead of cast to "void**"
The macro ensures that the pointer is of the correct type.
Commit: 739cefeb276af872562ad2d655062c09e914bde6
https://github.com/wxWidgets/wxWidgets/commit/739cefeb276af872562ad2d655062c09e914bde6
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Localize GET_[BGR] macros
Ideal would be to replace them with wxColour functions but for now at
least make their scope as small as possible.
Commit: e1ca1dd77f232d7677310d23bcf481f364b5bad9
https://github.com/wxWidgets/wxWidgets/commit/e1ca1dd77f232d7677310d23bcf481f364b5bad9
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Use wxColour and wxUxThemeHandle instead of raw Windows API
Also don't try to get TDLG_SECONDARYPANEL and TDLG_FOOTNOTESEPARATOR
from the "TaskDialog" theme under Windows 10 as it doesn't define them.
No real changes.
Commit: 8b2b9069b31a1b5da1d1fc281bcde22050a6cd8d
https://github.com/wxWidgets/wxWidgets/commit/8b2b9069b31a1b5da1d1fc281bcde22050a6cd8d
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Don't define CLSID_CUIAutomation and IID_IUIAutomation ourselves
They should be already defined in the SDK headers.
Commit: fac69ca3f29f5a40c0a58898891b317de2f0d02d
https://github.com/wxWidgets/wxWidgets/commit/fac69ca3f29f5a40c0a58898891b317de2f0d02d
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M include/wx/msw/uxtheme.h
M src/msw/taskdlg.cpp
Log Message:
-----------
Add default ctor and move assignment to wxUxThemeHandle
Simplify the code in task dialog dark mode support by using the new
special member functions instead of ugly workarounds that were used
before.
Commit: 1c6d7e96dedef5c9afccb7fe8f5ddd0be527f487
https://github.com/wxWidgets/wxWidgets/commit/1c6d7e96dedef5c9afccb7fe8f5ddd0be527f487
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Don't use thread-local in task dialog dark mode support code
The global variables are only ever accessed from the GUI thread and
don't need to be thread-local.
Also add a wxModule to clean them up on exit.
Commit: a5979f400d0d553d5eac549d255b31fc145152ba
https://github.com/wxWidgets/wxWidgets/commit/a5979f400d0d553d5eac549d255b31fc145152ba
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Add helper GetHWNDFromElement(IUIAutomationElement) function
Hide ugly cast from UIA_HWND to HWND in a function and also add error
handling after IUIAutomationElement::get_CurrentNativeWindowHandle()
call.
Commit: db39a68c0832a30647497e1708e925039202c93a
https://github.com/wxWidgets/wxWidgets/commit/db39a68c0832a30647497e1708e925039202c93a
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Stop using wxBasicString unnecessarily
Just use wcscmp() to check BSTR contents directly.
Commit: e0a95d55e47df976c69cb3fa993ae8ea5eb5c58b
https://github.com/wxWidgets/wxWidgets/commit/e0a95d55e47df976c69cb3fa993ae8ea5eb5c58b
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Rename LPARAM parameter to standard "lParam" name
No real changes, just don't deviate from the usual convention
unnecessarily.
Commit: dede73a596d12f5e859830021fe15fd2afbd1f75
https://github.com/wxWidgets/wxWidgets/commit/dede73a596d12f5e859830021fe15fd2afbd1f75
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Don't store IUIAutomation in TDEnumData
This is unnecessary, as this pointer is stored in a global variable
already accessed directly from the other function, so just access it
from here as well.
Commit: bd03fbb6b873d79fe586ef67940c4c8f2c6897e9
https://github.com/wxWidgets/wxWidgets/commit/bd03fbb6b873d79fe586ef67940c4c8f2c6897e9
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Don't pass IUIAutomation as parameter to TDApplyToChildren()
Similar to the last comment, this IUIAutomation pointer is stored in a
global variable, so just access it directly for consistency.
Commit: 88b1cafa4b9f53a416df2bc0f11abe517d9aa23a
https://github.com/wxWidgets/wxWidgets/commit/88b1cafa4b9f53a416df2bc0f11abe517d9aa23a
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
M include/wx/msw/private.h
M src/msw/taskdlg.cpp
M src/msw/window.cpp
Log Message:
-----------
Reuse GetWindowDPI() from task dialog dark mode code
Don't duplicate this function definition, make it internally public,
i.e. declare it, with "wx" prefix, in a private header and reuse it.
Commit: 026e93d23ad074f9fa6e85e72baaed235b738120
https://github.com/wxWidgets/wxWidgets/commit/026e93d23ad074f9fa6e85e72baaed235b738120
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M include/wx/msw/private/darkmode.h
M src/msw/darkmode.cpp
M src/msw/taskdlg.cpp
Log Message:
-----------
Check for error after calling ::SetWindowTheme()
Reuse the already existing code in darkmode.cpp by extracting it into
SetTheme() function and call it from task dialog dark mode code.
Also add a helper wxHasRealDarkTheme() function to make the code more
readable.
Commit: 6d45067a3c2de35a0decf8c723637120b6d4cb6c
https://github.com/wxWidgets/wxWidgets/commit/6d45067a3c2de35a0decf8c723637120b6d4cb6c
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Remove TDPageState::CloseThemes()
Calling this function to reset "themesOk" member variable was
inconsistent with resetting similar "elemsOk" directly, just remove the
function to make things simpler and more consistent.
Commit: 683d73528069008317dda0540e581df5b4769852
https://github.com/wxWidgets/wxWidgets/commit/683d73528069008317dda0540e581df5b4769852
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Remove TDPageState::hTDS which was same as hTD
The 2 themes handles were always identical, so remove one of them.
Commit: 39691558d34d99561f484d6d2d36fa74b4466385
https://github.com/wxWidgets/wxWidgets/commit/39691558d34d99561f484d6d2d36fa74b4466385
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Remove TDPageState::isDark
This wasn't used consistently, in many places TDHasNativeDarkTheme()
(which is used to initialize this member variable) was called directly,
so just stop storing its value in this variable and always call this
function, which is cheap as it caches the return value.
Commit: 23409e05b83962e55fa6df1d692f0a1401ba2f77
https://github.com/wxWidgets/wxWidgets/commit/23409e05b83962e55fa6df1d692f0a1401ba2f77
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Don't do anything in TDPaintGlyphs() when using native dark theme
This function effectively didn't do anything anyhow in this case, just
make it more clear and save some useless work by returning immediately.
Commit: 847561bdf67f50d9b4ff9ef8d41f6b4d43b19bb8
https://github.com/wxWidgets/wxWidgets/commit/847561bdf67f50d9b4ff9ef8d41f6b4d43b19bb8
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M include/wx/msw/uxtheme.h
M src/msw/taskdlg.cpp
M src/msw/uxtheme.cpp
Log Message:
-----------
Extend wxUxThemeHandle and use it more in dark task dialog code
Add HDC parameter to ::GetThemePartSize() wrappers and also add wrappers
for ::GetThemeMargins() and ::GetThemeFont().
The net effect is a small simplification of the task dialog code and
checking and logging of errors when calling these functions.
Commit: 3de0aec9a5005675ec38e9dd2c2f67f8d96f4bf2
https://github.com/wxWidgets/wxWidgets/commit/3de0aec9a5005675ec38e9dd2c2f67f8d96f4bf2
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M include/wx/msw/private.h
M src/msw/darkmode.cpp
M src/msw/datecontrols.cpp
M src/msw/joystick.cpp
M src/msw/renderer.cpp
M src/msw/taskdlg.cpp
M src/msw/toolbar.cpp
M src/msw/utils.cpp
Log Message:
-----------
Add WinStructWordSize<> helper and use it
This is similar to WinStruct<> but initializes dwSize and not cbSize
struct member.
In the future we should auto-detect the xxSize existence in WinStruct
using either SFINAE or, preferably, concepts, but for now keep things
simple.
Commit: 26bf503af88310c7c481f4e11085f90929c31e18
https://github.com/wxWidgets/wxWidgets/commit/26bf503af88310c7c481f4e11085f90929c31e18
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/statbox.cpp
Log Message:
-----------
Use recently added wxUxThemeHandle::GetFont()
No real changes, just simplify the code by using wx wrapper.
Commit: 5acd403f4fa2bec1ac2c6c0b2d87254c467a1d18
https://github.com/wxWidgets/wxWidgets/commit/5acd403f4fa2bec1ac2c6c0b2d87254c467a1d18
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Reformat task dialog dark mode support code
No real changes, a lot of formatting and indentation fixes and some
minor changes restructuring the code to be simpler and more readable.
This commit is best viewed ignoring whitespace-only changes.
Commit: 8ab0173ea3d86c9ebb0b565c00a623bfda1dd973
https://github.com/wxWidgets/wxWidgets/commit/8ab0173ea3d86c9ebb0b565c00a623bfda1dd973
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Add GetCurrentAutomationId() helper
Wrap calls to IUIAutomationElement::get_CurrentAutomationId().
Commit: b5baa3e60fd4ea36a6555e78633d1bd2dc82d6e3
https://github.com/wxWidgets/wxWidgets/commit/b5baa3e60fd4ea36a6555e78633d1bd2dc82d6e3
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Remove unnecessary "static" from functions in anonymous namespace
Use of "static" is unnecessary, these functions already have internal
linkage.
Commit: 361dbd9626d8b83ae0fb2823e7d9982fbe32d1ae
https://github.com/wxWidgets/wxWidgets/commit/361dbd9626d8b83ae0fb2823e7d9982fbe32d1ae
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Use wx-specific subclass IDs
Use the same prefix for all of our subclass IDs, this should hopefully
minimize the probability of a clash.
Commit: 272875a9c68751ff3deadc021074c9a46322f414
https://github.com/wxWidgets/wxWidgets/commit/272875a9c68751ff3deadc021074c9a46322f414
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Add wrappers around window subclassing functions
Simplify the code a bit more by avoiding calls to GetWindowSubclass()
and then SetWindowSubclass() or RemoveWindowSubclass() with redundant
parameters.
Commit: a2d7a75a1e447d20dc814f8512324e5681658ed2
https://github.com/wxWidgets/wxWidgets/commit/a2d7a75a1e447d20dc814f8512324e5681658ed2
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Fix HBRUSH leaks in task dialog dark mode code
For not totally clear reasons, the brushes allocated here were not
freed, resulting in the number of allocated brushes growing every time a
dialog was shown.
Use brushes from wxBrushList to prevent this from happening.
This doesn't fix all GDI leaks yet, there is still a USER handle and 3
GDI handlers leaked for every dialog shown, but they don't seem to be
brushes any more.
Commit: 1ec6163e9e8abbbc5a9ec0fd52bade08cd302ebc
https://github.com/wxWidgets/wxWidgets/commit/1ec6163e9e8abbbc5a9ec0fd52bade08cd302ebc
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Include wx/brush.h to fix the build when not using PCH
Commit: 37ff69e8d42968fe5185f651b9fc9c06e8e6b94c
https://github.com/wxWidgets/wxWidgets/commit/37ff69e8d42968fe5185f651b9fc9c06e8e6b94c
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Disable support for dark mode in task dialog for wxUniv
Native dialogs shouldn't be used anyhow when using wxUniv.
Commit: 97c1f3bbfb18fba8e534bc14a73e57653384a6da
https://github.com/wxWidgets/wxWidgets/commit/97c1f3bbfb18fba8e534bc14a73e57653384a6da
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Ignore unused parameters when dark mode support is disabled
Suppress harmless warnings.
Commit: 53d16f014433f2befbe789fb18d2c8f2e942bca6
https://github.com/wxWidgets/wxWidgets/commit/53d16f014433f2befbe789fb18d2c8f2e942bca6
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Fix HICON leak in task dialog dark mode support code
Destroy the icon returned by SHGetStockIconInfo().
Commit: af620105cf76f999a8086c53325d7d96364230c3
https://github.com/wxWidgets/wxWidgets/commit/af620105cf76f999a8086c53325d7d96364230c3
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M include/wx/msw/private/taskdlg.h
M src/msw/taskdlg.cpp
Log Message:
-----------
Add GitHub user name of Mohmed Abdel-Fattah to "Author" lines
See https://github.com/wxWidgets/wxWidgets/pull/26570#discussion_r3385217953
Commit: bbb3fc78bb1b79d20204fcebd61381831f06948b
https://github.com/wxWidgets/wxWidgets/commit/bbb3fc78bb1b79d20204fcebd61381831f06948b
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Keep a single real implementation of SetWindowSubclassIfNeeded()
Don't duplicate it for the special case of passing 0 as data, the
compiler should be able to optimize out the trivial lambda and doing it
like this reduces code duplication.
No real changes.
Commit: ec85de78d36d4cedd6d8f0b60fe9377aff64f416
https://github.com/wxWidgets/wxWidgets/commit/ec85de78d36d4cedd6d8f0b60fe9377aff64f416
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Fix problem with wrongly deleting the background brush
We shouldn't install HBRUSH owned by us as class background brush
because this brush is deleted by Windows itself, invalidating the HBRUSH
and resulting in visible problems when the background is painted using
this HBRUSH after showing a task dialog in dark mode.
Fix this by uninstalling the brush before deleting the window.
This also avoids the awkward code deleting the old class brush only if
it's not one of the standard brushes: now we don't need to do it any
longer, as we restore this brush before deleting the window.
Commit: 6132c1705977df7dc5ba43aba47cc1408e120285
https://github.com/wxWidgets/wxWidgets/commit/6132c1705977df7dc5ba43aba47cc1408e120285
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Add AutoBSTR helper to fix BSTR leaks in task dialog code
Also check that the returned BSTR is non-NULL before using it, as it can
be NULL even if the accessor returned S_OK.
Commit: aeef45946c5eb4f912b04ef0fae3bf54c7dc1919
https://github.com/wxWidgets/wxWidgets/commit/aeef45946c5eb4f912b04ef0fae3bf54c7dc1919
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Fix progress dialog background
Pass the dark brush to use in the dialog subclass proc and do not set
the class background brush to avoid it being freed.
Commit: afe8b984a5059c7da2d265c5506607173104786f
https://github.com/wxWidgets/wxWidgets/commit/afe8b984a5059c7da2d265c5506607173104786f
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Simplify check for null element class
Return early in this case to ensure that the pointer can be used without
any checks in the code below.
No real changes.
Commit: 357265c281166a0e1b5c56de255a64581fb73822
https://github.com/wxWidgets/wxWidgets/commit/357265c281166a0e1b5c56de255a64581fb73822
Author: Mohmed abdel-fattah <memo...@gmail.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Apply dark theme to the task dialog scrollbars
They may be shown after expanding the "Details" section if the contents
is big enough and didn't adapt to the dark theme without this change.
Commit: 458549bd18b5697e11939a04caebe81c4e1e1fc4
https://github.com/wxWidgets/wxWidgets/commit/458549bd18b5697e11939a04caebe81c4e1e1fc4
Author: Mohmed abdel-fattah <memo...@gmail.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M src/msw/taskdlg.cpp
Log Message:
-----------
Draw background of expanded footer area under Windows 11
Fix wrong background appearance under some (newest?) Windows 11 systems.
Commit: c3c3b70acad5a74e3a8537e3d39a3596cd12ab5e
https://github.com/wxWidgets/wxWidgets/commit/c3c3b70acad5a74e3a8537e3d39a3596cd12ab5e
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-12 (Fri, 12 Jun 2026)
Changed paths:
M interface/wx/app.h
Log Message:
-----------
Don't say that task dialogs don't support dark mode any more
This limitation is lifted by the changes in this branch.
Commit: 29e64673a6eaeaffbd2a722ceeaf9cc72d25d1aa
https://github.com/wxWidgets/wxWidgets/commit/29e64673a6eaeaffbd2a722ceeaf9cc72d25d1aa
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-12 (Fri, 12 Jun 2026)
Changed paths:
M src/msw/toolbar.cpp
Log Message:
-----------
Preserve wxToolBar custom background colour upon dark mode switch
Avoid overwriting wxToolBar custom colours upon switching into or out of
dark mode.
Closes #26581.
Commit: 5bedad68dd3f9855732c979ba050a53e209e2c44
https://github.com/wxWidgets/wxWidgets/commit/5bedad68dd3f9855732c979ba050a53e209e2c44
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-13 (Sat, 13 Jun 2026)
Changed paths:
M interface/wx/app.h
Log Message:
-----------
Remove note about wxToolBar::SetDropdownMenu() in dark mode
This remark is obsolete, the problem described by it was fixed by
c301af42f9 (Fix wxMSW toolbar drop down arrow appearance in dark mode,
2024-10-22).
Commit: 0e60afa604c590c77e971a9ef5101f1110544280
https://github.com/wxWidgets/wxWidgets/commit/0e60afa604c590c77e971a9ef5101f1110544280
Author: Steve Cornett <21205494...@users.noreply.github.com>
Date: 2026-06-13 (Sat, 13 Jun 2026)
Changed paths:
M include/wx/msw/listctrl.h
M src/msw/listctrl.cpp
Log Message:
-----------
Preserve wxListCtrl custom colours upon dark mode switch in wxMSW
Avoid overwriting custom colours upon switching into or out of dark
mode.
The text colour is now the same thing as the foreground colour, as with
wxGenericListCtrl.
Closes #26584.
Commit: fd35f189b6ab7af69400aec5db19acf51f3de24a
https://github.com/wxWidgets/wxWidgets/commit/fd35f189b6ab7af69400aec5db19acf51f3de24a
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-06-13 (Sat, 13 Jun 2026)
Changed paths:
M Makefile.in
M build/bakefiles/files.bkl
M build/cmake/files.cmake
M build/files
M build/msw/makefile.gcc
M build/msw/makefile.vc
M build/msw/wx_core.vcxproj
M build/msw/wx_core.vcxproj.filters
M include/wx/msw/private.h
M include/wx/msw/private/darkmode.h
A include/wx/msw/private/taskdlg.h
M include/wx/msw/uxtheme.h
M interface/wx/app.h
M src/msw/darkmode.cpp
M src/msw/datecontrols.cpp
M src/msw/joystick.cpp
M src/msw/msgdlg.cpp
M src/msw/progdlg.cpp
M src/msw/renderer.cpp
M src/msw/statbox.cpp
A src/msw/taskdlg.cpp
M src/msw/toolbar.cpp
M src/msw/utils.cpp
M src/msw/uxtheme.cpp
M src/msw/window.cpp
Log Message:
-----------
Merge branch 'msw-dark-taskdlg'
Add dark mode support to wxMSW task dialog-based dialogs.
See #26570.
Commit: 7ee01fa850fd674d46aa2a4e136a6dec5375c685
https://github.com/wxWidgets/wxWidgets/commit/7ee01fa850fd674d46aa2a4e136a6dec5375c685
Author: dxbjavid <dxbj...@gmail.com>
Date: 2026-06-13 (Sat, 13 Jun 2026)
Changed paths:
M src/common/gifdecod.cpp
M tests/image/image.cpp
Log Message:
-----------
Validate background colour index in wxGIFDecoder::LoadGIF()
Don't set background colour to uninitialized memory contents, just
ignore the invalid index.
Closes #26582.
Compare: https://github.com/wxWidgets/wxWidgets/compare/aef89c0e875d...7ee01fa850fd
To unsubscribe from these emails, change your notification settings at https://github.com/wxWidgets/wxWidgets/settings/notifications
Reply all
Reply to author
Forward
0 new messages