[wxWidgets/wxWidgets] 2a4318: Return true from wxProgressDialog::Show() on success
0 views
Skip to first unread message
VZ
Mar 17, 2026, 9:21:58 AMMar 17
to wx-co...@googlegroups.com
Branch: refs/heads/master
Home: https://github.com/wxWidgets/wxWidgets
Commit: 2a4318317318e42d41306dccc3a111f6a19f6ec5
https://github.com/wxWidgets/wxWidgets/commit/2a4318317318e42d41306dccc3a111f6a19f6ec5
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-03-15 (Sun, 15 Mar 2026)
Changed paths:
M src/msw/progdlg.cpp
Log Message:
-----------
Return true from wxProgressDialog::Show() on success
We accidentally returned false after successfully showing the native
dialog, which didn't make sense.
Commit: c76e4ff34197fe6fde1b00e7bc07c06c84963e0b
https://github.com/wxWidgets/wxWidgets/commit/c76e4ff34197fe6fde1b00e7bc07c06c84963e0b
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-03-15 (Sun, 15 Mar 2026)
Changed paths:
M src/msw/progdlg.cpp
Log Message:
-----------
Remove unnecessary explicit call to wxThread::Create()
Run() creates the thread if necessary, so there is no need to do it
here.
Commit: 505aa61481cd382f104e973728de0db00e21cfec
https://github.com/wxWidgets/wxWidgets/commit/505aa61481cd382f104e973728de0db00e21cfec
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-03-15 (Sun, 15 Mar 2026)
Changed paths:
M src/msw/progdlg.cpp
Log Message:
-----------
Remove untranslated error message never shown in practice
Messages shown by wxLogError() are user-visible and so need to be
translated, but it doesn't seem to be worth doing it for the message
about failing to start a thread which should be never given -- and if
the system is so low on resources that it can't create new threads,
showing this message would probably fail anyhow.
Just replace it with wxLogDebug().
Commit: 7506289955220ddd9daa43c51f8eaa028e7060df
https://github.com/wxWidgets/wxWidgets/commit/7506289955220ddd9daa43c51f8eaa028e7060df
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-03-15 (Sun, 15 Mar 2026)
Changed paths:
M include/wx/msw/progdlg.h
M src/msw/progdlg.cpp
Log Message:
-----------
Fall back to generic dialog if native wxProgressDialog fails
Even if this is not supposed to happen, fall back to the generic
progress dialog instead of just hanging if showing the native dialog
fails, for whatever reason.
This commit is best viewed with Git --color-moved option.
Commit: 82632d606f6d7a3c5e2815f1ed65e427f2e7911a
https://github.com/wxWidgets/wxWidgets/commit/82632d606f6d7a3c5e2815f1ed65e427f2e7911a
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-03-15 (Sun, 15 Mar 2026)
Changed paths:
M src/msw/progdlg.cpp
Log Message:
-----------
Fix showing wxProgressDialog with wxPD_CAN_SKIP style
This was broken by 02cff90601 (Change return type of wxGetTranslation,
2026-02-15) which resulted in passing invalid pointer to the already
destroyed temporary wxString "Skip" to the native dialog -- which
detected this and failed, resulting in a hang because our code didn't
handle its error correctly.
Error handling was improved in the preceding commits, but now fix the
real underlying bug by ensuring the string lives long enough.
Closes #26287.
Commit: f5ffe79071b1da2edd85fad69b22bc1c75753f11
https://github.com/wxWidgets/wxWidgets/commit/f5ffe79071b1da2edd85fad69b22bc1c75753f11
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-03-15 (Sun, 15 Mar 2026)
Changed paths:
M src/gtk/webview_webkit2.cpp
Log Message:
-----------
Fix crash when opening link in new window in wxWebViewWebKit
The parameters of "ready-to-show" signal handler were deleted, by the
handler itself, after a first call to it, but at least with the current
version of webkit2gtk (2.50.4) this handler can be called more than once
and it crashed when it happened.
Fix this by disconnecting it as soon as it is called, which fixes the
crash and doesn't seem to have any drawbacks.
Note that we might want to find a better way of passing these parameters
as currently they are leaked if the handler is not called at all, which
might happen under some unusual circumstances. But for now just fix the
crash.
Closes #26298.
Commit: 753b6bc9c4d28ff4b5ac3d2b567c1e22d7eb1dd4
https://github.com/wxWidgets/wxWidgets/commit/753b6bc9c4d28ff4b5ac3d2b567c1e22d7eb1dd4
Author: mcorino <mco...@m2c-software.nl>
Date: 2026-03-16 (Mon, 16 Mar 2026)
Changed paths:
M interface/wx/webview.h
Log Message:
-----------
Add wxEVT_WEBVIEW_BROWSING_DATA_CLEARED to the documentation
Closes #26299.
Commit: 6894d4c7a2ab9f37af5136839c55fcc76add5020
https://github.com/wxWidgets/wxWidgets/commit/6894d4c7a2ab9f37af5136839c55fcc76add5020
Author: Blake-Madden <66873089+B...@users.noreply.github.com>
Date: 2026-03-17 (Tue, 17 Mar 2026)
Changed paths:
M include/wx/filefn.h
M interface/wx/filefn.h
M src/common/filefn.cpp
M src/msw/utils.cpp
M src/msw/utilswin.cpp
M src/osx/carbon/utilscocoa.mm
M src/osx/cocoa/utils_base.mm
Log Message:
-----------
Fix static build regression in wxGTK due to wxMoveToTrash()
Move this function to core library and only define it under the
platforms that implement it.
This commit is best view using Git --color-moved option.
Closes #26290.
Commit: 1ac87c6ff7ffdca597d35260813e575372542bee
https://github.com/wxWidgets/wxWidgets/commit/1ac87c6ff7ffdca597d35260813e575372542bee
Author: Serdar Pehlivan <61140890...@users.noreply.github.com>
Date: 2026-03-17 (Tue, 17 Mar 2026)
Changed paths:
M interface/wx/affinematrix2d.h
M src/common/affinematrix2d.cpp
Log Message:
-----------
Allow matrix parameter of wxAffineMatrix2D::Get() to be null too
Previously, only the second parameter, in which translation vector was
returned, could be null. Make it possible to specify null for the first
parameter if it is not needed too now.
Still check that at least one parameter is not null, as it doesn't make
sense to call the function otherwise.
Update documentation to reflect the new behaviour.
Closes #26303.
Commit: 03d9f9a831512a6b9a533c2c8fc90eaa9e3400af
https://github.com/wxWidgets/wxWidgets/commit/03d9f9a831512a6b9a533c2c8fc90eaa9e3400af
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-03-17 (Tue, 17 Mar 2026)
Changed paths:
M include/wx/msw/progdlg.h
M src/msw/progdlg.cpp
Log Message:
-----------
Merge branch 'msw-fix-progress-dialog-skip'
Fix showing wxProgressDialog with wxPD_CAN_SKIP in wxMSW.
See #26293.
Compare: https://github.com/wxWidgets/wxWidgets/compare/dfa39460484b...03d9f9a83151
To unsubscribe from these emails, change your notification settings at https://github.com/wxWidgets/wxWidgets/settings/notifications
Home: https://github.com/wxWidgets/wxWidgets
Commit: 2a4318317318e42d41306dccc3a111f6a19f6ec5
https://github.com/wxWidgets/wxWidgets/commit/2a4318317318e42d41306dccc3a111f6a19f6ec5
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-03-15 (Sun, 15 Mar 2026)
Changed paths:
M src/msw/progdlg.cpp
Log Message:
-----------
Return true from wxProgressDialog::Show() on success
We accidentally returned false after successfully showing the native
dialog, which didn't make sense.
Commit: c76e4ff34197fe6fde1b00e7bc07c06c84963e0b
https://github.com/wxWidgets/wxWidgets/commit/c76e4ff34197fe6fde1b00e7bc07c06c84963e0b
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-03-15 (Sun, 15 Mar 2026)
Changed paths:
M src/msw/progdlg.cpp
Log Message:
-----------
Remove unnecessary explicit call to wxThread::Create()
Run() creates the thread if necessary, so there is no need to do it
here.
Commit: 505aa61481cd382f104e973728de0db00e21cfec
https://github.com/wxWidgets/wxWidgets/commit/505aa61481cd382f104e973728de0db00e21cfec
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-03-15 (Sun, 15 Mar 2026)
Changed paths:
M src/msw/progdlg.cpp
Log Message:
-----------
Remove untranslated error message never shown in practice
Messages shown by wxLogError() are user-visible and so need to be
translated, but it doesn't seem to be worth doing it for the message
about failing to start a thread which should be never given -- and if
the system is so low on resources that it can't create new threads,
showing this message would probably fail anyhow.
Just replace it with wxLogDebug().
Commit: 7506289955220ddd9daa43c51f8eaa028e7060df
https://github.com/wxWidgets/wxWidgets/commit/7506289955220ddd9daa43c51f8eaa028e7060df
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-03-15 (Sun, 15 Mar 2026)
Changed paths:
M include/wx/msw/progdlg.h
M src/msw/progdlg.cpp
Log Message:
-----------
Fall back to generic dialog if native wxProgressDialog fails
Even if this is not supposed to happen, fall back to the generic
progress dialog instead of just hanging if showing the native dialog
fails, for whatever reason.
This commit is best viewed with Git --color-moved option.
Commit: 82632d606f6d7a3c5e2815f1ed65e427f2e7911a
https://github.com/wxWidgets/wxWidgets/commit/82632d606f6d7a3c5e2815f1ed65e427f2e7911a
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-03-15 (Sun, 15 Mar 2026)
Changed paths:
M src/msw/progdlg.cpp
Log Message:
-----------
Fix showing wxProgressDialog with wxPD_CAN_SKIP style
This was broken by 02cff90601 (Change return type of wxGetTranslation,
2026-02-15) which resulted in passing invalid pointer to the already
destroyed temporary wxString "Skip" to the native dialog -- which
detected this and failed, resulting in a hang because our code didn't
handle its error correctly.
Error handling was improved in the preceding commits, but now fix the
real underlying bug by ensuring the string lives long enough.
Closes #26287.
Commit: f5ffe79071b1da2edd85fad69b22bc1c75753f11
https://github.com/wxWidgets/wxWidgets/commit/f5ffe79071b1da2edd85fad69b22bc1c75753f11
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-03-15 (Sun, 15 Mar 2026)
Changed paths:
M src/gtk/webview_webkit2.cpp
Log Message:
-----------
Fix crash when opening link in new window in wxWebViewWebKit
The parameters of "ready-to-show" signal handler were deleted, by the
handler itself, after a first call to it, but at least with the current
version of webkit2gtk (2.50.4) this handler can be called more than once
and it crashed when it happened.
Fix this by disconnecting it as soon as it is called, which fixes the
crash and doesn't seem to have any drawbacks.
Note that we might want to find a better way of passing these parameters
as currently they are leaked if the handler is not called at all, which
might happen under some unusual circumstances. But for now just fix the
crash.
Closes #26298.
Commit: 753b6bc9c4d28ff4b5ac3d2b567c1e22d7eb1dd4
https://github.com/wxWidgets/wxWidgets/commit/753b6bc9c4d28ff4b5ac3d2b567c1e22d7eb1dd4
Author: mcorino <mco...@m2c-software.nl>
Date: 2026-03-16 (Mon, 16 Mar 2026)
Changed paths:
M interface/wx/webview.h
Log Message:
-----------
Add wxEVT_WEBVIEW_BROWSING_DATA_CLEARED to the documentation
Closes #26299.
Commit: 6894d4c7a2ab9f37af5136839c55fcc76add5020
https://github.com/wxWidgets/wxWidgets/commit/6894d4c7a2ab9f37af5136839c55fcc76add5020
Author: Blake-Madden <66873089+B...@users.noreply.github.com>
Date: 2026-03-17 (Tue, 17 Mar 2026)
Changed paths:
M include/wx/filefn.h
M interface/wx/filefn.h
M src/common/filefn.cpp
M src/msw/utils.cpp
M src/msw/utilswin.cpp
M src/osx/carbon/utilscocoa.mm
M src/osx/cocoa/utils_base.mm
Log Message:
-----------
Fix static build regression in wxGTK due to wxMoveToTrash()
Move this function to core library and only define it under the
platforms that implement it.
This commit is best view using Git --color-moved option.
Closes #26290.
Commit: 1ac87c6ff7ffdca597d35260813e575372542bee
https://github.com/wxWidgets/wxWidgets/commit/1ac87c6ff7ffdca597d35260813e575372542bee
Author: Serdar Pehlivan <61140890...@users.noreply.github.com>
Date: 2026-03-17 (Tue, 17 Mar 2026)
Changed paths:
M interface/wx/affinematrix2d.h
M src/common/affinematrix2d.cpp
Log Message:
-----------
Allow matrix parameter of wxAffineMatrix2D::Get() to be null too
Previously, only the second parameter, in which translation vector was
returned, could be null. Make it possible to specify null for the first
parameter if it is not needed too now.
Still check that at least one parameter is not null, as it doesn't make
sense to call the function otherwise.
Update documentation to reflect the new behaviour.
Closes #26303.
Commit: 03d9f9a831512a6b9a533c2c8fc90eaa9e3400af
https://github.com/wxWidgets/wxWidgets/commit/03d9f9a831512a6b9a533c2c8fc90eaa9e3400af
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-03-17 (Tue, 17 Mar 2026)
Changed paths:
M include/wx/msw/progdlg.h
M src/msw/progdlg.cpp
Log Message:
-----------
Merge branch 'msw-fix-progress-dialog-skip'
Fix showing wxProgressDialog with wxPD_CAN_SKIP in wxMSW.
See #26293.
Compare: https://github.com/wxWidgets/wxWidgets/compare/dfa39460484b...03d9f9a83151
To unsubscribe from these emails, change your notification settings at https://github.com/wxWidgets/wxWidgets/settings/notifications
Reply all
Reply to author
Forward
0 new messages