[wxWidgets/wxWidgets] 9adc28: Remove wxPathOnly(wxChar*) overload

0 views
Skip to first unread message

VZ

unread,
May 31, 2026, 10:20:12 AM (11 days ago) May 31
to wx-co...@googlegroups.com
Branch: refs/heads/master
Home: https://github.com/wxWidgets/wxWidgets
Commit: 9adc285e3f57a87bce15a48663da1edbeaa240e7
https://github.com/wxWidgets/wxWidgets/commit/9adc285e3f57a87bce15a48663da1edbeaa240e7
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-05-31 (Sun, 31 May 2026)

Changed paths:
M src/common/filefn.cpp

Log Message:
-----------
Remove wxPathOnly(wxChar*) overload

This overload was not declared nor exported from (shared) libraries, so
just remove it.


Commit: f19fdb5b1c750e95cb0fe411b8c671fee5165b11
https://github.com/wxWidgets/wxWidgets/commit/f19fdb5b1c750e95cb0fe411b8c671fee5165b11
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-05-31 (Sun, 31 May 2026)

Changed paths:
M interface/wx/filefn.h
M src/common/filefn.cpp
M tests/file/filefn.cpp

Log Message:
-----------
Reimplement wxPathOnly() using wxFileName::GetPath()

Add tests checking that the function still performs as before and
document that its behaviour slightly differs from GetPath().


Commit: 86bc0762efcee173963d8002934d592141a0e1ae
https://github.com/wxWidgets/wxWidgets/commit/86bc0762efcee173963d8002934d592141a0e1ae
Author: dxbjavid <dxbj...@gmail.com>
Date: 2026-05-31 (Sun, 31 May 2026)

Changed paths:
M src/common/gifdecod.cpp
M tests/image/image.cpp

Log Message:
-----------
Validate decoded pixel indices in wxGIFDecoder::ConvertToImage()

Avoid reading uninitialized memory if any of the pixels in the input
data reference entries beyond the end of the palette.

Closes #26521.


Commit: 830ec3c439ee58f84bb4c214fabe37c5e7d4eaa1
https://github.com/wxWidgets/wxWidgets/commit/830ec3c439ee58f84bb4c214fabe37c5e7d4eaa1
Author: dxbjavid <dxbj...@gmail.com>
Date: 2026-05-31 (Sun, 31 May 2026)

Changed paths:
M src/common/gifdecod.cpp
M tests/image/image.cpp

Log Message:
-----------
Avoid writing beyond the buffer end for GIFs with zero size

Reject GIF frames with zero width or height to avoid writing beyond the
(empty) buffer returned by malloc(0).

Closes #26524.


Commit: a3ad8e33602aff06e57a7d3637df546cc07593b0
https://github.com/wxWidgets/wxWidgets/commit/a3ad8e33602aff06e57a7d3637df546cc07593b0
Author: dxbjavid <dxbj...@gmail.com>
Date: 2026-05-31 (Sun, 31 May 2026)

Changed paths:
M src/common/wxcrt.cpp
M src/common/wxprintf.cpp
M tests/strings/crt.cpp

Log Message:
-----------
Fix buffer overflow in wxVsnprintf() when size==0

Don't write NUL byte to "buf[size - 1]" when size is 0.

This bug was present in both implementations of wxVsnprintf(), so fix it
in both places too.

Closes #26522.


Commit: e4a462d4bc034ee9e08df7ded46ac5d0e11f9fd4
https://github.com/wxWidgets/wxWidgets/commit/e4a462d4bc034ee9e08df7ded46ac5d0e11f9fd4
Author: dxbjavid <dxbj...@gmail.com>
Date: 2026-05-31 (Sun, 31 May 2026)

Changed paths:
M src/common/imaggif.cpp
M tests/image/image.cpp

Log Message:
-----------
Fix palette buffer overflow in wxGIFHandler::SaveFile()

The image palette can have more than the 256 entries a GIF supports, for
example when the image was loaded from an XPM that declares a larger
colour count. wxGIFHandler_GetPalette(), called when saving a GIF,
copied every entry into the caller's fixed wxRGB pal[256] buffer,
overflowing it.

Such an image can't be represented as a GIF, so reject the save with an
error message instead of overflowing the buffer or writing out a silently
truncated palette.

Closes #26532.


Commit: a37e6ba6c4add1c4fdf3cd855973c85f7ee37e7a
https://github.com/wxWidgets/wxWidgets/commit/a37e6ba6c4add1c4fdf3cd855973c85f7ee37e7a
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-05-31 (Sun, 31 May 2026)

Changed paths:
M interface/wx/filefn.h
M src/common/filefn.cpp
M tests/file/filefn.cpp

Log Message:
-----------
Merge branch 'reimplement-pathonly'

Reimplement wxPathOnly() using wxFileName::GetPath().

This incidentally fixes a buffer overflow in this function, see #26526.

See #26537.


Compare: https://github.com/wxWidgets/wxWidgets/compare/b62785286845...a37e6ba6c4ad

To unsubscribe from these emails, change your notification settings at https://github.com/wxWidgets/wxWidgets/settings/notifications
Reply all
Reply to author
Forward
0 new messages