[wxWidgets/wxWidgets] ecfaa5: Improve disabled wxListCtrl in MSW dark mode
0 views
Skip to first unread message
VZ
Dec 13, 2025, 4:44:08 PM12/13/25
to wx-co...@googlegroups.com
Branch: refs/heads/master
Home: https://github.com/wxWidgets/wxWidgets
Commit: ecfaa59a831b4acc77b8576676fdd01edc64f6b3
https://github.com/wxWidgets/wxWidgets/commit/ecfaa59a831b4acc77b8576676fdd01edc64f6b3
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Improve disabled wxListCtrl in MSW dark mode
Draw the background color outside the list-items area on all Windows version,
both below and behind the items, and when the list is empty.
Set the text foreground and background colors when custom drawing. So the disabled
list will use the correct colors in list or icon view.
Fixes #25990
Commit: d26f7a85752b0e0ea2b705ab368b7fd86fe724a2
https://github.com/wxWidgets/wxWidgets/commit/d26f7a85752b0e0ea2b705ab368b7fd86fe724a2
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Improve drawing wxListCtrl gird lines in dark mode
The grid lines are erased when custom drawing the sub-items, so the grid lines need to be redrawn after drawing the item.
OnPaint() is not called after every custom draw (e.g. just hovering over a row will cause a custom draw but no paint),
so it has to be drawn in the custom paint handler.
Add a common function for drawing grid lines and reuse it on OnPaint().
Commit: b2ada524dce55596bf9d88e8fcaf6b8622ee5274
https://github.com/wxWidgets/wxWidgets/commit/b2ada524dce55596bf9d88e8fcaf6b8622ee5274
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Fix incorrect wxListCtrl::GetSubItemRect(n, 0)
This was broken in bde6b7a8b8.
When the list is scrolled the x-coordinate will be negative.
So don't start counting from 0, but start from the original x coordinate of the full rectangle.
Commit: 92167838aaa90a84b7df2c42baf8acd5bf0fad85
https://github.com/wxWidgets/wxWidgets/commit/92167838aaa90a84b7df2c42baf8acd5bf0fad85
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Correctly restore dark mode header in MSW wxListCtrl
When removing custom header attributes, the default dark mode attributes need to be restored.
Commit: 907ab5f58ecf539336964464f5f99c89e8f37624
https://github.com/wxWidgets/wxWidgets/commit/907ab5f58ecf539336964464f5f99c89e8f37624
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Fix MSW wxListCtrl custom colours in light mode
This was broken in 3842352b21.
Commit: 10bac0ff4e3d42a5d06aee8b152e43fafa2a4000
https://github.com/wxWidgets/wxWidgets/commit/10bac0ff4e3d42a5d06aee8b152e43fafa2a4000
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Improve drawing MSW wxListCtrl focus rect in dark mode
Subtract 2px so the right border is visible.
Commit: 47891abefe9e303f27a84654f5cee25fd7346fb8
https://github.com/wxWidgets/wxWidgets/commit/47891abefe9e303f27a84654f5cee25fd7346fb8
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Draw hot tracking highlight in MSW wxListCtrl in dark mode
When the mouse is over an item, change the colour of it.
This only works when using Explorer theme, DarkMode_Explorer does not get custom draw calls to remove the colour.
Fixes #26001
Commit: 96e7dcddf685cdae4799daed5818c0e9c55a74fd
https://github.com/wxWidgets/wxWidgets/commit/96e7dcddf685cdae4799daed5818c0e9c55a74fd
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Fix highlighting first item in MSW wxListCtrl in dark mode
The item was also highlighted when hovering over the header because ListView_HitTest
returns true when hovering over the header.
Replace ListView_HitTest by checking if the mouse pointer is in the item rectangle.
Commit: 41a7420f2d7b5de9dc9db978445f04337c7cc619
https://github.com/wxWidgets/wxWidgets/commit/41a7420f2d7b5de9dc9db978445f04337c7cc619
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Slightly increase text padding in MSW wxListCtrl in dark mode
Try to get it to look like light mode.
See #26001
Commit: 99fb774c5d85c25956766edafca1848fd520dfe1
https://github.com/wxWidgets/wxWidgets/commit/99fb774c5d85c25956766edafca1848fd520dfe1
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-12-03 (Wed, 03 Dec 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Better fix for MSW wxListCtrl focus rect visibility
When erasing the background, draw outside the item rectangle.
Commit: 8dc41cf1832951715fa85cc87f254dbc020c2b80
https://github.com/wxWidgets/wxWidgets/commit/8dc41cf1832951715fa85cc87f254dbc020c2b80
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-12-03 (Wed, 03 Dec 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Try to fix missing MSW wxListCtrl attribute colour in dark mode
See #26001
Commit: b56c6bae7ca34194c0f90f8f9675aa94117b0d06
https://github.com/wxWidgets/wxWidgets/commit/b56c6bae7ca34194c0f90f8f9675aa94117b0d06
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-12-03 (Wed, 03 Dec 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Improve MSW wxListCtrl background attribute in dark mode
It extends the full column, including the padding.
To match light mode, there should be 1px between columns that do not have the attribute colour.
The first (most left) column, and columns with checkboxes or images should still use the padding.
Commit: d6737d154802805ec0ea7bd43e8701252793d31f
https://github.com/wxWidgets/wxWidgets/commit/d6737d154802805ec0ea7bd43e8701252793d31f
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-13 (Sat, 13 Dec 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Merge branch 'wxlistctrl-msw-dark-disabled' of github.com:MaartenBent/wxWidgets
Multiple improvements to wxListCtrl in MSW dark mode.
See #25999.
Compare: https://github.com/wxWidgets/wxWidgets/compare/30fb6f469123...d6737d154802
To unsubscribe from these emails, change your notification settings at https://github.com/wxWidgets/wxWidgets/settings/notifications
Home: https://github.com/wxWidgets/wxWidgets
Commit: ecfaa59a831b4acc77b8576676fdd01edc64f6b3
https://github.com/wxWidgets/wxWidgets/commit/ecfaa59a831b4acc77b8576676fdd01edc64f6b3
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Improve disabled wxListCtrl in MSW dark mode
Draw the background color outside the list-items area on all Windows version,
both below and behind the items, and when the list is empty.
Set the text foreground and background colors when custom drawing. So the disabled
list will use the correct colors in list or icon view.
Fixes #25990
Commit: d26f7a85752b0e0ea2b705ab368b7fd86fe724a2
https://github.com/wxWidgets/wxWidgets/commit/d26f7a85752b0e0ea2b705ab368b7fd86fe724a2
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Improve drawing wxListCtrl gird lines in dark mode
The grid lines are erased when custom drawing the sub-items, so the grid lines need to be redrawn after drawing the item.
OnPaint() is not called after every custom draw (e.g. just hovering over a row will cause a custom draw but no paint),
so it has to be drawn in the custom paint handler.
Add a common function for drawing grid lines and reuse it on OnPaint().
Commit: b2ada524dce55596bf9d88e8fcaf6b8622ee5274
https://github.com/wxWidgets/wxWidgets/commit/b2ada524dce55596bf9d88e8fcaf6b8622ee5274
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Fix incorrect wxListCtrl::GetSubItemRect(n, 0)
This was broken in bde6b7a8b8.
When the list is scrolled the x-coordinate will be negative.
So don't start counting from 0, but start from the original x coordinate of the full rectangle.
Commit: 92167838aaa90a84b7df2c42baf8acd5bf0fad85
https://github.com/wxWidgets/wxWidgets/commit/92167838aaa90a84b7df2c42baf8acd5bf0fad85
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Correctly restore dark mode header in MSW wxListCtrl
When removing custom header attributes, the default dark mode attributes need to be restored.
Commit: 907ab5f58ecf539336964464f5f99c89e8f37624
https://github.com/wxWidgets/wxWidgets/commit/907ab5f58ecf539336964464f5f99c89e8f37624
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Fix MSW wxListCtrl custom colours in light mode
This was broken in 3842352b21.
Commit: 10bac0ff4e3d42a5d06aee8b152e43fafa2a4000
https://github.com/wxWidgets/wxWidgets/commit/10bac0ff4e3d42a5d06aee8b152e43fafa2a4000
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Improve drawing MSW wxListCtrl focus rect in dark mode
Subtract 2px so the right border is visible.
Commit: 47891abefe9e303f27a84654f5cee25fd7346fb8
https://github.com/wxWidgets/wxWidgets/commit/47891abefe9e303f27a84654f5cee25fd7346fb8
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Draw hot tracking highlight in MSW wxListCtrl in dark mode
When the mouse is over an item, change the colour of it.
This only works when using Explorer theme, DarkMode_Explorer does not get custom draw calls to remove the colour.
Fixes #26001
Commit: 96e7dcddf685cdae4799daed5818c0e9c55a74fd
https://github.com/wxWidgets/wxWidgets/commit/96e7dcddf685cdae4799daed5818c0e9c55a74fd
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Fix highlighting first item in MSW wxListCtrl in dark mode
The item was also highlighted when hovering over the header because ListView_HitTest
returns true when hovering over the header.
Replace ListView_HitTest by checking if the mouse pointer is in the item rectangle.
Commit: 41a7420f2d7b5de9dc9db978445f04337c7cc619
https://github.com/wxWidgets/wxWidgets/commit/41a7420f2d7b5de9dc9db978445f04337c7cc619
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-11-30 (Sun, 30 Nov 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Slightly increase text padding in MSW wxListCtrl in dark mode
Try to get it to look like light mode.
See #26001
Commit: 99fb774c5d85c25956766edafca1848fd520dfe1
https://github.com/wxWidgets/wxWidgets/commit/99fb774c5d85c25956766edafca1848fd520dfe1
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-12-03 (Wed, 03 Dec 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Better fix for MSW wxListCtrl focus rect visibility
When erasing the background, draw outside the item rectangle.
Commit: 8dc41cf1832951715fa85cc87f254dbc020c2b80
https://github.com/wxWidgets/wxWidgets/commit/8dc41cf1832951715fa85cc87f254dbc020c2b80
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-12-03 (Wed, 03 Dec 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Try to fix missing MSW wxListCtrl attribute colour in dark mode
See #26001
Commit: b56c6bae7ca34194c0f90f8f9675aa94117b0d06
https://github.com/wxWidgets/wxWidgets/commit/b56c6bae7ca34194c0f90f8f9675aa94117b0d06
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2025-12-03 (Wed, 03 Dec 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Improve MSW wxListCtrl background attribute in dark mode
It extends the full column, including the padding.
To match light mode, there should be 1px between columns that do not have the attribute colour.
The first (most left) column, and columns with checkboxes or images should still use the padding.
Commit: d6737d154802805ec0ea7bd43e8701252793d31f
https://github.com/wxWidgets/wxWidgets/commit/d6737d154802805ec0ea7bd43e8701252793d31f
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-13 (Sat, 13 Dec 2025)
Changed paths:
M src/msw/listctrl.cpp
Log Message:
-----------
Merge branch 'wxlistctrl-msw-dark-disabled' of github.com:MaartenBent/wxWidgets
Multiple improvements to wxListCtrl in MSW dark mode.
See #25999.
Compare: https://github.com/wxWidgets/wxWidgets/compare/30fb6f469123...d6737d154802
To unsubscribe from these emails, change your notification settings at https://github.com/wxWidgets/wxWidgets/settings/notifications
Reply all
Reply to author
Forward
0 new messages