[wxWidgets/wxWidgets] cd8c7e: Increase temporary buffer size of streams

0 views
Skip to first unread message

Blake-Madden

unread,
May 21, 2026, 4:45:51 PMMay 21
to wx-co...@googlegroups.com
Branch: refs/heads/master
Home: https://github.com/wxWidgets/wxWidgets
Commit: cd8c7e4d7ef7b89769baaabe870faf141f079868
https://github.com/wxWidgets/wxWidgets/commit/cd8c7e4d7ef7b89769baaabe870faf141f079868
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2026-05-17 (Sun, 17 May 2026)

Changed paths:
M src/common/stream.cpp

Log Message:
-----------
Increase temporary buffer size of streams

Reading large files using a small buffer causes significant delays.

See #26457


Commit: 8f15d1170435b1f3f2f82945e839520e1a485c5d
https://github.com/wxWidgets/wxWidgets/commit/8f15d1170435b1f3f2f82945e839520e1a485c5d
Author: MarkLee131 <kaixu...@ntu.edu.sg>
Date: 2026-05-21 (Thu, 21 May 2026)

Changed paths:
M src/common/imagiff.cpp
M tests/image/image.cpp

Log Message:
-----------
Avoid out-of-bounds palette write in wxIFFDecoder::ConvertToImage

The transparent colour index from the IFF BMHD chunk is a 16-bit
value stored unclamped in m_image->transparent. Using it as a
palette index without checking it against the CMAP-derived colour
count writes 3 bytes at an attacker-controlled offset past the
palette buffer.

Validate the index against the actual palette size before applying
the magenta mask.


Commit: c7eb871978247610bb43b6be14632a5a7cc692c0
https://github.com/wxWidgets/wxWidgets/commit/c7eb871978247610bb43b6be14632a5a7cc692c0
Author: MarkLee131 <kaixu...@ntu.edu.sg>
Date: 2026-05-21 (Thu, 21 May 2026)

Changed paths:
M src/common/imagiff.cpp
M tests/image/image.cpp

Log Message:
-----------
Reject IFF images with out-of-range transparent colour index

Following review on the previous commit, switch from silently ignoring
an out-of-bounds BMHD transparent colour index to rejecting the file
outright in wxIFFDecoder::ConvertToImage. The earlier "ignore" approach
let the load succeed, which made the BadIFF test pass only as a side
effect of corruption from the unrelated overrun and so failed
intermittently in some wxMSW builds.

Apply the bounds check using the form suggested in the PR review.


Commit: 6d86f88f4b0f23a3617f1618b40ba6889ef2c6e4
https://github.com/wxWidgets/wxWidgets/commit/6d86f88f4b0f23a3617f1618b40ba6889ef2c6e4
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-05-21 (Thu, 21 May 2026)

Changed paths:
M src/common/dcsvg.cpp

Log Message:
-----------
Fix text size in SVG after wxSVGGraphicsContext addition

This was inadvertently broken by e1c72e28fc (Add wxSVGGraphicsContext,
2026-05-19) which replaced floating point division with integer division
when determining the scale to use.

Fix this indirectly by adding a new helper ScaleFontForSVG() with the
correct code, which is now reused by both GetTextMetricDC() and
DoGetTextExtent() instead of duplicating its code in both of them.

See #26395.


Commit: 836f1991775f674ca55c6b6230ec3ba6c7a5e3d6
https://github.com/wxWidgets/wxWidgets/commit/836f1991775f674ca55c6b6230ec3ba6c7a5e3d6
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2026-05-21 (Thu, 21 May 2026)

Changed paths:
M include/wx/stream.h
M interface/wx/stream.h
M src/common/stream.cpp

Log Message:
-----------
Add function to read entire wxInputStream to a buffer

When the size is known, read the data directly into the buffer.
Otherwise read it in chucks until the end of the stream is reached.


Commit: 973777583c526cca144003a2a546a72a68715164
https://github.com/wxWidgets/wxWidgets/commit/973777583c526cca144003a2a546a72a68715164
Author: Maarten Bent <Maart...@users.noreply.github.com>
Date: 2026-05-21 (Thu, 21 May 2026)

Changed paths:
M src/common/imagwebp.cpp

Log Message:
-----------
Improve speed of reading webp into memory

Use the newly added wxInputStream::Read() function to read the entire
file into a buffer instead of using wxMemoryOutputStream.

See #26457


Commit: d4188f68378ddb275257d765f9b6b765a893751e
https://github.com/wxWidgets/wxWidgets/commit/d4188f68378ddb275257d765f9b6b765a893751e
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-05-21 (Thu, 21 May 2026)

Changed paths:
M src/common/imagiff.cpp
M tests/image/image.cpp

Log Message:
-----------
Merge branch 'fix/iff-transparent-bounds-check' of github.com:MarkLee131/wxWidgets

Avoid out-of-bounds palette write in wxIFFDecoder::ConvertToImage().

See #26440.


Commit: 238978f42956e4683905a6f0205835c364055510
https://github.com/wxWidgets/wxWidgets/commit/238978f42956e4683905a6f0205835c364055510
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-05-21 (Thu, 21 May 2026)

Changed paths:
M include/wx/stream.h
M interface/wx/stream.h
M src/common/imagwebp.cpp
M src/common/stream.cpp

Log Message:
-----------
Merge branch 'webp-read-buffer-speed' of github.com:MaartenBent/wxWidgets

Improve speed of reading WebP images and add generally useful
wxInputStream::Read(vector<byte>&) overload.

See #26461.


Commit: ee4fbdfb88cbdc17055197d4029ef53c3325a874
https://github.com/wxWidgets/wxWidgets/commit/ee4fbdfb88cbdc17055197d4029ef53c3325a874
Author: Blake-Madden <66873089+B...@users.noreply.github.com>
Date: 2026-05-21 (Thu, 21 May 2026)

Changed paths:
M build/cmake/tests/gui/CMakeLists.txt
M include/wx/dcsvg.h
M interface/wx/dcsvg.h
M src/common/dcsvg.cpp
M tests/Makefile.in
A tests/graphics/svgattributes.cpp
M tests/makefile.gcc
M tests/makefile.vc
M tests/test.bkl
M tests/test_gui.vcxproj
M tests/test_gui.vcxproj.filters

Log Message:
-----------
Add getters to wxSVGAttributes, add unit tests

Closes #26479.


Compare: https://github.com/wxWidgets/wxWidgets/compare/bbad4b8eeb8f...ee4fbdfb88cb

To unsubscribe from these emails, change your notification settings at https://github.com/wxWidgets/wxWidgets/settings/notifications
Reply all
Reply to author
Forward
0 new messages