[wxWidgets/wxWidgets] 46bd3a: Initialize X11-specific wxGLContextAttrs members
1 view
Skip to first unread message
VZ
Dec 7, 2025, 5:40:52 PM12/7/25
to wx-co...@googlegroups.com
Branch: refs/heads/master
Home: https://github.com/wxWidgets/wxWidgets
Commit: 46bd3a49a999e75502fd879a9e954dc7cdb6adb2
https://github.com/wxWidgets/wxWidgets/commit/46bd3a49a999e75502fd879a9e954dc7cdb6adb2
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M include/wx/glcanvas.h
Log Message:
-----------
Initialize X11-specific wxGLContextAttrs members
They didn't seem to be initialized anywhere at all, so do initialize
them in their declaration, even if this is unnecessary in most of the
ports where they are not used -- but as long as they're declared there,
it's simpler and better to still initialize them.
Commit: 207d7d5dd722f040dbe54af3a14b7728d0616cef
https://github.com/wxWidgets/wxWidgets/commit/207d7d5dd722f040dbe54af3a14b7728d0616cef
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M src/qt/glcanvas.cpp
Log Message:
-----------
Don't assign to unused wxGLContextAttrs::renderTypeRGBA in wxQt
This field is only used in GLX-based implementation, it doesn't make
sense to set it in wxQt.
Commit: 8d758d8201c3b597a279fd9a2f79c72c01175336
https://github.com/wxWidgets/wxWidgets/commit/8d758d8201c3b597a279fd9a2f79c72c01175336
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M include/wx/glcanvas.h
Log Message:
-----------
Only define GLX-specific wxGLContextAttrs members when using GLX
They're not used otherwise, so don't even declare them to avoid mistakes
such as the one fixed by the parent commit.
Commit: b740cb4b4651a891c1bc44e6897b3a898c3a33e9
https://github.com/wxWidgets/wxWidgets/commit/b740cb4b4651a891c1bc44e6897b3a898c3a33e9
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M src/unix/glegl.cpp
Log Message:
-----------
Simplify context attributes initialization in wxGLCanvas EGL code
There is no need to check if GetGLAttrs() returns nullptr before using
it, as we just pass nullptr to eglCreateContext() if there are no
attributes anyhow, so just use its result directly.
No real changes.
Commit: a88a56b9fee76ae48a8a35344ec600678e6ccfbe
https://github.com/wxWidgets/wxWidgets/commit/a88a56b9fee76ae48a8a35344ec600678e6ccfbe
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M include/wx/glcanvas.h
M src/unix/glegl.cpp
Log Message:
-----------
Fix OpenGL ES creation in EGL-based wxGLCanvas implementation
The existing code tried to use EGL_RENDERABLE_TYPE as context attribute,
but it is not supported there.
Use eglBindAPI() instead, which also should be called even when not
using ES. To make this work, add a new EGL-specific member to
wxGLContextAttrs: this is a bit ugly, but not more so than the existing
GLX-specific members and is much simpler than any alternative.
See #26012.
Co-authored-by: Timothy Lee <timothy...@gmail.com>
Commit: 2125f520d92c38cb9df1b62d06069d9e3315b0cb
https://github.com/wxWidgets/wxWidgets/commit/2125f520d92c38cb9df1b62d06069d9e3315b0cb
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M misc/suppressions/codespell-lines
Log Message:
-----------
Avoid codespell false positive for "useES" member variable
It shouldn't replaced with "uses".
Commit: 9c1117eb81a66870eb73918724b2fab9eff7b678
https://github.com/wxWidgets/wxWidgets/commit/9c1117eb81a66870eb73918724b2fab9eff7b678
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M src/generic/headerctrlg.cpp
Log Message:
-----------
Don't refresh empty rectangle in generic wxHeaderCtrl
This is useless and just provides pixman warnings with wxGTK.
Commit: 7e7604eb198e7f0716ff8d1c83b119743e8354aa
https://github.com/wxWidgets/wxWidgets/commit/7e7604eb198e7f0716ff8d1c83b119743e8354aa
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M src/generic/headerctrlg.cpp
Log Message:
-----------
Get rid of unused variable in wxHeaderCtrl::OnPaint()
There is no need to have "count" when it's exactly the same as
"m_numColumns".
Commit: 411430b835274bd234947adae467f2126210d6dd
https://github.com/wxWidgets/wxWidgets/commit/411430b835274bd234947adae467f2126210d6dd
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M src/generic/headerctrlg.cpp
Log Message:
-----------
Optimize generic wxHeaderCtrl drawing and work around wxOSX bug
Don't draw all the columns, there is no need to do it for those scrolled
out of view.
As a side effect, don't rely on wxDC::SetDeviceOrigin() for the
coordinates translation but do it ourselves in the drawing code: this is
pretty trivial in this case and avoids a bug in wxOSX which doesn't seem
to honour device origin in its wxRendererNative implementation, somehow.
Closes #26014.
Commit: 3357d3f3255b8da17d18bbe31235b5ea1dfa9a48
https://github.com/wxWidgets/wxWidgets/commit/3357d3f3255b8da17d18bbe31235b5ea1dfa9a48
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-07 (Sun, 07 Dec 2025)
Changed paths:
M configure
M configure.ac
Log Message:
-----------
Relax configure check for EGL version to accept 1.4
This should have been part of 602b80d896 (Support EGL 1.4 instead of
previously required 1.5, 2025-11-23).
See #22325, #25986.
Commit: 9ef4bb2c3f31a34e761e4edac8ac728689af3361
https://github.com/wxWidgets/wxWidgets/commit/9ef4bb2c3f31a34e761e4edac8ac728689af3361
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-07 (Sun, 07 Dec 2025)
Changed paths:
M src/generic/headerctrlg.cpp
Log Message:
-----------
Merge branch 'header-ctrl-fixes'
Some fixes for generic wxHeaderCtrl.
See #26016.
Commit: 6c5ce4862e4a227f95d79618a8ced3d568d2a932
https://github.com/wxWidgets/wxWidgets/commit/6c5ce4862e4a227f95d79618a8ced3d568d2a932
Author: Stefan Csomor <cso...@advancedconcepts.ch>
Date: 2025-12-07 (Sun, 07 Dec 2025)
Changed paths:
M src/osx/cocoa/renderer.mm
Log Message:
-----------
Fix native cell rendering using wrong clipping region in wxOSX
The NSCell drawing routines seem to use a different clipping area than
the one of the current context. This workaround undoes the offsetting of
the dc but then moves the drawing frame accordingly.
See #26014.
Closes #26018.
Commit: f63511101db8d7afeec99ef034956f51ffc198b4
https://github.com/wxWidgets/wxWidgets/commit/f63511101db8d7afeec99ef034956f51ffc198b4
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-07 (Sun, 07 Dec 2025)
Changed paths:
M include/wx/glcanvas.h
M misc/suppressions/codespell-lines
M src/qt/glcanvas.cpp
M src/unix/glegl.cpp
Log Message:
-----------
Merge branch 'opengl-es'
Fix OpenGL ES support in EGL implementation and some cleanups.
See #26015.
Compare: https://github.com/wxWidgets/wxWidgets/compare/69c073699937...f63511101db8
To unsubscribe from these emails, change your notification settings at https://github.com/wxWidgets/wxWidgets/settings/notifications
Home: https://github.com/wxWidgets/wxWidgets
Commit: 46bd3a49a999e75502fd879a9e954dc7cdb6adb2
https://github.com/wxWidgets/wxWidgets/commit/46bd3a49a999e75502fd879a9e954dc7cdb6adb2
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M include/wx/glcanvas.h
Log Message:
-----------
Initialize X11-specific wxGLContextAttrs members
They didn't seem to be initialized anywhere at all, so do initialize
them in their declaration, even if this is unnecessary in most of the
ports where they are not used -- but as long as they're declared there,
it's simpler and better to still initialize them.
Commit: 207d7d5dd722f040dbe54af3a14b7728d0616cef
https://github.com/wxWidgets/wxWidgets/commit/207d7d5dd722f040dbe54af3a14b7728d0616cef
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M src/qt/glcanvas.cpp
Log Message:
-----------
Don't assign to unused wxGLContextAttrs::renderTypeRGBA in wxQt
This field is only used in GLX-based implementation, it doesn't make
sense to set it in wxQt.
Commit: 8d758d8201c3b597a279fd9a2f79c72c01175336
https://github.com/wxWidgets/wxWidgets/commit/8d758d8201c3b597a279fd9a2f79c72c01175336
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M include/wx/glcanvas.h
Log Message:
-----------
Only define GLX-specific wxGLContextAttrs members when using GLX
They're not used otherwise, so don't even declare them to avoid mistakes
such as the one fixed by the parent commit.
Commit: b740cb4b4651a891c1bc44e6897b3a898c3a33e9
https://github.com/wxWidgets/wxWidgets/commit/b740cb4b4651a891c1bc44e6897b3a898c3a33e9
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M src/unix/glegl.cpp
Log Message:
-----------
Simplify context attributes initialization in wxGLCanvas EGL code
There is no need to check if GetGLAttrs() returns nullptr before using
it, as we just pass nullptr to eglCreateContext() if there are no
attributes anyhow, so just use its result directly.
No real changes.
Commit: a88a56b9fee76ae48a8a35344ec600678e6ccfbe
https://github.com/wxWidgets/wxWidgets/commit/a88a56b9fee76ae48a8a35344ec600678e6ccfbe
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M include/wx/glcanvas.h
M src/unix/glegl.cpp
Log Message:
-----------
Fix OpenGL ES creation in EGL-based wxGLCanvas implementation
The existing code tried to use EGL_RENDERABLE_TYPE as context attribute,
but it is not supported there.
Use eglBindAPI() instead, which also should be called even when not
using ES. To make this work, add a new EGL-specific member to
wxGLContextAttrs: this is a bit ugly, but not more so than the existing
GLX-specific members and is much simpler than any alternative.
See #26012.
Co-authored-by: Timothy Lee <timothy...@gmail.com>
Commit: 2125f520d92c38cb9df1b62d06069d9e3315b0cb
https://github.com/wxWidgets/wxWidgets/commit/2125f520d92c38cb9df1b62d06069d9e3315b0cb
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M misc/suppressions/codespell-lines
Log Message:
-----------
Avoid codespell false positive for "useES" member variable
It shouldn't replaced with "uses".
Commit: 9c1117eb81a66870eb73918724b2fab9eff7b678
https://github.com/wxWidgets/wxWidgets/commit/9c1117eb81a66870eb73918724b2fab9eff7b678
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M src/generic/headerctrlg.cpp
Log Message:
-----------
Don't refresh empty rectangle in generic wxHeaderCtrl
This is useless and just provides pixman warnings with wxGTK.
Commit: 7e7604eb198e7f0716ff8d1c83b119743e8354aa
https://github.com/wxWidgets/wxWidgets/commit/7e7604eb198e7f0716ff8d1c83b119743e8354aa
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M src/generic/headerctrlg.cpp
Log Message:
-----------
Get rid of unused variable in wxHeaderCtrl::OnPaint()
There is no need to have "count" when it's exactly the same as
"m_numColumns".
Commit: 411430b835274bd234947adae467f2126210d6dd
https://github.com/wxWidgets/wxWidgets/commit/411430b835274bd234947adae467f2126210d6dd
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-06 (Sat, 06 Dec 2025)
Changed paths:
M src/generic/headerctrlg.cpp
Log Message:
-----------
Optimize generic wxHeaderCtrl drawing and work around wxOSX bug
Don't draw all the columns, there is no need to do it for those scrolled
out of view.
As a side effect, don't rely on wxDC::SetDeviceOrigin() for the
coordinates translation but do it ourselves in the drawing code: this is
pretty trivial in this case and avoids a bug in wxOSX which doesn't seem
to honour device origin in its wxRendererNative implementation, somehow.
Closes #26014.
Commit: 3357d3f3255b8da17d18bbe31235b5ea1dfa9a48
https://github.com/wxWidgets/wxWidgets/commit/3357d3f3255b8da17d18bbe31235b5ea1dfa9a48
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-07 (Sun, 07 Dec 2025)
Changed paths:
M configure
M configure.ac
Log Message:
-----------
Relax configure check for EGL version to accept 1.4
This should have been part of 602b80d896 (Support EGL 1.4 instead of
previously required 1.5, 2025-11-23).
See #22325, #25986.
Commit: 9ef4bb2c3f31a34e761e4edac8ac728689af3361
https://github.com/wxWidgets/wxWidgets/commit/9ef4bb2c3f31a34e761e4edac8ac728689af3361
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-07 (Sun, 07 Dec 2025)
Changed paths:
M src/generic/headerctrlg.cpp
Log Message:
-----------
Merge branch 'header-ctrl-fixes'
Some fixes for generic wxHeaderCtrl.
See #26016.
Commit: 6c5ce4862e4a227f95d79618a8ced3d568d2a932
https://github.com/wxWidgets/wxWidgets/commit/6c5ce4862e4a227f95d79618a8ced3d568d2a932
Author: Stefan Csomor <cso...@advancedconcepts.ch>
Date: 2025-12-07 (Sun, 07 Dec 2025)
Changed paths:
M src/osx/cocoa/renderer.mm
Log Message:
-----------
Fix native cell rendering using wrong clipping region in wxOSX
The NSCell drawing routines seem to use a different clipping area than
the one of the current context. This workaround undoes the offsetting of
the dc but then moves the drawing frame accordingly.
See #26014.
Closes #26018.
Commit: f63511101db8d7afeec99ef034956f51ffc198b4
https://github.com/wxWidgets/wxWidgets/commit/f63511101db8d7afeec99ef034956f51ffc198b4
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2025-12-07 (Sun, 07 Dec 2025)
Changed paths:
M include/wx/glcanvas.h
M misc/suppressions/codespell-lines
M src/qt/glcanvas.cpp
M src/unix/glegl.cpp
Log Message:
-----------
Merge branch 'opengl-es'
Fix OpenGL ES support in EGL implementation and some cleanups.
See #26015.
Compare: https://github.com/wxWidgets/wxWidgets/compare/69c073699937...f63511101db8
To unsubscribe from these emails, change your notification settings at https://github.com/wxWidgets/wxWidgets/settings/notifications
Reply all
Reply to author
Forward
0 new messages