[wxWidgets/wxWidgets] fcf7c9: Use custom configuration name in objects dir path ...
1 view
Skip to first unread message
VZ
Feb 4, 2026, 5:04:26 PMFeb 4
to wx-co...@googlegroups.com
Branch: refs/heads/master
Home: https://github.com/wxWidgets/wxWidgets
Commit: fcf7c97544e7e30278fffa0d9c917f2ee73bb763
https://github.com/wxWidgets/wxWidgets/commit/fcf7c97544e7e30278fffa0d9c917f2ee73bb763
Author: PB <pbfo...@gmail.com>
Date: 2026-01-31 (Sat, 31 Jan 2026)
Changed paths:
M build/msw/wx_setup.props
Log Message:
-----------
Use custom configuration name in objects dir path with MSBuild
When using MSBuild, use the custom configuration name (property wxCfg)
in the object files folder name (property wxIntRootDir), just as it is
already done in the NMake makefile.
Closes #26135.
Closes #26136.
Commit: 6950c3218e4d6212f9584b124973139502cdd05b
https://github.com/wxWidgets/wxWidgets/commit/6950c3218e4d6212f9584b124973139502cdd05b
Author: Hartwig Wiesmann <hartwig....@skywind.eu>
Date: 2026-01-31 (Sat, 31 Jan 2026)
Changed paths:
M src/osx/dataview_osx.cpp
Log Message:
-----------
Fix marking wrong item as being deleted in wxOSX wxDataViewCtrl
The comment in wxDataViewCtrl::IsClearing() said that the item being
deleted should be invalid only when the entire model is being cleared,
but this wasn't the case in ItemDeleted() as its "parent" argument could
be invalid (e.g. when using a flat list model) even if "item" itself is
valid.
Use "item", not "parent", to set the item being deleted to the correct
value to fix this.
Closes #26138.
Closes #26139.
Commit: e688d81af792d78b55ba71e0cdec73c7e1518466
https://github.com/wxWidgets/wxWidgets/commit/e688d81af792d78b55ba71e0cdec73c7e1518466
Author: PB <pbfo...@gmail.com>
Date: 2026-02-01 (Sun, 01 Feb 2026)
Changed paths:
M src/msw/webrequest_winhttp.cpp
Log Message:
-----------
Fix MSVS 2015 build using original Platform SDK
The Windows headers bundled with MSVS 2015 do not define
WINHTTP_OPTION_HTTP_PROTOCOL_USED, an option flag required
after 9a76757 (Add wxWebRequestDebugLogger for details
logging of HTTP transfers, 2026-01-15).
Fix this by defining the option flag by ourselves when needed.
Closes #26144.
Commit: 2ccb240df3135f2c370e9f0c40d0d0f89a74ee78
https://github.com/wxWidgets/wxWidgets/commit/2ccb240df3135f2c370e9f0c40d0d0f89a74ee78
Author: arch1t3cht <arch1...@gmail.com>
Date: 2026-02-01 (Sun, 01 Feb 2026)
Changed paths:
M interface/wx/glcanvas.h
Log Message:
-----------
Document wxGLAttributes::Default no longer using multi-sampling
This was changed in 46857a73ba (Don't use multi-sampling in
wxGLAttributes::Defaults(), 2023-02-14) but the documentation wasn't
updated.
Closes #26143.
Commit: 4bb297d962b1d23345e3b45de8006d7a015e34ea
https://github.com/wxWidgets/wxWidgets/commit/4bb297d962b1d23345e3b45de8006d7a015e34ea
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-02 (Mon, 02 Feb 2026)
Changed paths:
M src/osx/dataview_osx.cpp
Log Message:
-----------
Rename wxOSXDVCDeleting::m_parent to m_item
No real changes, just don't use "parent" for the name of the item being
deleted, this is confusing as it's really the item itself and not its
parent.
See #26139.
Commit: 9d2a24b9f310e07c4bce9d88acd97c0d3a77d3ba
https://github.com/wxWidgets/wxWidgets/commit/9d2a24b9f310e07c4bce9d88acd97c0d3a77d3ba
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-02 (Mon, 02 Feb 2026)
Changed paths:
M tests/arrays/arrays.cpp
Log Message:
-----------
Get rid of multiline macros in wxArray unit test
Use template functions instead.
There is still TestArrayOf() macro left but it's trivial now.
No real changes.
Commit: 5ca8065fe1dd5ef49bfe642aa421766f2ca9f115
https://github.com/wxWidgets/wxWidgets/commit/5ca8065fe1dd5ef49bfe642aa421766f2ca9f115
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-02 (Mon, 02 Feb 2026)
Changed paths:
M src/common/webview.cpp
Log Message:
-----------
Remove unnecessary wxWebViewConfigurationDefault class
This class didn't do anything, base wxWebViewConfigurationImpl can be
used directly instead of it.
Commit: 9975b0ab24d65ccf5d0085b62d30e85419d1277c
https://github.com/wxWidgets/wxWidgets/commit/9975b0ab24d65ccf5d0085b62d30e85419d1277c
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-02 (Mon, 02 Feb 2026)
Changed paths:
M include/wx/msw/webview_ie.h
M src/msw/webview_ie.cpp
Log Message:
-----------
Fix crash when using wxWebViewConfiguration for IE backend
Implement CreateConfiguration() in wxWebViewFactoryIE to return an
object using IE backend name, otherwise using this configuration could
create the backend of a wrong type (e.g. Edge, which is the default
backend if it is enabled) and result in a crash when that backend tried
to cast the configuration pointer to its own type.
Closes #26152.
Commit: 01b5b06874591dde9c5caa3406e6f59a4eb96d64
https://github.com/wxWidgets/wxWidgets/commit/01b5b06874591dde9c5caa3406e6f59a4eb96d64
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-02 (Mon, 02 Feb 2026)
Changed paths:
M include/wx/dynarray.h
M tests/arrays/arrays.cpp
Log Message:
-----------
Assert that index is valid in wxArray::operator[]
Restore compatibility with all the previous wxWidgets versions that had
this assert and make sure that errors in the code using this operator
don't go unnoticed, as it happened with #26148.
Closes #26149.
Commit: d8274596b143227ca65e1e367ec8127054c22d82
https://github.com/wxWidgets/wxWidgets/commit/d8274596b143227ca65e1e367ec8127054c22d82
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M include/wx/gtk/webview_webkit.h
M include/wx/webview.h
M src/common/webview.cpp
M src/gtk/webview_webkit.cpp
Log Message:
-----------
Make wxWebViewFactory::CreateConfiguration() pure virtual
As the parent commit shows, this function must be overridden even for
the backends not using any special configuration type, just to ensure
the returned object has the correct backend string, so having a default
implementation for it was dangerous and could never work.
Force the derived classes to implement this function instead, even if
trivially, as in wxWebViewFactoryIE and wxWebViewFactoryWebKit when not
using WebKit2.
See #26152.
Commit: e80d78c2c96a4986c32a33f83d0118c2397836fb
https://github.com/wxWidgets/wxWidgets/commit/e80d78c2c96a4986c32a33f83d0118c2397836fb
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M interface/wx/stockitem.h
Log Message:
-----------
Document wxGetStockHelpString() function
It was added back in 345319d60c (fixes to menu stock items support
(patch 1547639), 2006-09-05) and even if it's not particularly useful,
it still should be documented, so add documentation for it.
See #8090.
Commit: 5a95c14a39e13cd3fe713a278efe957b5ab13ac5
https://github.com/wxWidgets/wxWidgets/commit/5a95c14a39e13cd3fe713a278efe957b5ab13ac5
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M interface/wx/defs.h
Log Message:
-----------
Minor corrections to standard IDs documentation
Remove misleading Doxygen comments copied from the comments in C++
header which didn't make sense here.
Improve the documentation of menu ID ranges.
Commit: 5d473a8d90955742334dacf8307d83b50fdb8bd8
https://github.com/wxWidgets/wxWidgets/commit/5d473a8d90955742334dacf8307d83b50fdb8bd8
Author: Glen Gordon <18452241+g...@users.noreply.github.com>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M src/msw/webview_edge.cpp
Log Message:
-----------
Fix initial focus in wxWebView Edge backend
Ensure keyboard focus is inside the document if the WebView window gets
focus before MS Webview2 is fully initialized.
If focus moved to the wxWebView window before the Edge instance was
fully created, we couldn't call m_webViewController->MoveFocus at that
time. If focus is on the wxWebview at the time we get the
wxWebViewEdgeImpl::OnWebViewCreated callback, we now call MoveFocus to
ensure that focus is inside of the web content window. This helps
screen readers, since they use the focus window to influence their
behavior.
Closes #26155.
Closes #26156.
Commit: 109ad87d642edb2062af8a65be7298a7a8103251
https://github.com/wxWidgets/wxWidgets/commit/109ad87d642edb2062af8a65be7298a7a8103251
Author: mcorino <mco...@m2c-software.nl>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M interface/wx/propgrid/propgridiface.h
Log Message:
-----------
Fix wxPropertyGridInterface::SetPropertyImage() documentation
It takes wxBitmapBundle by const reference, but "const" was omitted.
Closes #26158.
Commit: d7af4357dba8b305aba161339f53ac7f96776892
https://github.com/wxWidgets/wxWidgets/commit/d7af4357dba8b305aba161339f53ac7f96776892
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M include/wx/gtk/webview_webkit.h
M include/wx/msw/webview_ie.h
M include/wx/webview.h
M src/common/webview.cpp
M src/gtk/webview_webkit.cpp
M src/msw/webview_ie.cpp
Log Message:
-----------
Merge branch 'fix-webview-ie-conf'
Fix using webview configurations for selecting IE backend.
See #26153.
Commit: a70ccb03bd3aea8001675be83c2e05f9b8f58d8c
https://github.com/wxWidgets/wxWidgets/commit/a70ccb03bd3aea8001675be83c2e05f9b8f58d8c
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M include/wx/dynarray.h
M tests/arrays/arrays.cpp
Log Message:
-----------
Merge branch 'array-assert-invalid-index'
Restore wxArray assert checking index validity.
See #26154.
Commit: 7c6300acfb21b4105650576ff8a16c18020e8f4f
https://github.com/wxWidgets/wxWidgets/commit/7c6300acfb21b4105650576ff8a16c18020e8f4f
Author: Stefan Csomor <cso...@advancedconcepts.ch>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M include/wx/osx/filedlg.h
M src/osx/cocoa/filedlg.mm
Log Message:
-----------
Refactor to reuse common code in wxOSX wxFileDialog
Add wxFileDialog::CommonShow() instead of duplicating the same code in
both ShowWindowModal() and ShowModal().
No real changes, this is just a refactoring.
This commit is best viewed using Git --color-moved option.
Commit: 17dbee8a464685122fcd0ed0fd105ed2bac4062e
https://github.com/wxWidgets/wxWidgets/commit/17dbee8a464685122fcd0ed0fd105ed2bac4062e
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M src/osx/cocoa/filedlg.mm
Log Message:
-----------
Fix using invalid filter index in wxOSX wxFileDialog
Ensure we use the valid index in m_filterExtensions when
m_firstFileTypeFilter was set to -1.
Closes #26148.
Commit: 5b96b76a791118beff590d2fc1a7e23d201ff43e
https://github.com/wxWidgets/wxWidgets/commit/5b96b76a791118beff590d2fc1a7e23d201ff43e
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M src/osx/cocoa/filedlg.mm
Log Message:
-----------
Refactor code in wxOSX wxFileDialog to be more readable
No real changes, just try to make the logic of the code more clear (such
as it is, it's still not totally clear why are we doing this, i.e. what
does setting m_firstFileTypeFilter to -1 when m_useFileTypeFilter is
false actually achieve, but at least it's now more obvious that this is
what we do).
Compare: https://github.com/wxWidgets/wxWidgets/compare/7ba5acc72c22...5b96b76a7911
To unsubscribe from these emails, change your notification settings at https://github.com/wxWidgets/wxWidgets/settings/notifications
Home: https://github.com/wxWidgets/wxWidgets
Commit: fcf7c97544e7e30278fffa0d9c917f2ee73bb763
https://github.com/wxWidgets/wxWidgets/commit/fcf7c97544e7e30278fffa0d9c917f2ee73bb763
Author: PB <pbfo...@gmail.com>
Date: 2026-01-31 (Sat, 31 Jan 2026)
Changed paths:
M build/msw/wx_setup.props
Log Message:
-----------
Use custom configuration name in objects dir path with MSBuild
When using MSBuild, use the custom configuration name (property wxCfg)
in the object files folder name (property wxIntRootDir), just as it is
already done in the NMake makefile.
Closes #26135.
Closes #26136.
Commit: 6950c3218e4d6212f9584b124973139502cdd05b
https://github.com/wxWidgets/wxWidgets/commit/6950c3218e4d6212f9584b124973139502cdd05b
Author: Hartwig Wiesmann <hartwig....@skywind.eu>
Date: 2026-01-31 (Sat, 31 Jan 2026)
Changed paths:
M src/osx/dataview_osx.cpp
Log Message:
-----------
Fix marking wrong item as being deleted in wxOSX wxDataViewCtrl
The comment in wxDataViewCtrl::IsClearing() said that the item being
deleted should be invalid only when the entire model is being cleared,
but this wasn't the case in ItemDeleted() as its "parent" argument could
be invalid (e.g. when using a flat list model) even if "item" itself is
valid.
Use "item", not "parent", to set the item being deleted to the correct
value to fix this.
Closes #26138.
Closes #26139.
Commit: e688d81af792d78b55ba71e0cdec73c7e1518466
https://github.com/wxWidgets/wxWidgets/commit/e688d81af792d78b55ba71e0cdec73c7e1518466
Author: PB <pbfo...@gmail.com>
Date: 2026-02-01 (Sun, 01 Feb 2026)
Changed paths:
M src/msw/webrequest_winhttp.cpp
Log Message:
-----------
Fix MSVS 2015 build using original Platform SDK
The Windows headers bundled with MSVS 2015 do not define
WINHTTP_OPTION_HTTP_PROTOCOL_USED, an option flag required
after 9a76757 (Add wxWebRequestDebugLogger for details
logging of HTTP transfers, 2026-01-15).
Fix this by defining the option flag by ourselves when needed.
Closes #26144.
Commit: 2ccb240df3135f2c370e9f0c40d0d0f89a74ee78
https://github.com/wxWidgets/wxWidgets/commit/2ccb240df3135f2c370e9f0c40d0d0f89a74ee78
Author: arch1t3cht <arch1...@gmail.com>
Date: 2026-02-01 (Sun, 01 Feb 2026)
Changed paths:
M interface/wx/glcanvas.h
Log Message:
-----------
Document wxGLAttributes::Default no longer using multi-sampling
This was changed in 46857a73ba (Don't use multi-sampling in
wxGLAttributes::Defaults(), 2023-02-14) but the documentation wasn't
updated.
Closes #26143.
Commit: 4bb297d962b1d23345e3b45de8006d7a015e34ea
https://github.com/wxWidgets/wxWidgets/commit/4bb297d962b1d23345e3b45de8006d7a015e34ea
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-02 (Mon, 02 Feb 2026)
Changed paths:
M src/osx/dataview_osx.cpp
Log Message:
-----------
Rename wxOSXDVCDeleting::m_parent to m_item
No real changes, just don't use "parent" for the name of the item being
deleted, this is confusing as it's really the item itself and not its
parent.
See #26139.
Commit: 9d2a24b9f310e07c4bce9d88acd97c0d3a77d3ba
https://github.com/wxWidgets/wxWidgets/commit/9d2a24b9f310e07c4bce9d88acd97c0d3a77d3ba
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-02 (Mon, 02 Feb 2026)
Changed paths:
M tests/arrays/arrays.cpp
Log Message:
-----------
Get rid of multiline macros in wxArray unit test
Use template functions instead.
There is still TestArrayOf() macro left but it's trivial now.
No real changes.
Commit: 5ca8065fe1dd5ef49bfe642aa421766f2ca9f115
https://github.com/wxWidgets/wxWidgets/commit/5ca8065fe1dd5ef49bfe642aa421766f2ca9f115
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-02 (Mon, 02 Feb 2026)
Changed paths:
M src/common/webview.cpp
Log Message:
-----------
Remove unnecessary wxWebViewConfigurationDefault class
This class didn't do anything, base wxWebViewConfigurationImpl can be
used directly instead of it.
Commit: 9975b0ab24d65ccf5d0085b62d30e85419d1277c
https://github.com/wxWidgets/wxWidgets/commit/9975b0ab24d65ccf5d0085b62d30e85419d1277c
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-02 (Mon, 02 Feb 2026)
Changed paths:
M include/wx/msw/webview_ie.h
M src/msw/webview_ie.cpp
Log Message:
-----------
Fix crash when using wxWebViewConfiguration for IE backend
Implement CreateConfiguration() in wxWebViewFactoryIE to return an
object using IE backend name, otherwise using this configuration could
create the backend of a wrong type (e.g. Edge, which is the default
backend if it is enabled) and result in a crash when that backend tried
to cast the configuration pointer to its own type.
Closes #26152.
Commit: 01b5b06874591dde9c5caa3406e6f59a4eb96d64
https://github.com/wxWidgets/wxWidgets/commit/01b5b06874591dde9c5caa3406e6f59a4eb96d64
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-02 (Mon, 02 Feb 2026)
Changed paths:
M include/wx/dynarray.h
M tests/arrays/arrays.cpp
Log Message:
-----------
Assert that index is valid in wxArray::operator[]
Restore compatibility with all the previous wxWidgets versions that had
this assert and make sure that errors in the code using this operator
don't go unnoticed, as it happened with #26148.
Closes #26149.
Commit: d8274596b143227ca65e1e367ec8127054c22d82
https://github.com/wxWidgets/wxWidgets/commit/d8274596b143227ca65e1e367ec8127054c22d82
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M include/wx/gtk/webview_webkit.h
M include/wx/webview.h
M src/common/webview.cpp
M src/gtk/webview_webkit.cpp
Log Message:
-----------
Make wxWebViewFactory::CreateConfiguration() pure virtual
As the parent commit shows, this function must be overridden even for
the backends not using any special configuration type, just to ensure
the returned object has the correct backend string, so having a default
implementation for it was dangerous and could never work.
Force the derived classes to implement this function instead, even if
trivially, as in wxWebViewFactoryIE and wxWebViewFactoryWebKit when not
using WebKit2.
See #26152.
Commit: e80d78c2c96a4986c32a33f83d0118c2397836fb
https://github.com/wxWidgets/wxWidgets/commit/e80d78c2c96a4986c32a33f83d0118c2397836fb
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M interface/wx/stockitem.h
Log Message:
-----------
Document wxGetStockHelpString() function
It was added back in 345319d60c (fixes to menu stock items support
(patch 1547639), 2006-09-05) and even if it's not particularly useful,
it still should be documented, so add documentation for it.
See #8090.
Commit: 5a95c14a39e13cd3fe713a278efe957b5ab13ac5
https://github.com/wxWidgets/wxWidgets/commit/5a95c14a39e13cd3fe713a278efe957b5ab13ac5
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M interface/wx/defs.h
Log Message:
-----------
Minor corrections to standard IDs documentation
Remove misleading Doxygen comments copied from the comments in C++
header which didn't make sense here.
Improve the documentation of menu ID ranges.
Commit: 5d473a8d90955742334dacf8307d83b50fdb8bd8
https://github.com/wxWidgets/wxWidgets/commit/5d473a8d90955742334dacf8307d83b50fdb8bd8
Author: Glen Gordon <18452241+g...@users.noreply.github.com>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M src/msw/webview_edge.cpp
Log Message:
-----------
Fix initial focus in wxWebView Edge backend
Ensure keyboard focus is inside the document if the WebView window gets
focus before MS Webview2 is fully initialized.
If focus moved to the wxWebView window before the Edge instance was
fully created, we couldn't call m_webViewController->MoveFocus at that
time. If focus is on the wxWebview at the time we get the
wxWebViewEdgeImpl::OnWebViewCreated callback, we now call MoveFocus to
ensure that focus is inside of the web content window. This helps
screen readers, since they use the focus window to influence their
behavior.
Closes #26155.
Closes #26156.
Commit: 109ad87d642edb2062af8a65be7298a7a8103251
https://github.com/wxWidgets/wxWidgets/commit/109ad87d642edb2062af8a65be7298a7a8103251
Author: mcorino <mco...@m2c-software.nl>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M interface/wx/propgrid/propgridiface.h
Log Message:
-----------
Fix wxPropertyGridInterface::SetPropertyImage() documentation
It takes wxBitmapBundle by const reference, but "const" was omitted.
Closes #26158.
Commit: d7af4357dba8b305aba161339f53ac7f96776892
https://github.com/wxWidgets/wxWidgets/commit/d7af4357dba8b305aba161339f53ac7f96776892
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M include/wx/gtk/webview_webkit.h
M include/wx/msw/webview_ie.h
M include/wx/webview.h
M src/common/webview.cpp
M src/gtk/webview_webkit.cpp
M src/msw/webview_ie.cpp
Log Message:
-----------
Merge branch 'fix-webview-ie-conf'
Fix using webview configurations for selecting IE backend.
See #26153.
Commit: a70ccb03bd3aea8001675be83c2e05f9b8f58d8c
https://github.com/wxWidgets/wxWidgets/commit/a70ccb03bd3aea8001675be83c2e05f9b8f58d8c
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M include/wx/dynarray.h
M tests/arrays/arrays.cpp
Log Message:
-----------
Merge branch 'array-assert-invalid-index'
Restore wxArray assert checking index validity.
See #26154.
Commit: 7c6300acfb21b4105650576ff8a16c18020e8f4f
https://github.com/wxWidgets/wxWidgets/commit/7c6300acfb21b4105650576ff8a16c18020e8f4f
Author: Stefan Csomor <cso...@advancedconcepts.ch>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M include/wx/osx/filedlg.h
M src/osx/cocoa/filedlg.mm
Log Message:
-----------
Refactor to reuse common code in wxOSX wxFileDialog
Add wxFileDialog::CommonShow() instead of duplicating the same code in
both ShowWindowModal() and ShowModal().
No real changes, this is just a refactoring.
This commit is best viewed using Git --color-moved option.
Commit: 17dbee8a464685122fcd0ed0fd105ed2bac4062e
https://github.com/wxWidgets/wxWidgets/commit/17dbee8a464685122fcd0ed0fd105ed2bac4062e
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M src/osx/cocoa/filedlg.mm
Log Message:
-----------
Fix using invalid filter index in wxOSX wxFileDialog
Ensure we use the valid index in m_filterExtensions when
m_firstFileTypeFilter was set to -1.
Closes #26148.
Commit: 5b96b76a791118beff590d2fc1a7e23d201ff43e
https://github.com/wxWidgets/wxWidgets/commit/5b96b76a791118beff590d2fc1a7e23d201ff43e
Author: Vadim Zeitlin <va...@wxwidgets.org>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M src/osx/cocoa/filedlg.mm
Log Message:
-----------
Refactor code in wxOSX wxFileDialog to be more readable
No real changes, just try to make the logic of the code more clear (such
as it is, it's still not totally clear why are we doing this, i.e. what
does setting m_firstFileTypeFilter to -1 when m_useFileTypeFilter is
false actually achieve, but at least it's now more obvious that this is
what we do).
Compare: https://github.com/wxWidgets/wxWidgets/compare/7ba5acc72c22...5b96b76a7911
To unsubscribe from these emails, change your notification settings at https://github.com/wxWidgets/wxWidgets/settings/notifications
Reply all
Reply to author
Forward
0 new messages