[Git][wxwidgets/wxwidgets][master] 20 commits: CMake: Use canonicalized library names for plugins

1 view
Skip to first unread message

Vadim Zeitlin (@_VZ_)

unread,
Aug 21, 2026, 7:42:44 PM (6 days ago) Aug 21
to wx-commi...@googlegroups.com

Vadim Zeitlin pushed to branch master at wxWidgets / wxWidgets

Commits:

  • 668bf13e
    by Maarten Bent at 2026-08-16T18:36:15+02:00 
    CMake: Use canonicalized library names for plugins

Make the custom renderer library a plugin so it gets a
canonicalized filename, as expected by wxRendererNative::Load().

Make the renderer sample depend on the custom renderer library.

Fixes #26787
  • b3651d8a
    by Maarten Bent at 2026-08-16T18:36:16+02:00 
    Adjust wxRendererGeneric::GetCollapseButtonSize to DPI
  • 7ed5d009
    by Maarten Bent at 2026-08-16T18:36:16+02:00 
    Reset brush and text colour in custom renderer
  • beb3cce7
    by Maarten Bent at 2026-08-16T18:36:17+02:00 
    Make renderer sample window size DPI aware

Increase its height so the content fits at 150% scaling.
  • 4ca7ba93
    by Maarten Bent at 2026-08-16T22:14:31+02:00 
    Fix debug suffix in CanonicalizePluginName for MSVC libraries

By default, __WXDEBUG__ is also defined for Release builds. So the 'd' suffix is always added.
MSVC builds add 'd' to the filename when the Debug-CRT is used, it is independent of __WXDEBUG__.
As a result, release builds try to load the debug library, and the different CRT causes crashes.

Fix by checking if NDEBUG is not defined by the compiler/CMake and use this to create the canonicalized name.

Also add support for libraries built with the clang compiler.
  • 173f01c9
    by Vadim Zeitlin at 2026-08-16T23:52:33+02:00 
    Use wxSizerFlags and DPI-independent borders in samples

This is an LLM-assisted change as doing it by hand turned out to be too
time-consuming and not worth spending time on it.

See #24755.

Co-Authored-By: Claude Sonnet 5 <nor...@anthropic.com>
  • f44d75a1
    by VZ at 2026-08-18T00:43:03+02:00 
    Use wxSizerFlags::HorzBorder() and DoubleHorzBorder()

This is more concise and clear than `wxLEFT | wxRIGHT`.

Co-authored-by: Cătălin Răceanu <cata...@users.noreply.github.com>
  • 87725f47
    by VZ at 2026-08-18T00:52:30+02:00 
    Remove incorrectly added Expand() calls

This was wrongly added in 173f01c980 (Use wxSizerFlags and DPI-independent borders in samples, 2026-08-16)

Co-authored-by: Cătălin Răceanu <cata...@users.noreply.github.com>
  • db36bc5c
    by VZ at 2026-08-18T00:53:35+02:00 
    Remove commented out wxGROW which made no sense any more

This is irrelevant now that flags are not used any longer here.

Co-authored-by: Cătălin Răceanu <cata...@users.noreply.github.com>
  • 223da5bd
    by VZ at 2026-08-18T00:56:47+02:00 
    Simplify code adding spacers to the sizers in samples

Don't use spacers with borders, just combine border and spacer size.

Also use AddStretchSpacer() instead of growable spacers.

Co-authored-by: Cătălin Răceanu <cata...@users.noreply.github.com>
  • 2c074e4b
    by Vadim Zeitlin at 2026-08-18T00:56:58+02:00 
    Don't use default value of proportion with AddStretchSpacer()

This is useless, so just remove it.
  • a34b9104
    by Vadim Zeitlin at 2026-08-18T00:56:58+02:00 
    Replace remaining 4px borders with standard ones in the samples

The standard border size is 5 or 6 pixels which is not that different
from 4 and it's not worth specifying the size of the border explicitly,
this just distracts from the rest of the code which the samples are
supposed to demonstrate.

Moreover, many borders of size 4 have been already replaced with ones of
standard size in the grandparent commit, so get rid of all the rest of
them too.
  • 03ffd6db
    by Vadim Zeitlin at 2026-08-18T01:36:33+02:00 
    Convert a remaining wxSizer::Add() to use wxSizerFlags

This was one was accidentally forgotten by the commit which changed all
the other ones.
  • 33c4036c
    by Blake-Madden at 2026-08-22T01:14:42+02:00 
    Fix memory leak in GTK animation control

Use wxGtkError to fix missing g_error_free calls.

Closes #26875.
  • 8976d5c0
    by Vadim Zeitlin at 2026-08-22T01:14:42+02:00 
    Merge branch 'custom-renderer' of github.com:MaartenBent/wxWidgets

CMake: Use canonicalized library names for plugins.

See #26826.
  • 20dccd21
    by Scott Talbert at 2026-08-22T01:14:42+02:00 
    Load WebKit extension from the executable directory

This is where the extension is found when built with CMake.

Closes #26854.
  • 7aa40a17
    by Vadim Zeitlin at 2026-08-22T01:14:42+02:00 
    Don't load WebKit extension from "lib" subdirectory

This seems unnecessary as it should be never found there.

See #26854.
  • 129b05c1
    by Vadim Zeitlin at 2026-08-22T01:14:42+02:00 
    Fix using wxPG_FILE_SHOW_FULL_PATH in wxPropertyGrid

This legacy flag value was mapped to a wrong flag and so had no effect.

Closes #25993.
  • 800da292
    by Vadim Zeitlin at 2026-08-22T01:30:14+02:00 
    Merge branch 'samples-sizerflags'

Use wxSizerFlags and DPI-independent borders in samples.

See #26853.
  • 8c72d3e4
    by Richard at 2026-08-22T01:30:14+02:00 
    Fix MSW 1x1 rectangle drawing

GDI Rectangle() draws no pixels for an outlined rectangle with a
physical size of 1x1. Detect this case in
wxMSWDCImpl::DoDrawRectangle() and draw the single device pixel
using the current pen colour, matching DrawPoint() for this
degenerate rectangle.

Keep the documentation and drawing sample focused on the remaining
native GDI limitation for other tiny outlined rectangles.

Fixes #3096.

Closes #26857.

78 changed files:

The diff was not included because it is too large.
Reply all
Reply to author
Forward
0 new messages