[Git][wxwidgets/wxwidgets][master] Fix recently broken buttons functionality in wxAuiNotebook

0 views
Skip to first unread message

Vadim Zeitlin (@_VZ_)

unread,
Nov 9, 2025, 11:11:06 AMNov 9
to wx-commi...@googlegroups.com

Vadim Zeitlin pushed to branch master at wxWidgets / wxWidgets

Commits:

  • 08b10e37
    by Vadim Zeitlin at 2025-11-09T16:42:31+01:00 
    Fix recently broken buttons functionality in wxAuiNotebook

The changes of 7c0354f9e4 (Remove potentially dangling m_pressedButton
too, 2025-11-07) forgot that not only the per-page buttons but also the
notebook buttons themselves could be pressed and didn't account for them
in FindButtonIn().

Fix this by checking these buttons too to restore their functionality,
as they didn't react to being pressed any more.

Closes #25964.

1 changed file:

Changes:

  • src/aui/auibook.cpp
    ... ... @@ -1686,6 +1686,12 @@ void wxAuiTabCtrl::OnLeaveWindow(wxMouseEvent& WXUNUSED(event))
    1686 1686 
     wxAuiTabContainerButton*
    1687 1687 
     wxAuiTabCtrl::FindButtonIn(wxAuiPaneButtonState state) const
    1688 1688 
     {
    1689 
    +    for ( const auto& button : m_buttons )
    1690 
    +    {
    1691 
    +        if ( button.curState & state )
    1692 
    +            return const_cast<wxAuiTabContainerButton*>(&button);
    1693 
    +    }
    1694 
    +
    1689 1695 
         for ( const auto& page : m_pages )
    1690 1696 
         {
    1691 1697 
             for ( const auto& button : page.buttons )

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. Manage all notifications · Help Notification message regarding https://gitlab.com/wxwidgets/wxwidgets/-/commit/08b10e373e8de34ec3f7439615e16a2288df0b35 at 1762704664

Reply all
Reply to author
Forward
0 new messages