[Git][wxwidgets/wxwidgets][master] 18 commits: Fix typos in webview CMake makefile comments

3 views
Skip to first unread message

Vadim Zeitlin (@_VZ_)

unread,
Jan 8, 2026, 5:27:14 PMJan 8
to wx-commi...@googlegroups.com

Vadim Zeitlin pushed to branch master at wxWidgets / wxWidgets

Commits:

  • 8bfadeeb
    by Vadim Zeitlin at 2026-01-05T21:27:15+01:00 
    Fix typos in webview CMake makefile comments

No real changes.
  • 36a08c4c
    by Vadim Zeitlin at 2026-01-05T23:11:33+01:00 
    Merge testdate.h into asserthelper.h

The definitions of overloads used for printing date types when
assertions involving them fail must occur before the main Catch header
inclusion, so move them to asserthelper.h which was already explicitly
included before Catch and remove the redundant (because it was always
included from testprec.h) inclusions of testdate.h from elsewhere.

No real changes.
  • 76cec3f9
    by Vadim Zeitlin at 2026-01-05T23:11:33+01:00 
    Don't include GUI headers when building console test

Use wxUSE_GUI guard around GUI-only headers.
  • 9d218d81
    by Vadim Zeitlin at 2026-01-05T23:25:01+01:00 
    Check for __WXDARWIN_IPHONE__ when defining wxSystem()

This is a non-GUI function, so don't test for GUI wxOSX_USE_IPHONE
symbol when defining it, but use __WXDARWIN_IPHONE__ which is defined
even when not using GUI.
  • cafa693d
    by Vadim Zeitlin at 2026-01-07T14:40:50+01:00 
    Fix test for macOS 10.14

Use correct spelling for the version constant misspelt in 23b3a229d2
(lower the macos requirement (#26067), 2026-01-03).
  • e2e4ff2d
    by Vadim Zeitlin at 2026-01-07T14:40:50+01:00 
    Improve macOS/iOS chkconf.h headers handling

Include these headers when compiling for the corresponding platform
rather than using the default GUI toolkit for the platform to ensure
that the relevant features are correctly enabled or disabled when using
wxBase without any toolkit.

Also move the non-GUI symbols to the beginning of the file and put
wxUSE_GUI guard against the rest just to keep things tidy and avoid
defining GUI-specific symbols when not using GUI.

Finally, also improve (hopefully?) things for wxGTK under macOS by
including GTK-specific chkconf.h too under this platform, just as we
already did under Windows.
  • fbbbf7b3
    by Vadim Zeitlin at 2026-01-07T15:11:12+01:00 
    Set deployment target to 10.13 for CMake Xcode CI build

This is the minimum supported deployment target by the version of Xcode
currently being used and doing this avoids a bunch of warnings of the
form

The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.10,
but the range of supported deployment target versions is 10.13 to
14.5.99.
  • d94975af
    by Vadim Zeitlin at 2026-01-07T15:11:12+01:00 
    Remove redundant __WXOSX__ test from wx/evtloop.h

__UNIX__ is defined when __WXOSX__ is anyhow, so there is no need to
check for the latter explicitly.
  • 96eca641
    by Bill Su at 2026-01-07T15:29:06+01:00 
    Provide safe API for detecting closing wxTipWindow

Previous API was ugly and suffered from a race condition as the window
could be closed before the constructor returned.

Provide a safer API using weak-pointer-like wxTipWindow::Ref class that
is guaranteed to stop being valid when the tip window is closed.

Also implement two-stage constructions for this class, as usual.

Closes #26070.

Closes #26071.
  • 894a04f9
    by Vadim Zeitlin at 2026-01-07T16:04:04+01:00 
    Fix using wxConsoleEventLoop in non-GUI applications under macOS

This class incorrectly inherited from wxEventLoopManual which is not
used in wxBase under macOS, so replace the test for __WXOSX__ with the
check for __WXDARWIN_OSX__ which works correctly even without any GUI
toolkit definition.
  • 2f15e8a5
    by Vadim Zeitlin at 2026-01-07T16:39:43+01:00 
    Test for Apple platforms, not toolkits, in non-GUI tests

__WXOSX__ and __WXOSX_IPHONE__ don't need to be defined (although they
currently are) for non-GUI code.
  • 615b68be
    by Vadim Zeitlin at 2026-01-07T16:39:43+01:00 
    Define wxUSE_GUI=0 when using only base libraries with CMake

This fix consists of two parts: first, don't define toolkit definitions
(such as __WXMSW__, __WXGTK3__ etc) when compiling targets using non-GUI
libraries only. And second, set wxUSE_GUI to 0 if it's not defined and
the toolkit symbol is not defined either in CMake-specific setup.h.

Note that we still keep the now useless fallback definition of wxUSE_GUI
in build/cmake/setup.h.in just because it's simpler to keep this in all
the setup.h files generated by build/update-setup-h than.

Closes #26043.
  • 8dcb5419
    by Maarten Bent at 2026-01-07T17:25:46+01:00 
    Fix disabled wxListCtrl background colour

This was broken by recent dark-mode related changes.

Fixes #26068.

Closes #26072.
  • a2eb3c1e
    by Vadim Zeitlin at 2026-01-08T00:27:01+01:00 
    Remove optional title parameter from MyPrintout in the sample

This was inconsistently specified or omitted, just remove it entirely.

No real changes.
  • 7cdc6968
    by Vadim Zeitlin at 2026-01-08T00:32:57+01:00 
    Fix using dangling wxPrintDialogData pointers in printing sample

Using pointers to a stack wxPrintDialogData variable with MyPrintout and
wxPrintPreview couldn't work correctly as these objects lived for much
longer than the stack variable itself.

Instead, add m_printDialogDataForPreview member variable and use it to
make sure that it lives long enough.

Thanks ASAN for detecting this problem.
  • f9737493
    by Vadim Zeitlin at 2026-01-08T15:42:37+01:00 
    Merge branch 'printing-sample-fixes'

Fix using dangling pointers in the printing sample.

See #26077.
  • 4bd7fe28
    by Vadim Zeitlin at 2026-01-08T22:58:47+01:00 
    Fix handling of hidden wxGrid rows/columns on DPI changes

Update their stored height/width and, even more importantly, update
m_rowBottoms/m_colRights even for them to ensure that these arrays are
always sorted.

Closes #26079.
  • 5e9f6842
    by Vadim Zeitlin at 2026-01-08T23:01:38+01:00 
    Merge branch 'cmake-base-only-use-gui'

Ensure that wxUSE_GUI ends up being defined as 0 when building
applications using only non-GUI (base) libraries with CMake.

See #26074.

Closes #26043.

36 changed files:

The diff was not included because it is too large.
Reply all
Reply to author
Forward
0 new messages