[Git][wxwidgets/wxwidgets][master] 16 commits: Avoid assert when painting empty wxNotebook when using dark mode

1 view
Skip to first unread message

Vadim Zeitlin (@_VZ_)

unread,
Dec 6, 2025, 12:45:48 PM (10 days ago) Dec 6
to wx-commi...@googlegroups.com

Vadim Zeitlin pushed to branch master at wxWidgets / wxWidgets

Commits:

  • ce140743
    by Vadim Zeitlin at 2025-12-01T16:40:29+01:00 
    Avoid assert when painting empty wxNotebook when using dark mode

Don't call GetTabRect(0) if the notebook is empty as this would trigger
an assert inside this function.

This fixes a regression introduced in 365b07b75f (Fix wxPaintDC
invalidation in wxMSW wxNotebook in dark mode, 2025-08-18), see #25700.

Closes #26007.
  • cabf31e8
    by Vadim Zeitlin at 2025-12-01T16:42:13+01:00 
    Remove useless check from wxNotebook::GetTabRect() in wxMSW

There is no need to check that the notebook is not empty because this is
already ensured by the precondition check for the page index validity:
no pages can be valid in an empty notebook.

No real changes, just simplify the code added in 065ff2d2d8 (Add
wxNotebook::GetTabRect() to retrieve the tab position, 2022-11-03).

See #22941.

This commit is best viewed ignoring whitespace-only changes.
  • 75513bc9
    by Maarten Bent at 2025-12-06T12:36:19+01:00 
    Update submodules
  • b93ee415
    by Maarten Bent at 2025-12-06T12:36:20+01:00 
    Add new files to build systems
  • 413ce93f
    by Maarten Bent at 2025-12-06T12:36:20+01:00 
    Regenerate projects
  • 666966ac
    by Robert Roebling at 2025-12-06T18:09:28+01:00 
    Use better name for wxSpinCtrl::SetIncrement() arg in the docs

Call it "inc" instead of "value" because this is what it actually is and
for consistency with the actual header and SetIncrement() in
wxSpinCtrlDouble.
  • 5178043b
    by Robert Roebling at 2025-12-06T18:11:16+01:00 
    Correct wxSpinEvent GetPosition() if start value is non-zero

Set wxSpinButton start value to start value of wxSpinCtrl, otherwise the
generic control used in OSX would report a wrong value in EVT_SPIN.
  • 0b97a4f2
    by Robert Roebling at 2025-12-06T18:12:42+01:00 
    Don't use border for button part of generic wxSpinCtrl

Limit explicit border to be around text control, not the spin button,
which looks very wrong.

Co-authored-by: Vadim Zeitlin <va...@wxwidgets.org>
  • c0bbcd2c
    by Robert Roebling at 2025-12-06T18:18:50+01:00 
    Allow images in higher resolution to be stored in own folder

  - The is an alternative used in other toolkits
  • 89b7f35e
    by Robert Roebling at 2025-12-06T18:24:08+01:00 
    Look for high DPI images in 2.0x subdirectory too

Support an alternative scheme used in other toolkits.

Closes #26003.

Co-authored-by: Vadim Zeitlin <va...@wxwidgets.org>
  • 63021b87
    by Robert Roebling at 2025-12-06T18:25:33+01:00 
    Improve tree buttons appearance under macOS

Force wxCONTROL_PRESSED presence in the flags, this looks like a hack
but it makes the buttons appearance better in both light and dark modes.

Closes #26004.
  • c9755f54
    by Vadim Zeitlin at 2025-12-06T18:27:31+01:00 
    Merge branch 'spin-fixes'

Miscellaneous fixes for generic wxSpinCtrl.

See #26002.
  • dc5be270
    by ali kettab at 2025-12-06T18:28:50+01:00 
    Fix wxGrid overlay selection refresh during drag-select

It wasn't refreshed correctly before, leaving jagged edges.

Closes #26005.
  • e6318ca7
    by Paul Cornett at 2025-12-06T18:33:18+01:00 
    Fix deleting wxTextCtrl in wxEVT_TEXT_ENTER handler in wxGTK

Disconnect the signal handler to ensure it doesn't get called during the
control deletion.

Closes #26006.
  • 40ad53a8
    by Vadim Zeitlin at 2025-12-06T18:36:31+01:00 
    Merge branch 'msw-notebook-gettabrect'

Fix assert in wxNotebook::GetTabRect() when using dark mode.

See #26008.
  • 69c07369
    by Vadim Zeitlin at 2025-12-06T18:37:15+01:00 
    Merge branch 'update-submodules' of github.com:MaartenBent/wxWidgets

Update all third party libraries to their latest versions.

* libexpat: 2.7.1 → 2.7.3
* pcre2: 10.45 → 10.47
* nanosvg: latest
* libwebp: 1.5.0 → 1.6.0
* libpng: 1.6.47 → 1.6.52
* lexilla: 5.4.4 → 5.4.6
* libtiff: 4.7.0 → 4.7.1

See #26010.

34 changed files:

The diff was not included because it is too large.
Reply all
Reply to author
Forward
0 new messages