[Git][wxwidgets/wxwidgets][master] 3 commits: Remove never-enabled code meant to globally change GTK caret blink time

2 views
Skip to first unread message

Vadim Zeitlin (@_VZ_)

unread,
Aug 25, 2026, 10:44:10 AM (2 days ago) Aug 25
to wx-commi...@googlegroups.com

Vadim Zeitlin pushed to branch master at wxWidgets / wxWidgets

Commits:

  • 541ae140
    by Paul Cornett at 2026-08-25T07:07:24-07:00 
    Remove never-enabled code meant to globally change GTK caret blink time

It never worked due to a typo, wasn't a good idea, and even the original
author never noticed that it didn't do anything, so just remove it.
  • a06818fa
    by Paul Cornett at 2026-08-25T07:09:35-07:00 
    Small documentation fixes
  • b2502d42
    by Paul Cornett at 2026-08-25T07:14:59-07:00 
    Add default wxAuiToolBarItem copy ctor to avoid -Wdeprecated-copy warning

5 changed files:

Changes:

  • include/wx/aui/auibar.h
    ... ... @@ -129,7 +129,7 @@ class WXDLLIMPEXP_AUI wxAuiToolBarItem
    129 129
    130 130 
     public:
    131 131 
         wxAuiToolBarItem() = default;
    132 
    -
    132 
    +    wxAuiToolBarItem(const wxAuiToolBarItem&) = default;
    133 133 
         wxAuiToolBarItem& operator=(const wxAuiToolBarItem& c) = default;
    134 134
    135 135 
         void Assign(const wxAuiToolBarItem& c)

  • interface/wx/dc.h
    ... ... @@ -1366,7 +1366,7 @@ public:
    1366 1366 
         void DrawText(const wxString& text, const wxPoint& pt);
    1367 1367
    1368 1368 
         /**
    1369 
    -        Fill the area specified by rect with a radial gradient, starting from
    1369 
    +        Fill the area specified by @a rect with a radial gradient, starting from
    1370 1370 
             @a initialColour at the centre of the circle and fading to
    1371 1371 
             @a destColour on the circle outside.
    1372 1372
    ... ... @@ -1380,7 +1380,7 @@ public:
    1380 1380 
                                     const wxColour& destColour);
    1381 1381
    1382 1382 
         /**
    1383 
    -        Fill the area specified by rect with a radial gradient, starting from
    1383 
    +        Fill the area specified by @a rect with a radial gradient, starting from
    1384 1384 
             @a initialColour at the centre of the circle and fading to
    1385 1385 
             @a destColour on the circle outside.
    1386 1386

  • interface/wx/pen.h
    ... ... @@ -689,10 +689,10 @@ wxPen* wxLIGHT_GREY_PEN;
    689 689
    690 690 
         There are two mechanisms in recent versions of wxWidgets which make the
    691 691 
         pen list less useful than it once was. Under Windows, scarce resources
    692 
    -    are cleaned up internally if they are not being used. Also, a referencing
    692 
    +    are cleaned up internally if they are not being used. Also, a reference
    693 693 
         counting mechanism applied to all GDI objects means that some sharing
    694 694 
         of underlying resources is possible. You don't have to keep track of pointers,
    695 
    -    working out when it is safe delete a pen, because the referencing counting does
    695 
    +    working out when it is safe delete a pen, because the reference counting does
    696 696 
         it for you. For example, you can set a pen in a device context and then
    697 697 
         immediately delete the pen you passed because the pen is 'copied'.
    698 698

  • interface/wx/textentry.h
    ... ... @@ -174,7 +174,7 @@ public:
    174 174 
             The insertion point is set to the start of the control (i.e. position
    175 175 
             0) by this function.
    176 176
    177 
    -        This functions does not generate the @c wxEVT_TEXT
    177 
    +        This function does not generate the @c wxEVT_TEXT
    178 178 
             event but otherwise is identical to SetValue().
    179 179
    180 180 
             See @ref overview_events_prog for more information.

  • src/generic/caret.cpp
    ... ... @@ -74,19 +74,6 @@ int wxCaretBase::GetBlinkTime()
    74 74 
     void wxCaretBase::SetBlinkTime(int milliseconds)
    75 75 
     {
    76 76 
         gs_blinkTime = milliseconds;
    77 
    -
    78 
    -#ifdef _WXGTK__
    79 
    -    GtkSettings *settings = gtk_settings_get_default();
    80 
    -    if (millseconds == 0)
    81 
    -    {
    82 
    -        gtk_settings_set_long_property(settings, "gtk-cursor-blink", gtk_false, nullptr);
    83 
    -    }
    84 
    -    else
    85 
    -    {
    86 
    -        gtk_settings_set_long_property(settings, "gtk-cursor-blink", gtk_true, nullptr);
    87 
    -        gtk_settings_set_long_property(settings, "gtk-cursor-time", milliseconds, nullptr);
    88 
    -    }
    89 
    -#endif
    90 77 
     }
    91 78
    92 79 
     // ----------------------------------------------------------------------------

Reply all
Reply to author
Forward
0 new messages