[Git][wxwidgets/wxwidgets][3.2] Fix building/running with GTK < 2.22

2 views
Skip to first unread message

Vadim Zeitlin (@_VZ_)

unread,
Nov 28, 2025, 5:14:44 PMNov 28
to wx-commi...@googlegroups.com

Vadim Zeitlin pushed to branch 3.2 at wxWidgets / wxWidgets

Commits:

  • e8839930
    by Paul Cornett at 2025-11-28T14:04:05-08:00
    Fix building/running with GTK < 2.22
    
    gtk_message_dialog_get_message_area() requires GTK 2.22
    
    (cherry picked from commit e1a88aaa14d67c44ed7ed03c4a8025f55499ae1d)
    

1 changed file:

Changes:

  • src/gtk/msgdlg.cpp
    ... ... @@ -188,9 +188,11 @@ void wxMessageDialog::GTKCreateMsgDialog()
    188 188
             gtk_window_set_keep_above(GTK_WINDOW(m_widget), TRUE);
    
    189 189
         }
    
    190 190
     
    
    191
    +#if GTK_CHECK_VERSION(2,22,0)
    
    191 192
         // A GTKMessageDialog usually displays its labels without selection enabled,
    
    192 193
         // so we enable selection to allow the user to select+copy the text out of
    
    193 194
         // the dialog.
    
    195
    +    if (wx_is_at_least_gtk2(22))
    
    194 196
         {
    
    195 197
             GtkMessageDialog * const msgdlg = GTK_MESSAGE_DIALOG(m_widget);
    
    196 198
     
    
    ... ... @@ -207,6 +209,7 @@ void wxMessageDialog::GTKCreateMsgDialog()
    207 209
                 }
    
    208 210
             }
    
    209 211
         }
    
    212
    +#endif // GTK_CHECK_VERSION(2,22,0)
    
    210 213
     
    
    211 214
         // we need to add buttons manually if we use custom labels or always for
    
    212 215
         // Yes/No/Cancel dialog as GTK+ doesn't support it natively
    


View it on GitLab.
You're receiving this email because of your account on gitlab.com. Manage all notifications · Help Notification message regarding https://gitlab.com/wxwidgets/wxwidgets/-/commit/e88399300a2371b2bf224e8ae996ce5276b5d983 at 1764368081

Vadim Zeitlin (@_VZ_)

unread,
Nov 28, 2025, 5:14:44 PMNov 28
to wx-commi...@googlegroups.com

Vadim Zeitlin pushed to branch master at wxWidgets / wxWidgets

Commits:

  • e1a88aaa
    by Paul Cornett at 2025-11-28T14:02:06-08:00
  • Fix building/running with GTK < 2.22
    
    gtk_message_dialog_get_message_area() requires GTK 2.22
    

1 changed file:

Changes:

  • src/gtk/msgdlg.cpp
    ... ... @@ -186,9 +186,11 @@ void wxMessageDialog::GTKCreateMsgDialog()
    186 186
             gtk_window_set_keep_above(GTK_WINDOW(m_widget), TRUE);
    
    187 187
         }
    
    188 188
     
    
    189
    +#if GTK_CHECK_VERSION(2,22,0)
    
    189 190
  •      // A GTKMessageDialog usually displays its labels without selection enabled,
    
  • 190 191
  •      // so we enable selection to allow the user to select+copy the text out of
    
  • 191 192
         // the dialog.
    
    193
    +    if (wx_is_at_least_gtk2(22))
    
    192 194
         {
    
    193 195
  •          GtkMessageDialog * const msgdlg = GTK_MESSAGE_DIALOG(m_widget);
    
  • 194 196
     
    
    ... ... @@ -205,6 +207,7 @@ void wxMessageDialog::GTKCreateMsgDialog()
    205 207
                 }
    
    206 208
             }
    
    207 209
         }
    
    210
    +#endif // GTK_CHECK_VERSION(2,22,0)
    
    208 211
     
    
    209 212
  •      // we need to add buttons manually if we use custom labels or always for
    
  • 210 213
  •      // Yes/No/Cancel dialog as GTK+ doesn't support it natively
    


View it on GitLab.
You're receiving this email because of your account on gitlab.com. Manage all notifications · Help Notification message regarding https://gitlab.com/wxwidgets/wxwidgets/-/commit/e1a88aaa14d67c44ed7ed03c4a8025f55499ae1d at 1764368081

Reply all
Reply to author
Forward
0 new messages