[Git][wxwidgets/wxwidgets][master] 56 commits: Fix processing preferred languages list in wxMSW

2 views

Skip to first unread message

Vadim Zeitlin (@_VZ_)

unread,

Jul 15, 2025, 8:04:30 PMJul 15

to wx-commi...@googlegroups.com

Vadim Zeitlin pushed to branch master at wxWidgets / wxWidgets

Commits:

b64d4684

by Harrie Levels at 2025-07-08T00:44:59+02:00

Fix processing preferred languages list in wxMSW

The value returned by RegQueryValueEx() is not necessarily
NUL-terminated, but the code added in 57e1c9e1ee (Update wxWidgets
language database and improve locale matching, 2024-11-18), see #24855,
assumed that it was which could result in buffer overrun.

Make the value NUL-terminated to ensure that this works as intended.

Closes #25612.

e3994203

by Vadim Zeitlin at 2025-07-08T00:47:20+02:00

Fix possible confusion between bytes and characters in wxUILocale

The code used "valueSize", which is the size in bytes, as size of the
array of WCHAR, which is supposed to be expressed in elements, i.e.
(wide) characters in this case.

Make the intention clear by introducing an explicitly named "numChars".

This also means that we allocate enough space for 256, and not 128,
characters here, which was probably the intention.

We may still want to change this code to allocate the required size if
256 is not enough, even if this seems unlikely in practice.

41d298ab

by Vadim Zeitlin at 2025-07-08T00:58:04+02:00

Add wxRegKey::GetHkey()

Provide access to the underlying HKEY, especially as we already allow
setting it.

4faf3d6a

by Vadim Zeitlin at 2025-07-08T00:59:44+02:00

Use wxRegKey to ensure that HKEY is always closed

No real changes, just simplify the code a bit by using wxRegKey instead
of opening and closing the key manually.

It would be even better to add support for REG_MULTI_SZ to wxRegKey
itself and use it directly here, but for now keep the code handling the
values of this type here as we don't need it anywhere else.

This commit is best viewed ignoring whitespace-only changes.

1e65eaf6

by Vadim Zeitlin at 2025-07-08T17:45:50+02:00

Make code iterating over REG_MULTI_SZ even more robust

Don't assume that there is even a single NUL at the end of the returned
buffer (instead of not assuming that there were two of them) and check
that we never read beyond the buffer length.

f5030df2

by Vadim Zeitlin at 2025-07-08T18:12:40+02:00

Replace wxBoxSizer with wxFlexGridSizer in the internat sample

No real changes so far, just make it simpler to add more controls to
this sample in the upcoming commit.

da91e731

by Vadim Zeitlin at 2025-07-08T18:12:42+02:00

Show wxDatePickerCtrl and wxTimePickerCtrl in internal sample too

These controls are also locale-dependent, so it's useful to see how they
behave depending on the UI locale.

128ace42

by Vadim Zeitlin at 2025-07-08T19:00:34+02:00

Add wxUILocale::IsSet()

This can be used to check whether GetCurrent() returns the
application-set locale or the default "C" one.

9d21fe33

by Vadim Zeitlin at 2025-07-08T19:08:26+02:00

Do not use "C" locale for date/time pickers in wxMSW by default

Using "C" date/time formats by default was a gratuitous change compared
to the behaviour in the previous versions of wxWidgets and is
inconsistent with wxCalendarCtrl, which makes it especially jarring.

Revert to the pre-6bcbcf9d09 (Make wxMSW date/time picker controls
locale aware, 2023-10-14) behaviour by default, although still use the
UI locale if it has been explicitly set.

Closes #25511.

aa0ebbe8

by Vadim Zeitlin at 2025-07-08T19:12:21+02:00

Document that wxMSW wxCalendarCtrl always use default user locale

There genuinely doesn't seem to be any way to change it.

172f34ce

by Vadim Zeitlin at 2025-07-09T19:53:30+02:00

Add a note updating docs page on the web site when releasing

See https://github.com/wxWidgets/wxwidgets.github.io/pull/110

f305d67b

by Blake-Madden at 2025-07-09T19:55:32+02:00

Make wxNumberFormatter::RemoveTrailingZeroes() public

This function can be helpful in the application too.

Closes #25614.

85b976cc

by Vadim Zeitlin at 2025-07-10T18:21:47+02:00

Revert "Remove wxGtkTreeModelNode::GetNodesCount()"

This reverts commit adbb1e5348a969f01d3f9d4d2efff85bb5e99b8e because its
assumption ("m_nodes and m_children must be always in sync") wasn't
actually true, "m_nodes" can be empty even if "m_children" is not if the
node hadn't been expanded yet.

Actually, checking m_nodes size is important as not doing it could
result in trying to access non-existent element of this container and
crashing.

Closes #25625.

f7df62c5

by Vadim Zeitlin at 2025-07-10T18:37:41+02:00

Fix type of wxAuiToolBarArt::Get{Label,Tool}Size "dc" parameters

They are now wxReadOnlyDC and not wxDC.

72d5da63

by Vadim Zeitlin at 2025-07-10T18:37:41+02:00

Fix default value of wxUIntPtr data in wxDataViewCtrl docs

wxUIntPtr is not a pointer, so can't be set to nullptr by default, use
the same 0 as is used in the actual C++ header.

bcfed7d0

by jensgoe at 2025-07-10T19:23:23+02:00

Fix wxBitmapComboBox::Append() and Insert() documentation

Their parameters are of type wxBitmapBundle now and not wxBitmap.

See #25623.

Closes #25622.

2f4861b5