[Git][wxwidgets/wxwidgets][wxGTK-on-macOS-Action] 3 commits: Apply suggestions from code review

1 view
Skip to first unread message

Vadim Zeitlin (@_VZ_)

unread,
Oct 25, 2025, 10:07:12 AMOct 25
to wx-commi...@googlegroups.com

Vadim Zeitlin pushed to branch wxGTK-on-macOS-Action at wxWidgets / wxWidgets

Commits:

  • 6b48059d
    by Stefan Csomor at 2025-10-25T15:45:18+02:00 
    Apply suggestions from code review

Co-authored-by: VZ <va...@wxwidgets.org>
  • 944c1a0a
    by Stefan Csomor at 2025-10-25T15:52:31+02:00 
    as suggested, always install and make minmal sample
  • d03680bf
    by Stefan Csomor at 2025-10-25T16:02:09+02:00 
    Removed unnecessary LZMA configure flag

1 changed file:

Changes:

  • .github/workflows/ci_mac_gtk.yml
    ... ... @@ -28,7 +28,7 @@ jobs:
    28 28 
             - name: wxGTK on macOS
    29 29 
               runner: macos-latest
    30 30 
               arch: arm64
    31 
    -          configure_flags: --disable-uiactionsim --with-cxx=11 --without-liblzma --enable-debug --disable-sys-libs --with-gtk=3 --with-opengl=no --enable-detect_sm=no
    31 
    +          configure_flags: --disable-uiactionsim --with-cxx=11 --enable-debug --disable-sys-libs --with-gtk=3 --with-opengl=no --enable-detect_sm=no
    32 32 
               skip_samples: true
    33 33 
               skip_testing: true
    34 34 
               allow_warnings: true
    ... ... @@ -43,7 +43,7 @@ jobs:
    43 43 
             id: set-up-homebrew
    44 44 
             uses: Homebrew/actions/setup-homebrew@main
    45 45
    46 
    -      - name: Install gtk+3
    46 
    +      - name: Install GTK 3
    47 47 
             run: brew install gtk+3
    48 48
    49 49 
           - name: Set environment variables
    ... ... @@ -174,17 +174,15 @@ jobs:
    174 174 
               ./test_gui.app/Contents/MacOS/test_gui $wx_tests_selection
    175 175
    176 176 
           - name: Building samples
    177 
    -        if: matrix.skip_testing != true && matrix.skip_samples != true
    177 
    +        if: matrix.skip_samples != true
    178 178 
             run: |
    179 179 
               make -k $wxBUILD_ARGS "CXXFLAGS=$wxMAKEFILE_CXXFLAGS" "LDFLAGS=$wxMAKEFILE_LDFLAGS" samples
    180 180
    181 181 
           - name: Installing
    182 
    -        if: matrix.skip_testing != true
    183 182 
             run: |
    184 183 
               make install
    185 184
    186 185 
           - name: Testing installation
    187 
    -        if: matrix.skip_testing != true
    188 186 
             run: |
    189 187 
               make -C samples/minimal -f makefile.unx clean
    190 188 
               make -C samples/minimal -f makefile.unx WX_CONFIG=${{ github.workspace }}/localbin_${{ matrix.arch }}/bin/wx-config $wxBUILD_ARGS "CXXFLAGS=$wxMAKEFILE_CXXFLAGS" "LDFLAGS=$wxMAKEFILE_LDFLAGS"

Reply all
Reply to author
Forward
0 new messages