PHP 5.5 support

132 views
Skip to first unread message

chris.ki...@gmail.com

unread,
Sep 26, 2013, 2:57:08 AM9/26/13
to wsdl2php...@googlegroups.com
Hi Crew,

I have a fork waiting that introduces support for PHP 5.5:

https://github.com/chriskl/wsdl2phpgenerator

Basically the Generator class is now taken by PHP's native generators, so my solution was to namespace the entire app.

Will send a pull request soon if it's acceptable...

Chris

Fredrik Wallgren

unread,
Oct 3, 2013, 4:45:43 AM10/3/13
to wsdl2php...@googlegroups.com, chris.ki...@gmail.com
Great! Thanks for contributing.

Just send your pull request when you feel ready :)
You can also start one now (pull request) to start a discussion about it on Github, and tell us when it's ready to merge. 

Regards,
Fredrik

Den torsdagen den 26:e september 2013 kl. 08:57:08 UTC+2 skrev chris.ki...@gmail.com: > Hi Crew, > > I have a fork waiting that introduces support for PHP 5.5: > > https://github.com/chriskl/wsdl2phpgenerator > > Basically the Generator class is now taken by PHP's native generators, so my solution was to namespace the entire app. > > Will send a pull request soon if it's acceptable... > > Chris

Christopher Kings-Lynne

unread,
Oct 3, 2013, 4:52:15 AM10/3/13
to Fredrik Wallgren, wsdl2php...@googlegroups.com
I note that your unit test for the currency convertor is failing on my
fork - it simply never creates the enumerated currency type. I
haven't looked into if it's a problem in the main branch too yet.

I've started a reporting services library that uses Phing and
wsdl2phpgenerator to do it's magic:
https://packagist.org/packages/chriskl/phpssrs

Will look into unit tests asap and send a pull request later.

If you have the energy, please look into whether or not all unit tests
are currently passing on the main project?

I've also improved your composer.json, so wsdl2phpgenerator can
actually be composed in in other projects:

https://github.com/chriskl/wsdl2phpgenerator/blob/master/composer.json

I've used this technique in my own phpssrs project:

https://github.com/chriskl/phpssrs/blob/master/composer.json

My main complaint about wsdl2phpgenerator is that it uses those nasty
parameter classes, rather than just putting the parameters directly on
the soap method call...any chance of a command line switch that does
that?

Cheers,

Chris
Reply all
Reply to author
Forward
0 new messages