PHP 7.2 Support

[Eric Keyte]

Hey all!

I'm new to this forum and this project, but I am very interested in helping out where I can.

I ran into this same issue about 2 weeks ago: https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/issues/330

My company depends heavily on this library, and we are also looking at upgrading our servers to PHP 7.2. I wrote up a new pull request which bumps our PhpUnit version to 5.7.x and updated the implements property on the PhpClass.php file to initialize always to an empty array so it's Countable.

See: https://symfony.com/blog/get-ready-for-php-7-2#making-your-applications-compatible-with-php-7-2

The caveat here is that we would need to drop support for PHP 5.4 and 5.5 in order to support 7.2. Which seems fine, if we can release a new version of wsdl2phpgenerator.

As a note, it looks like someone took a stab at this a few days ago, but it was closed and removed immediately after posted. I'd like to know if they encountered the same crossroads I did, as the answer isn't super straightforward: https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/331

The reason I upgraded PhpUnit was because of this error:

PHP Deprecated:  The each() function is deprecated. This message will be suppressed on further calls in /Users/ekeyte/Projects/opensource/wsdl2phpgenerator/vendor/phpunit/phpunit/src/Util/Getopt.php on line 38

My question is, what do you think is the best way forward here?

-Eric