I have a number of changes I'd like to commit

11 views
Skip to first unread message

Eric Berman

unread,
May 14, 2014, 11:14:47 AM5/14/14
to wsdl2obj...@googlegroups.com
I'd like to get in touch with the owners to review these changes and/or get commit privileges.

My changes are around:
 - Fixing a few bugs around ASP.NET compatibility
 - Enabling compilation with the latest versions of XCode (needs to use ARC)
 - Removing a whole bunch of warnings when compiling for 64-bit.

Henri Asseily

unread,
May 14, 2014, 12:12:40 PM5/14/14
to wsdl2obj...@googlegroups.com
Hello Eric, you’re cleared to commit. Thanks.
> --
> You received this message because you are subscribed to the Google Groups "WSDL2ObjC Discussion Group" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to wsdl2objc-disc...@googlegroups.com.
> To post to this group, send email to wsdl2obj...@googlegroups.com.
> Visit this group at http://groups.google.com/group/wsdl2objc-discuss.
> For more options, visit https://groups.google.com/d/optout.

Eric Berman

unread,
May 14, 2014, 12:26:36 PM5/14/14
to wsdl2obj...@googlegroups.com
Thanks -

Just to be sure - nobody wants to review my edits? I've tested in my environment with my apps, but I don't know if there is a suite of tests I should be running...

Thanks

Sent from my iPad, so please forgive the auto-incorrect
> You received this message because you are subscribed to a topic in the Google Groups "WSDL2ObjC Discussion Group" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/topic/wsdl2objc-discuss/e8B3dqD2grI/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to wsdl2objc-disc...@googlegroups.com.

Eric Berman

unread,
May 14, 2014, 6:52:46 PM5/14/14
to wsdl2obj...@googlegroups.com
Thanks, I've just done a couple of commits, I will try to get the remainder in tomorrow.  (I need to segregate the changes so that each commit covers, ideally, just one thing).

Eric Berman

unread,
May 14, 2014, 11:31:25 PM5/14/14
to wsdl2obj...@googlegroups.com
Remaining commits are done.  These should fix the following issues:
 - a) Will now build in current versions of XCode.  (Old code wouldn't build until it was upgraded to use ARC)
 - b) I upgraded a number of method calls/etc., which had been causing warnings at compile time (deprecated calls or compile time silliness like NSString * s = [NSString stringWithString:@"somestring"], which is just more runtime processing than "NSString * s = @"somestring"
 - c) "int" is always 32-bit, but NSInteger is 32- or 64-bit depending on platform, and this was causing compiler warnings and a few potential bugs.  I cleaned this up as well so that generated code compiles cleanly.

There is one remaining compiler warning for which I have a fix, but which I did not check in; I will ask about that on a separate thread.
Reply all
Reply to author
Forward
0 new messages