Issue 1052 in wp-e-commerce: Can't have PayPal Standard and PayPal Pro Active at Same Time in 3.8

[wp-e-c...@googlecode.com]

Status: Accepted
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1052 by da...@dewpointproductions.com: Can't have PayPal Standard
and PayPal Pro Active at Same Time in 3.8
http://code.google.com/p/wp-e-commerce/issues/detail?id=1052

What steps will reproduce the problem?
1.Activate both PayPal Pro and PayPal Standard
2.Enter item in cart, ,
3.go to checkout
4.attempt to checkout with PayPal Standard

What is the expected output? What do you see instead?
Redirects to checkout page rather than going to PayPal.

What version of the product are you using? On what operating system?
3.8.8, wp 3.3.2, all browsers

If this issue has been discussed in the forums, please link to the relevant
posts.
May be similar to ticket 1038, but hard to tell based on their description
which isn't very clear.

Please use labels and text to provide additional information.

[wp-e-c...@googlecode.com]

Comment #1 on issue 1052 by gary...@garyc40.com: Can't have PayPal Standard

and PayPal Pro Active at Same Time in 3.8
http://code.google.com/p/wp-e-commerce/issues/detail?id=1052

Hi David,

I tried reproducing this issue on a vanilla WPEC installation and couldn't.
I activated both payment gateways, and both seem to work fine for me.

Do you have any customized setup with Checkout Fields (in
Settings->Checkout)? This could also be related to shipping or tax modules
that you're using, so we might need more information about that as well.

Thanks!

[wp-e-c...@googlecode.com]

Updates:
Status: Invalid

Comment #2 on issue 1052 by gary...@garyc40.com: Can't have PayPal Standard

and PayPal Pro Active at Same Time in 3.8
http://code.google.com/p/wp-e-commerce/issues/detail?id=1052

Marking this as invalid until further feedback.

[wp-e-c...@googlecode.com]

Updates:
Status: Reopened

Comment #3 on issue 1052 by off...@zaowebdesign.com: Can't have PayPal

Standard and PayPal Pro Active at Same Time in 3.8
http://code.google.com/p/wp-e-commerce/issues/detail?id=1052

Didn't realize this was here. Hitting this exact bug. The issue is that
wpsc_checkout::validate_forms() checks the existence of the credit card
fields in Pro, if they're empty, it sets errors.

It does no checking to see if the gateway submitted actually uses those
fields or not. I'd argue those first 80 lines of that method should really
just be hooked into by whatever gateway was submitted, but that's just me -
probably all moot with the new API...anyway.

To get around this without hacking core, hook in to
wpsc_before_submit_checkout, check the submitted gateway, and unset the
post vars for the credit card fields...that's what I'm doing now, thinking
it will fix it. Will post back soon.

[wp-e-c...@googlecode.com]

Updates:
Labels: -Priority-Medium Priority-High Milestone-3.9

Comment #4 on issue 1052 by off...@zaowebdesign.com: Can't have PayPal

Standard and PayPal Pro Active at Same Time in 3.8
http://code.google.com/p/wp-e-commerce/issues/detail?id=1052

Yep, that workaround worked great. Here's the code for any others that
find this.


add_action( 'wpsc_before_submit_checkout', 'paypal_post_var_fix' );

function paypal_post_var_fix() {

if ( 'wpsc_merchant_paypal_standard' == $_POST['custom_gateway'] ) {

if ( isset( $_POST['card_number'] ) )
unset( $_POST['card_number'] );

if ( isset( $_POST['expiry'] ) )
unset( $_POST['expiry'] );

if ( isset( $_POST['card_code'] ) )
unset( $_POST['card_code'] );

if ( isset( $_POST['cctype'] ) )
unset( $_POST['cctype'] );
}
}

[wp-e-c...@googlecode.com]

Comment #5 on issue 1052 by shephe...@gmail.com: Can't have PayPal Standard

and PayPal Pro Active at Same Time in 3.8
http://code.google.com/p/wp-e-commerce/issues/detail?id=1052

Add this code to where?

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[wp-e-c...@googlecode.com]

Comment #6 on issue 1052 by Dpkmahen...@gmail.com: Can't have PayPal

Standard and PayPal Pro Active at Same Time in 3.8
http://code.google.com/p/wp-e-commerce/issues/detail?id=1052

where to add this code?

[wp-e-c...@googlecode.com]

Comment #7 on issue 1052 by sambrass...@gmail.com: Can't have PayPal

Standard and PayPal Pro Active at Same Time in 3.8
http://code.google.com/p/wp-e-commerce/issues/detail?id=1052

I tried adding this into it's proper spot, the functions.php file, but it's
still not working. The function is firing, but for whatever reason, the
page is still just refreshing. Anyone have thoughts?