[dev] [dwm] drw_scm_free() and drw_clr_free() in drw.h

[Listeria monocytogenes]

The Xft(3) man page says:

> XftColorAllocName() and XftColorAllocValue() request a color allocation
> from the X server (if necessary) and initialize the members of XftColor.
> XftColorFree() instructs the X server to free the color currently allo‐
> cated for an XftColor.

drw_scm_create() calls drw_clr_create() which in turn calls
XftColorAllocName(), but instructs the user to call free(3) on the
returned color scheme, which is insufficient, as the color allocated by
XftColorAllocName() was not free'd.

I suggest adding the functions drw_clr_free(Drw *drw, Clr *clr) and
drw_scm_free(Drw *drw, Clr *scm, size_t clrcount) to properly free the
allocated color and scheme.

[Hiltjo Posthuma]

Hi,

Thanks for the feedback.

I've pushed patches to dwm and dmenu.

Please test them.

--
Kind regards,
Hiltjo

[Listeria monocytogenes]

On Sat Sep 27, 2025 at 10:16 AM UTC, Hiltjo Posthuma wrote:
> Hi,
>
> Thanks for the feedback.
>
> I've pushed patches to dwm and dmenu.

Hi,

Thanks for the quick reply.

Given that drw_scm_create() is the one making the allocation, I would
consider having drw_scm_free() call free(3), as I don't see a case for
keeping the allocated buffer.

> Please test them.

Will do.

[Hiltjo Posthuma]

Yeah that makes sense. I've pushed patches to dmenu, dwm and libsl again to
change this.

Thanks,

--
Kind regards,
Hiltjo