[Mediawiki-l] Problem sending confirmation email after upgrade to 1.17.3

2 views

Skip to first unread message

Joanna Cheng

unread,

Mar 25, 2012, 5:04:26 PM3/25/12

to MediaWiki announcements and site admin list

After adding $wgShowExceptionDetails = true; to LocalSettings.php
===========================
Internal error

Non-string key given

Backtrace:

#0 $wikipath/includes/GlobalFunctions.php(781): MessageCache->get(NULL,
true, Object(Language))
#1 $wikipath/includes/GlobalFunctions.php(902): wfMsgGetKey(NULL, true,
Object(Language), false)
#2 $wikipath/languages/Language.php(513): wfMsgExt(NULL, Array)
#3 $wikipath/languages/Language.php(525): Language->getMessageFromDB(NULL)
#4 $wikipath/languages/Language.php(799): Language->getMonthName(false)
#5 $wikipath/languages/Language.php(1560): Language->sprintfDate('H:i, j F
Y', false)
#6 $wikipath/includes/User.php(2970):
Language->timeanddate('9c175ace21c28db...', false)
#7 $wikipath/includes/specials/SpecialUserlogin.php(202):
User->sendConfirmationMail()
#8 $wikipath/includes/specials/SpecialUserlogin.php(132):
LoginForm->addNewAccount()
#9 $wikipath/includes/specials/SpecialUserlogin.php(34):
LoginForm->execute()
#10 [internal function]: wfSpecialUserlogin(NULL, Object(SpecialPage))
#11 $wikipath/includes/SpecialPage.php(851):
call_user_func('wfSpecialUserlo...', NULL, Object(SpecialPage))
#12 $wikipath/includes/SpecialPage.php(578): SpecialPage->execute(NULL)
#13 $wikipath/includes/Wiki.php(262):
SpecialPage::executePath(Object(Title))
#14 $wikipath/includes/Wiki.php(63):
MediaWiki->handleSpecialCases(Object(Title), Object(OutputPage),
Object(WebRequest))
#15 $wikipath/index.php(114):
MediaWiki->performRequestForTitle(Object(Title), NULL, Object(OutputPage),
Object(User), Object(WebRequest))
#16 {main}
=============================

The actual registration goes through because I can't re-register a nick
after this error. From the stacktrace I'm guessing the problem is sending
the email.

No idea how to debug, any pointers would be much appreciated.

Thanks in advance,
Joanna
_______________________________________________
MediaWiki-l mailing list
Media...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-l

Daniel Friesen

unread,

Mar 25, 2012, 11:30:36 PM3/25/12

to media...@lists.wikimedia.org

On Sun, 25 Mar 2012 14:04:26 -0700, Joanna Cheng <joanna...@gmail.com>
wrote:

We have a bug open for this issue:
https://bugzilla.wikimedia.org/show_bug.cgi?id=35441

It looks like I was a little hasty in some of my changes to make callers
start using MWCryptRand. When I dropped the salt using $expiration and
replaced with MWCryptRand I dropped the $expiration variable setting. But
it turns out that said variable was actually a reference and external
functions were relying on the fact that it just happened to be modified by
the function. It didn't help that 1.17 had some trivial code changes that
created patch conflicts and forced me to manually apply modifications to
1.17.

We should be making a follow up release sometime soon when we're sure
there aren't any other bugs in the release we need to fix.