[PATCH] Don't set X-GDM-SessionRegisters to true

[Balló György]

Window Maker does not call the RegisterSession() method on GDM's D-Bus
interface, causing that GDM doesn't know that the login was successful,
which leads to problems. If X-GDM-SessionRegisters is not specified or
false, GDM registers the session itself.
---
WindowMaker/wmaker.desktop | 1 -
1 file changed, 1 deletion(-)

diff --git a/WindowMaker/wmaker.desktop b/WindowMaker/wmaker.desktop
index 7b57d811..721b73ed 100644
--- a/WindowMaker/wmaker.desktop
+++ b/WindowMaker/wmaker.desktop
@@ -4,4 +4,3 @@ Comment=This session logs you into Window Maker
Exec=wmaker
TryExec=wmaker
DesktopNames=WindowMaker
-X-GDM-SessionRegisters=true
--
2.52.0

[Carlos R. Mafra]

Thanks for the patch!

Do you have more context on the issue? How did you find it, or is there
a bug report somewhere?

The patch is fine though!

> --
> You received this message because you are subscribed to the Google Groups "Window Maker Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to wmaker-dev+...@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/wmaker-dev/CAK4rBJSqXBs3aFw252HaXWEA4v6X%2BPcUEhQGpiANMF0O2VDYnA%40mail.gmail.com.

[Balló György]

Carlos R. Mafra <crm...@gmail.com> ezt írta (időpont: 2026. jan. 13.,
K, 13:07):

> Do you have more context on the issue? How did you find it, or is there
> a bug report somewhere?

I noticed this when I logged out from Window Maker, and tried to log
in into another session with GDM, it doesn't work, because the login
screen hangs as the previous session was not entered into registered
state within GDM.

If X-GDM-SessionRegisters=true is specified, GDM expects that the
session will be registered via D-Bus:
https://gitlab.gnome.org/GNOME/gdm/-/commit/1c061b84ffc3e874da825982d18d970556ff74bb

E.g. GNOME Shell calls RegisterSession() method after login:
https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/0e37cd2ec92c5fbbc0870272e5e00fc07a705eba

--
György Balló

[Carlos R. Mafra]

Thanks!

I am a little worried that this change in GDM was done in 2019 to address
some Wayland stuff

https://gitlab.gnome.org/GNOME/gdm/-/commit/1c061b84ffc3e874da825982d18d970556ff74bb

Do you know what happens if a user is on a older GDM?

I would like to understand it in order to see the potential for
regressions. 2019 is not too long ago.

[Balló György]

Carlos R. Mafra <crm...@gmail.com> ezt írta (időpont: 2026. jan. 13.,

K, 13:29):

> Do you know what happens if a user is on a older GDM?

Older versions behave the same way as would be X-GDM-SessionRegisters
not set or false.

Currently X-GDM-SessionRegisters=true is used only by GNOME Shell. All
other sessions omit this property, because they don't call the
RegisterSession() method on GDM's D-Bus interface after login.

--
György Balló

[Carlos R. Mafra]

Great, thanks!