[repo.or.cz] wmaker-crm.git annotated tag wmaker-0.96.0 created: wmaker-0.96.0

[crmafra]

This is an automated email generated because a ref change occurred in the
git repository for project wmaker-crm.git.

The annotated tag, wmaker-0.96.0 has been created
at aff88643aa76876c6c44b74b6c073032bbb1b010 (tag)
tagging d0aa2cefcdd3ea72fa463213314757647cde46b3 (commit)
replaces wmaker-0.95.9
tagged by Carlos R. Mafra
on Sat, 5 Aug 2023 08:53:04 +0100

- Log -----------------------------------------------------------------
tag aff88643aa76876c6c44b74b6c073032bbb1b010
Tag: wmaker-0.96.0
Object: d0aa2cefcdd3ea72fa463213314757647cde46b3 (commit)
Tagger: Carlos R. Mafra
Date: Sat, 5 Aug 2023 08:53:04 +0100
URL: <https://repo.or.cz/wmaker-crm.git/aff88643aa76876c>

Window Maker 0.96.0

Alexander Komarov (3):
Double click on titlebar maximize a window to fullscreen
Changed Russian translation
Added Expert option: "Close rootmenu when mouse (left or right) is clicked outside focus.

Carlos R. Mafra (1):
Window Maker 0.96.0

Christophe CURIS (48):
Tell git to ignore files created during i18n preparation
WINGs: Fix incorrect use of macro USE_PANGO in installed header
Fix usage of float constant reported by gcc
wraster: Remove duplicate code
WINGs: increase temporary buffer to silence a gcc warning
WINGs: Fix invalid handling of Blue in the HSV conversion in ColorPanel widget
WPrefs: fix memory leak and potential buffer overflow
Fix memory leak reported by Coverity
Fix use-after-free error in wIconStore reported by Coverity
WPrefs: Fix memory leak in the Menu tab
WPrefs: Fix memory leak in Expert tab
WUtil: Fix non-closed file handle in WMWritePropListToFile
WUtil: Make sure wmalloc/wrealloc won't fail because of the abort handler
WPrefs: Provide fall-back colour in the case of colour name not found
WPrefs: Add check for invalid OPEN_MENU/EXEC in PL-Menu to avoid potential crash
WRaster: Stop parsing number in PPM file if invalid syntax is found
WRaster: Properly set file's mtime in the cache when loading an image
wmmenugen: Fix memory leak when parsing categories in an XDG menu
wmmenugen: Fix memory leak when parsing names for menus in XDG format
wmmenugen: Fix memory leaks in XDG menu generation when getting locale-dependant name
wmmenugen: Fix memory leaks when parsing menu in wmconfig format
wrlib: Add compiler attributes to the API functions
wmaker: Do not allocate memory for a temporary string for the Window Shortcut menu
WRaster: Create structure to make the library translatable
WRaster: Create header for i18n helper functions
WRaster: Add initialisation for locale support
WRaster: Made a few messages translatable
WRaster: Improve error messages to provide useful information to user
WRaster: Create french translation to have at least one
WRaster: Fix incorrect use of macro USE_XSHM in installed header
Configure: Rewrite detection for Xft2 to properly use PKG_CONFIG macro
Configure: Rewrite the macro for checking Xft2 version
Configure: Rewrite the detection for Pango library
Repair compilation when Pango support is enabled
Configure: Add a maintainer option to prepare generation of HTML for the website
Website: Create script to generate the HTML version of the man pages
Website: Create script to update the list of man pages in the index
WINGs: Properly mark 'const' more 'char*' in the public API
WPrefs: Use the constants added in config-paths.h for paths
Utils: Use the constants added in config-paths.h for paths
Configure: Add an error message when using deprecated "--with-defsdatadir"
WINGs: Fix incomplete prototypes for functions that take no argument
WINGs: Simplify wglobaldefaultspathfordomain
Configure: Place the argument checks at the beginning of execution
Configure: Fix non-working libbsd usage when explicitly requested
Util: Rewrite error message generation to avoid potential problem
WINGs: Simplify function wstrconcat
WINGs: in WText, do not re-query Atom value every time they are used

David (1):
wmiv: use W_KeycodeToKeysym instead of XkbKeycodeToKeysym

David Maciejak (98):
Fix missing linefeed on the error message
WINGs: Fix incorrect findCloseColor exact flag value
SwitchPanel: make sure WMRetainColor and WMReleaseColor calls are even
Fix icon.c unused variable compiler warning
Fix wrong XKeycodeToKeysym index value
Info Panel: use system time to get the current year
Info Panel: mallinfo is deprecated use mallinfo2 instead
InfoPanel: fix out of display text
WINGs: allow keypad enter key to validate button
Set a better exit panel message
Info Panel: display more OS details
WRaster: Avoid types deprecated with libtiff 4.3
Ignore WM_NORMAL_HINTS resize increment for maximized windows
Info Panel: Fix uninitialized posn variable
Fix mini workspace compiler warnings
Add support for _NET_WM_FULLSCREEN_MONITORS
WRaster: Avoid undefined setjmp() behavior with libjpeg
Factorize duplicate run command code
Allow exit panel to be bound to a key shortcut
Allow WM_COMMAND-less app to autostart
Set missing WM_COMMAND using pid given from libXRes
Info Panel: Add libXRes info if supported
Make window maximize state persistent
Detect and override illegal window size hints v2
Fix compiler warning from menu.c
Fix compiler warnings from texture.c
Fix compiler warnings from texture.c v2
WPrefs: check if captured keyboard shortcut is not in use
Doc: add disable-res description
Code cleaning: removing trailing space
Compile by default with POSIX 7 revision
Store window maximize state as hex value
WINGs: Add W_KeycodeToKeysym to replace XKeycodeToKeysym/XkbKeycodeToKeysym calls
WPrefs: use W_KeycodeToKeysym instead of XkbKeycodeToKeysym
Use W_KeycodeToKeysym instead of XkbKeycodeToKeysym
Coverity: fix potential buffer overflow
Coverity: fix wmiv resource leak
Coverity: fix RContextAttributes uninitialized variable
Coverity: fix wmspec uninitialized layer variable
WRaster: add functions to save image on disk
Coverity: fix menuparser_macro uninitialized pointer read
Coverity: fix misc resource leak
Coverity: fix setstyle resource leak
Coverity: fix wcolorpanel uninitialized scalar value
Coverity: fix rootmenu structurally dead code
Coverity: fix wmsetbg string not null terminated
Coverity: fix xmodifier uninitialized scalar variable
Coverity: fix session resource leak
Coverity: fix WRaster convert uninitialized scalar variable
Coverity: fix WPrefs editmenu uninitialized scalar variables
Coverity: fix WPrefs appearance time of check time of use
Coverity: fix dialog dereference null return value
Coverity: fix WPrefs texturepanel negative array index read
Coverity: fix WPrefs preference negative array index read
Coverity: fix WPrefs mousesettings menu negative array index read
Coverity: fix WPrefs menu negative array index read
Coverity: fix WPrefs appearance negative array index read
Coverity: fix wmspec dereference after null check
Coverity: fix wmmenugen resource leak
Coverity: fix wmgenmenu resource leak
WRaster: add new file references for translation
Coverity: fix util wmsetbg resource leak
Coverity: fix WPrefs workspace negative array index read
Coverity: fix WRaster convert uninitialized scalar variable
WPrefs: sort alphabetically the key shortcut actions and expert options
Convert tile.xpm X11 color name to hex
Use wtokenfree whenever there is wtokensplit
Util: fix wmgenmenu memory leak and help msg
WPrefs: convert workspacename.xpm X11 color name to hex
WINGs: comment out wtext unused NOTIFY macro
WINGs: Make the test examples to compile
Add a screenshot capture feature
Update news and changelog files
NEWS: add entry for libXRes support
SwitchPanel: fix app icons opacity combination
WINGs: handle fixed size windows
WINGs: W_KeycodeToKeysym remove unnecessary if test
Workspace pager: display ? on non visited mini workspace
Update file headers year copyright
Window titlebar double click to unmaximize
WINGs: Make the Extras examples to compile
Info Panel: display proper number of colors in deepcolor env
KeepDockOnPrimaryHead: fix drawer direction
wmiv: align version with wm
Restore proper drawer direction when screen was resized
Window menu: add maximization visual indicators
WPrefs: update maximization feature descriptions
Update window.c copyright
Fix ICCM ConfigureNotify request
Add some more cases to handle window unusual size request
WPrefs: fix keyboard shortcut sorting order
Fix internal function name typo
Hot corners feature core
WPrefs: Hot corner preferences
NEWS: Hot corners feature description
Add central position feature for active window
Set proper motif wm hints name
Fix autoconf obsolete macros

David Michael (1):
configure: Allow changing default search paths

Diedrich Vorberg (1):
Patch for GetCommandForPid() in osdep_darwin.c

Doug Torrance (19):
Remove apostrophes from instances of possessive "its".
Remove trailing whitespace.
configure: Fix typo in libXmu check.
wmlib: Use X flags from configure
debian: Update with version 0.95.9-1 packaging.
wrlib: Compile with either ImageMagick 6 and 7
Fix various abs() issues.
debian: Update with version 0.95.9-2 packaging.
checkpatch.pl: Escape curly braces in regexes
debian: Remove ImageMagick patch; an equivalent patch now exists in next
wrlib: Fix typo in macro containing ImageMagick version
Turn off automake's warning messages about using GNU make extensions
Convert po/README from iso-8859-1 to utf-8
Convert WindowMaker/README from iso-8859-1 to utf-8
Convert WPrefs.app/po/README from iso-8859-1 to utf-8
Use quotes around "Window Maker" in translated manpage title headers
Convert Czech language manpages from ISO-8859-2 to UTF-8
Convert Slovak language manpages from ISO-8859-2 to UTF-8
Move declarations to beginning of switch statements

Helge Kreutzmann (1):
Tippfehler in de.po von WPrefs (WindowMaker)

John D Pell (17):
WINGs: Simplify use of HAVE_SECURE_GETENV
WINGs: Improve search path logic in WMPathForResourceOfType
WMaker: Use wdefaultspathfordomain() to get path for Defaults directory
WPrefs: Use wdefaultspathfordomain() to build path to the root menu file
WMaker: Fix logical-not operator in framewin.c
WINGs: Properly mark 'const' some 'char*' in the public API
Add definition of directory names used for building paths in common header
WUtil: New function wuserdatapath() to get path for application data
Use wuserdatapath() everytime it is applicable
WINGs: Use the constants added in config-paths.h for paths
WMaker: Store history in $XDG_STATE_HOME if defined
Configure: Rename setting DEFSDATADIR to PKGCONFDIR
Default Files: Replace misleading variables 'defsdatadir' in Makefiles
Change generation of Data Dir in the global header
WUtil: Be more strict about base directory for wrmdirhier()
WUtil: Be more strict about base directory for wmkdirhier()
wmaker.inst: remove all modification to ~/.xinitrc

Nick Berendsen (1):
Add support for _NET_WM_STATE_FOCUSED

Petre Rodan (1):
Fix segfault on right-click sweep of menu

Roman Dobosz (4):
Fix typo on defining imagemagick version.
Remove Debian related build files.
Correct way for reserved space on multihead environment.
Correct calculation of usable space for reserved area.

Torrance, Douglas (20):
Use wmkdirhier instead of mkdir to create color config directory
Fix segfault in color picker
Add desktop file for display manager session configuration
Include wmaker.desktop in distribution tarball
Add WPrefs to XDG desktop menu
Add new "KeepDockOnPrimaryHead" option
Document "KeepDockOnPrimaryHead" option in NEWS
Add "KeepDockOnPrimaryHead" checkbox to WPrefs experts panel
Keep dock on primary head if KeepDockOnPrimaryHead is YES
Add helper function for computing the dock's x position
Support "KeepDockOnPrimaryHead" when initially creating dock
Support "KeepDockOnPrimaryHead" when restoring state
Add default value of "KeepDockOnPrimaryHead" to Defaults/WindowMaker
Rename swapDock to wDockSwap and add to dock.h
Update the dock position when "KeepDockOnPrimaryHead" is changed
Use dock's position to determine position of dock menu
Use actual x position of dock when saving state
Use dock to determine whether drawer is on right side when swapping
Correctly draw window snapping hints on multi-head systems
Include screen.h in dialog.h for definition of WScreen

XOR (1):
WPrefs: Create Turkish translation

Xander (2):
Add icon sizes
Make dock dots scalable

-----------------------------------------------------------------------


repo.or.cz automatic notification. Contact project admin crm...@gmail.com
if you want to unsubscribe, or site admin ad...@repo.or.cz if you receive
no reply.
--
wmaker-crm.git ("The Window Maker window manager")

[Carlos R. Mafra]

Window Maker 0.96.0 has been released, see shortlog below to
see what changed.

Window Maker is extremely stable, fast and lightweight. I thank all
the contributors and testers that helped keeping it that way.

Although Window Maker is not bug-free, it should be close enough.
However, there may be some peculiarities with this release, related to
the dock positioning patches. To be on the safe side, I recommend
backing up the WMState configuration file. For example:

cp GNUstep/Defaults/WMState GNUstep/Defaults/WMState-Aug2023

In case your workspace state is messed up when using this new release,
you'll be able to revert to the previous state. Please send reports to
the mailing list if that happens to you.

As always, if you have an itch to scratch feel free to send patches in!

Carlos

> --
> You received this message because you are subscribed to the Google Groups "Window Maker Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to wmaker-dev+...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/wmaker-dev/20230805075328.B325DBB955%40repo.or.cz.

[Andreas Metzler]

On 2023-08-05 "Carlos R. Mafra" <crm...@gmail.com> wrote:
> Window Maker 0.96.0 has been released, see shortlog below to
> see what changed.

Thank you. Could you also make a release (tarball) on
https://github.com/window-maker/wmaker/releases ?

TIA, cu Andreas

[Torrance, Douglas]

I went ahead and did this, and also added a link to the tarball and a new
NEWS entry at windowmaker.org.

Doug

[Carlos R. Mafra]

Thanks, Doug!

[Martin Dietze]

I have - with a bit of tweaking - successfully built an rpm on my Fedora 38 box. Attached you find the diff from the original SPEC file shipping with Fedora to what I used in the end.

In order to build:

1. dnf download --source WindowMaker
   
2. rpm -i /path/to/WindowMaker*.src.rpm
3. cd ${HOME}/rpmbuild/SOURCES
4. wget https://github.com/window-maker/wmaker/releases/download/wmaker-0.96.0/WindowMaker-0.96.0.tar.gz
5. cd ../SPECS
6. patch WindowMaker.spec </path/to/WindowMaker-spec.patch
7. rpmbuild -ba WindowMaker.spec

Looking forward to running it. Last time I tried I abandoned it again due to the lack of keyboard shortcuts for dual head, like being able to move windows between screens using the keyboard etc. Has there been improvement for 0.96.0?

[Andreas Metzler]

On 2023-08-05 "Carlos R. Mafra" <crm...@gmail.com> wrote:

> Window Maker 0.96.0 has been released, see shortlog below to
> see what changed.

[...]

Hello,

libwraster is broken. The symbol versioning was bumped from IBWRASTER6
to IBWRASTER7.

This is caused by script/generate-mapfile-from-header.sh which takes the
libtool version current:revision:age (7:0:1) and uses the "current" (7)
for the symbol version. Which is wrong, it must not change unless the
soname (i.e. on linux $current minus $age = 6) changes.

cu Andreas
--
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'

[Christophe]

----- Andreas Metzler <amet...@bebt.de> a écrit :

> On 2023-08-05 "Carlos R. Mafra" <crm...@gmail.com> wrote:
>
> libwraster is broken. The symbol versioning was bumped from IBWRASTER6
> to IBWRASTER7.
>
> This is caused by script/generate-mapfile-from-header.sh which takes the
> libtool version current:revision:age (7:0:1) and uses the "current" (7)
> for the symbol version. Which is wrong, it must not change unless the
> soname (i.e. on linux $current minus $age = 6) changes.

Hello Andreas,

Actually, the script does not use any trick, the version is defined by WRASTER_CURRENT in the configure.ac file (line 74).

The version have been incremented from 6 to 7 in commit c8883fdbb0ac
This is because a new public function have been added (RSaveTitledImage), which changes the API, so David strictly followed the rules from the documentation of libtool:
« 4. If any interfaces have been added, removed, or changed since the
last update, increment current, and set revision to 0. »

I don't know how to handle this issue, but on a conceptual point of view this look the correct (expected) behaviour.

Regards,
Christophe.

[Andreas Metzler]

On 2023-08-09 Christophe <christop...@free.fr> wrote:
> ----- Andreas Metzler <amet...@bebt.de> a écrit :

[...]

>> libwraster is broken. The symbol versioning was bumped from IBWRASTER6
>> to IBWRASTER7.

>> This is caused by script/generate-mapfile-from-header.sh which takes the
>> libtool version current:revision:age (7:0:1) and uses the "current" (7)
>> for the symbol version. Which is wrong, it must not change unless the
>> soname (i.e. on linux $current minus $age = 6) changes.

> Actually, the script does not use any trick, the version is defined by WRASTER_CURRENT in the configure.ac file (line 74).

> The version have been incremented from 6 to 7 in commit c8883fdbb0ac
> This is because a new public function have been added (RSaveTitledImage), which changes the API, so David strictly followed the rules from the documentation of libtool:
> « 4. If any interfaces have been added, removed, or changed since the
> last update, increment current, and set revision to 0. »

> I don't know how to handle this issue, but on a conceptual point of view this look the correct (expected) behaviour.

Hello,

I totally agree with the libtool versioning going from 6:0:0 to
7:0:1. However going from there to changing the symbol versioning is
wrong. Any program built against libwraster 0.95.9 will fail to run
against 0.96.0.

"the script does not use any trick" - That is the bug. One cannot simply
use the C component of the C:R:A libtool version as symbol version.

[Andreas Metzler]

On 2023-08-10 Andreas Metzler <amet...@bebt.de> wrote:
[...]

> "the script does not use any trick" - That is the bug. One cannot simply
> use the C component of the C:R:A libtool version as symbol version.

Something like attached patch would work.

cu Andreas

PS: Can we please have a release-candidate next time?

[Christophe]

Hi Carlos,

I am proposing the attached patch to fix the issue, which implements Andres' solution slightly differently and with comments to explain what's going on for when we'll need to look at it later and will have forgotten about it.

I am not a big fan of current solution (it has a case where it could show its limit), but it seems to be libtool's philosophy, so it's the best we can do.

Unfortunatly, I guess you'll have to make a new release ("bugfix")...

Regards,
Christophe.

----- Andreas Metzler <amet...@bebt.de> a écrit :

> --
> You received this message because you are subscribed to the Google Groups "Window Maker Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to wmaker-dev+...@googlegroups.com.

> To view this discussion on the web visit https://groups.google.com/d/msgid/wmaker-dev/ZNURR34V6bG8700q%40argenau.bebt.de.

[Andreas Metzler]

On 2023-08-11 Christophe <christop...@free.fr> wrote:
> Hi Carlos,

> I am proposing the attached patch to fix the issue, which implements Andres' solution slightly differently and with comments to explain what's going on for when we'll need to look at it later and will have forgotten about it.

> I am not a big fan of current solution (it has a case where it could show its limit), but it seems to be libtool's philosophy, so it's the best we can do.

> Unfortunatly, I guess you'll have to make a new release ("bugfix")...

Thank you Christophe! The patch seems to have been lost in transmittion,
though.

cu Andreas