[PATCH] wmaker: manage small windows instead of discarding them

4 views
Skip to first unread message

david.m...@gmail.com

unread,
Sep 19, 2026, 9:27:38 AMSep 19
to Window Maker Development

hi,

Regarding the issue described at  https://github.com/window-maker/wmaker/issues/71
I think the test is indeed to broad, and while I was testing with virtualbox 7.2.16 I believe they fixed the issue on their side so wmaker don't need that window size check anymore.



A MapRequest asks the window manager to take over the window, so refusing
to manage 1x1 placeholders only leaves clients such as qiv unmapped
forever. Manage them and let the following resize fix the geometry.
Genuinely internal windows should be override-redirect.

---
 src/window.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/src/window.c b/src/window.c
index d93b65ee..efa56f8a 100644
--- a/src/window.c
+++ b/src/window.c
@@ -834,15 +834,6 @@ WWindow *wManageWindow(WScreen *scr, Window window)
  /* get geometry stuff */
  wClientGetNormalHints(wwin, &wattribs, True, &x, &y, &width, &height);
 
- /* Some applications create placeholder windows with 1x1 size
-  * (e.g. VirtualBox internal windows). Don't manage those initial
-  * 1x1 windows. */
- if (width <= 1 && height <= 1 && !wwin->flags.is_dockapp) {
- wWindowDestroy(wwin);
- XUngrabServer(dpy);
- return NULL;
- }
-
  /* get colormap windows */
  GetColormapWindows(wwin);
 
--
2.43.0
0001-wmaker-manage-small-windows-instead-of-discarding-th.patch
Reply all
Reply to author
Forward
0 new messages