On Fri, 7 May 2021 11:27:52 -0700 (PDT)
Xander <
charle...@gmail.com> wrote:
> Thank you, Roman. However, I did an updated version of wmamixer,
> which is a bit better. The one you adapted was poorly written, and
> the new one has certain improvements - like conf file monitoring,
> standard GUI proportions, configurable border colors. Of course,
> in case you don't mind that it depends on my implementation
> of libdockapp, that is :-)
Besides X libs, the only dependence I have is the alsa library. I
didn't rely on the libdockapp before, and not sure, if I need to :)
The implementation is not great, I admit ;) there is no coincidence
that I put it on experimental branch - I'm planning to improve it a
bit.
As a side note. Before jumping into changing dockapps, wmaker has to
be updated first, to gain support for that feature.
As for libdockapp, whatever changes you've made to your version of
that lib (didn't look at it yet), for sure it needed to be synced with
upstream one first (or made it a separate library if it doesn't
overlap with the existing functions - it's up to you), before updating
any dockapp - we don't want to break any of them, which are using
original one. Versioning also could help especially for OS packages
maintainers.
And last but not least - in your repository there are dockapps which
are still maintained by original authors (so outside of dockapp
umbrella which is maintained by Doug), so my thinking is, that at
least you should contact them and/or propose a PM/PR to their
repositories.
(I'm also not a fan for keeping bunch of unrelated projects - dockapps
in one repository, since distributing it can be a potential pain, but
meh, its a matter of taste I guess)
Just my 2 cents :)
--
-^- _ enjoying the silence
_ /O)_\//
(_(|__(_(_) grf.