win_sparkle_get_automatic_check_for_updates() and win_sparkle_set_automatic_check_for_updates()

[Allen Fisher]

Hi All--

I've started using these in code (was getting ready to create this
specific functionality--thanks!) and during code review someone
wondered if they should use booleans instead of ints. Would anyone
object to me creating a pull request with this change?

--
--
Allen

[Václav Slavík]

Hi,

On 5 Mar 2013, at 01:46, Allen Fisher <allen....@gmail.com> wrote:
> and during code review someone
> wondered if they should use booleans instead of ints.

WinSparkle is a C, not C++, header, and there was no such thing as "bool" in C until C99. Visual Studio is still not a C99 compiler, so it can't be used; BOOL would be more usable, but I'd rather not include windows.h just for that. Finally, the use of C and common types for the public API is for the purpose of easy use from other languages.

IOW, there would be considerable drawbacks to using anything other than int or some error code enum. And I don't think there would be any actual benefits, would there?

Regards,
Vaclav

[Allen Fisher]

This is why I asked. Just was curious about the ramifications should I
make a change. Just seemed a bit more user friendly, but I agree the
downsides are much more than the benefit.

Cheers,

Allen

> --
> You received this message because you are subscribed to the Google Groups "WinSparkle" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to winsparkle+...@googlegroups.com.
> To post to this group, send email to winsp...@googlegroups.com.
> Visit this group at http://groups.google.com/group/winsparkle?hl=en.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>



--
--
Allen