Issue 477 in winetricks: 'pwd' path is hardcoded

[winet...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 477 by nikoa...@gmail.com: 'pwd' path is hardcoded
https://code.google.com/p/winetricks/issues/detail?id=477

This breaks 'winetricks' for distributions with non-FHS layouts, such as
NixOS. Provided patch fixes the issue. I don't know, but *maybe* this would
cause breakage on OS X (I don't have one to test); they should have 'pwd'
in PATH too though, shouldn't they?

Attachments:
winetricks.patch 461 bytes

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[winet...@googlecode.com]

Updates:
Status: Fixed

Comment #1 on issue 477 by austin...@gmail.com: 'pwd' path is hardcoded
https://code.google.com/p/winetricks/issues/detail?id=477

Thanks for reporting, fixed by
https://code.google.com/p/winetricks/source/detail?r=72516176a4ea6927356275d6829be208c9c7c66b

it works fine on OSX, note that pwd is called in two other places without a
specified path.

[winet...@googlecode.com]

Comment #2 on issue 477 by daniel.r...@gmail.com: 'pwd' path is hardcoded
https://code.google.com/p/winetricks/issues/detail?id=477

/bin/pwd was specified to avoid getting the shell's builtin pwd, which
gives a
different answer sometimes (if pwd was reached via a symlink, say).

It's possible this change breaks some users.

[winet...@googlecode.com]

Comment #3 on issue 477 by nikoa...@gmail.com: 'pwd' path is hardcoded
https://code.google.com/p/winetricks/issues/detail?id=477

Thanks! I'll update NixOS package repository. If there are breakages and
you revert or change this, please make a note here! Personally I don't
think shell's pwd would break things.

[winet...@googlecode.com]

Comment #4 on issue 477 by nikoa...@gmail.com: 'pwd' path is hardcoded
https://code.google.com/p/winetricks/issues/detail?id=477

Can you please consider this patch too? As with the previous one, we use
just 'perl' in some places, so this shouldn't hurt. This would allow to
remove the last NixOS-specific patch.

Attachments:
winetricks.patch 381 bytes

[winet...@googlecode.com]

Comment #5 on issue 477 by austin...@gmail.com: 'pwd' path is hardcoded
https://code.google.com/p/winetricks/issues/detail?id=477

Please file that as a separate issue.