marcus@jet.franken.de: [PATCH] wininet: removed redundant NULL check (coverity)

1 view
Skip to first unread message

Patchwatcher

unread,
Nov 1, 2008, 4:53:16 AM11/1/08
to wine-patch...@googlegroups.com
From: Marcus Meissner <mar...@jet.franken.de>
Subject: [PATCH] wininet: removed redundant NULL check (coverity)
Date: Sat, 1 Nov 2008 09:40:59 +0100


Hi,

CID 803, the if (!STHook) check is not necessary,
since this if() is only entered if the lpBuffer variable,
which is assigned to STHook is not NULL.

So its truely superflous.

ciao, Marcus
---
dlls/wininet/http.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c
index a3d04d9..e088fa4 100644
--- a/dlls/wininet/http.c
+++ b/dlls/wininet/http.c
@@ -2354,8 +2354,6 @@ static BOOL HTTP_HttpQueryInfoW( LPWININETHTTPREQW lpwhr, DWORD dwInfoLevel,

tmpTM = *gmtime(&tmpTime);
STHook = (SYSTEMTIME *)lpBuffer;
- if (!STHook) return bSuccess;
-
STHook->wDay = tmpTM.tm_mday;
STHook->wHour = tmpTM.tm_hour;
STHook->wMilliseconds = 0;
--
1.5.6


Reply all
Reply to author
Forward
0 new messages